skip flaky test #70881
Merged
skip flaky test #70881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
reviewed
Nov 19, 2020
|
|
||
| - (void)testFlutterViewWarm { | ||
| // TODO(dnfield): this test has become flaky, fix https://github.com/flutter/flutter/issues/70630 and re-enable. | ||
| - (void)skip_testFlutterViewWarm { |
Member
There was a problem hiding this comment.
Can you instead uncheck it from the scheme instead of the skip_ prefix, but leave the comment? (I'm happy to do it if needed)
Contributor
Author
There was a problem hiding this comment.
I'm in the middle of reinstalling Xcode - you might be able to get to this more quickly than I can right now if you don't mind.
Contributor
Author
There was a problem hiding this comment.
ok I'm on it now, install finished
Contributor
Author
|
Landing on red to help make tree green. |
This was referenced Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #70630 and #70631