Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Dec 4, 2020

Description

module_test_ios FlutterUITests are flaky--the elements aren't being "found" even though they are in the tree. Turn the tests off.

[module_test_ios] [STDOUT] stdout:     t =     2.82s Tap "Full Screen (Cold)" Button
[module_test_ios] [STDOUT] stdout:     t =     2.82s     Wait for io.flutter.add2app.Host to idle
[module_test_ios] [STDOUT] stdout:     t =     2.83s     Find the "Full Screen (Cold)" Button
[module_test_ios] [STDOUT] stdout:     t =     2.87s     Check for interrupting elements affecting "Full Screen (Cold)" Button
[module_test_ios] [STDOUT] stdout:     t =     2.88s     Synthesize event
[module_test_ios] [STDOUT] stdout:     t =     2.95s     Wait for io.flutter.add2app.Host to idle
[module_test_ios] [STDOUT] stdout:     t =     3.26s Waiting 60.0s for "Button tapped 0 times." Other to exist
[module_test_ios] [STDOUT] stdout:     t =     4.27s     Checking `Expect predicate `exists == 1` for object "Button tapped 0 times." Other`
[module_test_ios] [STDOUT] stdout:     t =     4.27s         Checking existence of `"Button tapped 0 times." Other`
[module_test_ios] [STDOUT] stdout:     t =     4.28s         Capturing element debug description
[module_test_ios] [STDOUT] stdout:     t =     5.29s     Checking `Expect predicate `exists == 1` for object "Button tapped 0 times." Other`
...
[module_test_ios] [STDOUT] stdout:     t =    63.27s Assertion Failure: FlutterUITests.m:22: (([app.otherElements[@"Button tapped 0 times."] waitForExistenceWithTimeout:60.0]) is true) failed
[module_test_ios] [STDOUT] stdout:     t =    63.29s Tear Down
[module_test_ios] [STDOUT] stderr: Failing tests:
[module_test_ios] [STDOUT] stderr: 	FlutterUITests:
[module_test_ios] [STDOUT] stderr: 		-[FlutterUITests testDualCold]
[module_test_ios] [STDOUT] stderr: 		-[FlutterUITests testFullScreenColdPop]
[module_test_ios] [STDOUT] stderr: 		-[FlutterUITests testFullScreenWarm]
[module_test_ios] [STDOUT] stderr: 		-[FlutterUITests testHybridViewWarm]

Related Issues

#70881
#70630

@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Dec 4, 2020
@jmagman jmagman requested a review from dnfield December 4, 2020 18:28
@jmagman jmagman self-assigned this Dec 4, 2020
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Dec 4, 2020
@google-cla google-cla bot added the cla: yes label Dec 4, 2020
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- thanks!

@jmagman
Copy link
Member Author

jmagman commented Dec 4, 2020

Landing on red to unblock the roll yolo

@jmagman jmagman merged commit e5f2236 into flutter:master Dec 4, 2020
@jmagman jmagman deleted the xcui-tests-disable branch December 4, 2020 18:30
@dnfield
Copy link
Contributor

dnfield commented Dec 4, 2020

@stuartmorgan has mentioned that these types of tests sometimes just fail in his experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants