Skip to content

[flutter_releases] Flutter 1.22.4 framework cherrypicks#70327

Merged
christopherfujino merged 4 commits into
flutter:flutter-1.22-candidate.12from
chris-forks:cherrypicks-flutter-1.22-candidate.12
Nov 13, 2020
Merged

[flutter_releases] Flutter 1.22.4 framework cherrypicks#70327
christopherfujino merged 4 commits into
flutter:flutter-1.22-candidate.12from
chris-forks:cherrypicks-flutter-1.22-candidate.12

Conversation

@christopherfujino

@christopherfujino christopherfujino commented Nov 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

previous build

Scheduled Cherrypicks

Known Presubmit Failures

Known Postsubmit Failures

@jmagman @christopherfujino
App.framework must support iOS 8 for older Flutter projects (flutter#…
16620de 
…68729)

* App.framework must support iOS 8 for older Flutter projects

* Fix test
@flutter-dashboard flutter-dashboard Bot added a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 11, 2020
@christopherfujino christopherfujino changed the base branch from master to flutter-1.22-candidate.12 November 11, 2020 23:03
@flutter-dashboard

flutter-dashboard Bot commented Nov 11, 2020

Copy link
Copy Markdown

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard Bot changed the base branch from flutter-1.22-candidate.12 to master November 11, 2020 23:03
@christopherfujino christopherfujino removed the request for review from Piinks November 11, 2020 23:03
@google-cla

google-cla Bot commented Nov 11, 2020

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no label Nov 11, 2020
@christopherfujino christopherfujino removed the request for review from jmagman November 11, 2020 23:03
@christopherfujino christopherfujino marked this pull request as draft November 11, 2020 23:03
@google-cla

google-cla Bot commented Nov 11, 2020

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@christopherfujino christopherfujino changed the base branch from master to flutter-1.22-candidate.12 November 11, 2020 23:18
@christopherfujino christopherfujino mentioned this pull request Nov 11, 2020
Closed
@google-cla google-cla Bot added cla: yes and removed cla: no labels Nov 12, 2020
@jmagman

jmagman commented Nov 12, 2020

Copy link
Copy Markdown
Member

Validated --observatory-port on simulator #70325:

$ flutter run --observatory-port 8888      

An Observatory debugger and profiler on iPhone 12 Pro Max is available at:
http://127.0.0.1:8888/fmeLwUzg6_k=/

Validated flutter run on a ARM mac on a real device with no ibtool crash #65133, flutter doctor shows darwin-arm #67970

@christopherfujino christopherfujino force-pushed the cherrypicks-flutter-1.22-candidate.12 branch from 37b52c1 to bb761ea Compare November 12, 2020 18:21
@christopherfujino christopherfujino force-pushed the cherrypicks-flutter-1.22-candidate.12 branch from bb761ea to 7e3a894 Compare November 12, 2020 19:42
@christopherfujino christopherfujino marked this pull request as ready for review November 12, 2020 20:49
@christopherfujino christopherfujino requested review from jmagman and pcsosinski and removed request for jmagman and pcsosinski November 12, 2020 20:50
@christopherfujino christopherfujino marked this pull request as draft November 12, 2020 20:52
@christopherfujino

christopherfujino commented Nov 12, 2020

Copy link
Copy Markdown
Contributor Author

Sorry, not ready for review yet, an engine build failed

@christopherfujino christopherfujino marked this pull request as ready for review November 13, 2020 00:55
jmagman
jmagman approved these changes Nov 13, 2020
View reviewed changes

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM. I validated the cherry-pick other than #58200, doing that now.

@christopherfujino christopherfujino merged commit 1aafb3a into flutter:flutter-1.22-candidate.12 Nov 13, 2020
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.22-candidate.12 branch November 13, 2020 17:59
@christopherfujino christopherfujino mentioned this pull request Dec 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christopherfujino @jmagman