Skip to content

Append comma to iOS simulator launch args list#70325

Closed
jmagman wants to merge 1 commit into
flutter:stablefrom
jmagman:comma
Closed

Append comma to iOS simulator launch args list#70325
jmagman wants to merge 1 commit into
flutter:stablefrom
jmagman:comma

Conversation

@jmagman

@jmagman jmagman commented Nov 11, 2020

Copy link
Copy Markdown
Member

Description

Trailing comma is missing from #63416, which is in the 1.22 stable. It was fixed in #65873 (1.23.0-3.0.pre), so no longer reproduces on beta.

Related Issues

Fixes #69722

Tests

simulators_test

@jmagman jmagman added the platform-ios iOS applications specifically label Nov 11, 2020
@jmagman jmagman self-assigned this Nov 11, 2020
@flutter-dashboard flutter-dashboard Bot changed the base branch from stable to master November 11, 2020 22:54
@flutter-dashboard

flutter-dashboard Bot commented Nov 11, 2020

Copy link
Copy Markdown

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to stable. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard Bot added a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 11, 2020
@google-cla google-cla Bot added the cla: yes label Nov 11, 2020
@jmagman jmagman changed the base branch from master to stable November 11, 2020 22:54
jonahwilliams
jonahwilliams approved these changes Nov 11, 2020
View reviewed changes

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman marked this pull request as ready for review November 11, 2020 23:45
@jmagman jmagman mentioned this pull request Nov 11, 2020
Closed
@christopherfujino christopherfujino mentioned this pull request Nov 12, 2020
Merged
@jmagman jmagman deleted the comma branch November 13, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jonahwilliams jonahwilliams jonahwilliams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--observatory-port stopped working in SDK 1.22.3

2 participants

@jmagman @jonahwilliams