Skip to content

Support targeting physical iOS devices on Apple Silicon #69212

Closed
jmagman wants to merge 4 commits into
flutter:flutter-1.22-candidate.12from
jmagman:mac-arm
Closed

Support targeting physical iOS devices on Apple Silicon #69212
jmagman wants to merge 4 commits into
flutter:flutter-1.22-candidate.12from
jmagman:mac-arm

Conversation

@jmagman

@jmagman jmagman commented Oct 28, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Stable hotfix PR.
flutter run works against physical iOS and Android devices. Also works from Xcode.

Does not work on:

Related Issues

#60118

Pull requests applied (with some merge conflicts resolved):
#65978
#67970
#68050
#68855

@flutter-dashboard flutter-dashboard Bot changed the base branch from stable to master October 28, 2020 17:24
@flutter-dashboard

flutter-dashboard Bot commented Oct 28, 2020

Copy link
Copy Markdown

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to stable. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard Bot added a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Oct 28, 2020
@google-cla google-cla Bot added the cla: yes label Oct 28, 2020
@jmagman jmagman changed the base branch from master to stable October 28, 2020 17:24
@jmagman jmagman removed a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 28, 2020
jonahwilliams
jonahwilliams approved these changes Nov 2, 2020
View reviewed changes

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcsosinski

pcsosinski commented Nov 5, 2020

Copy link
Copy Markdown

@jmagman should we move the target branch to flutter-1.22-candidate.12 for this?

@jmagman jmagman changed the base branch from stable to flutter-1.22-candidate.12 November 5, 2020 19:27
@flutter-dashboard flutter-dashboard Bot changed the base branch from flutter-1.22-candidate.12 to master November 5, 2020 19:27
@flutter-dashboard flutter-dashboard Bot requested a review from Piinks as a code owner November 5, 2020 19:27
@flutter-dashboard

flutter-dashboard Bot commented Nov 5, 2020

Copy link
Copy Markdown

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard Bot added a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 5, 2020
@jmagman jmagman changed the base branch from master to flutter-1.22-candidate.12 November 5, 2020 19:28
@jmagman jmagman removed a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Nov 5, 2020
@pcsosinski

pcsosinski commented Nov 5, 2020

Copy link
Copy Markdown

removing cp label in favor of #65133

@pcsosinski pcsosinski closed this Nov 5, 2020
@pcsosinski pcsosinski reopened this Nov 5, 2020
@pcsosinski

pcsosinski commented Nov 5, 2020

Copy link
Copy Markdown

mis-close, sorry :|

christopherfujino
christopherfujino approved these changes Nov 6, 2020
View reviewed changes

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this!

@christopherfujino

christopherfujino commented Nov 11, 2020

Copy link
Copy Markdown
Contributor

Closing this as I squash-merged this branch into #70327. Thanks again for opening it!

@christopherfujino christopherfujino mentioned this pull request Nov 11, 2020
Merged
@jmagman jmagman deleted the mac-arm branch December 22, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@christopherfujino christopherfujino christopherfujino approved these changes
@jonahwilliams jonahwilliams jonahwilliams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jmagman @pcsosinski @christopherfujino @jonahwilliams @gaaclarke