Added the machine's architecture to macos doctor results.#65978
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
left a comment
There was a problem hiding this comment.
Change seems reasonable, tests pls
jonahwilliams
left a comment
There was a problem hiding this comment.
The tests for this class are in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/base/os_test.dart
You can use the FakePlatform/FakeProcessManager to set things up to be consistent across platforms:
jmagman
left a comment
There was a problem hiding this comment.
I think this needs to be a bigger change, piping through a new TargetPlatform everywhere
Really, this shouldn't be hardcoded:
|
Oh I see, this isn't for a target device, it's for this output: |
Description
Now that apple supports multiple architectures I added the architecture to the flutter doctor output to help us track down bugs related to architecture.
Related Issues
#65976
Tests
none
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.