Skip to content

[FloatingActionButtonLocation] Add diagrams to documentation of FloatingActionButtonLocation#70184

Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom
royarg02:add_fab_location_diagrams
Nov 23, 2020
Merged

[FloatingActionButtonLocation] Add diagrams to documentation of FloatingActionButtonLocation#70184
fluttergithubbot merged 3 commits intoflutter:masterfrom
royarg02:add_fab_location_diagrams

Conversation

@royarg02
Copy link
Contributor

@royarg02 royarg02 commented Nov 10, 2020 •
edited
Loading

Description

This PR adds diagrams showing the usage of FloatingActionButtonLocation.

The linked diagrams in the docs will be available once flutter/assets-for-api-docs#123 is merged.

Related Issues

Fixes #24732.

Tests

No tests, since it is just some additions to the documentation.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added the f: material design flutter/packages/flutter/material repository. label Nov 10, 2020
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 10, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 10, 2020
@google-cla google-cla bot added the cla: yes label Nov 10, 2020
@HansMuller HansMuller requested a review from Piinks November 13, 2020 01:00
@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ documentation d: examples Sample code and demos labels Nov 19, 2020
Piinks
Piinks reviewed Nov 19, 2020
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @royarg02 thanks for the contribution! Just a small nit below.

packages/flutter/lib/src/material/floating_action_button_location.dart Outdated
Copy link
Contributor

@Piinks Piinks Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// The following diagrams show the available common placement locations for the FloatingActionButton.
/// The following diagrams show the available placement locations for the FloatingActionButton.

Copy link
Contributor Author

@royarg02 royarg02 Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it.

Piinks
Piinks approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Nov 19, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux framework_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-misc-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor

Piinks commented Nov 20, 2020

@royarg02 can you update your branch with the latest from master? The failing checks here are not caused by your PR.

@royarg02 royarg02 force-pushed the add_fab_location_diagrams branch from 03461a2 to 2b0c69f Compare November 20, 2020 04:15
@royarg02
Copy link
Contributor Author

royarg02 commented Nov 20, 2020

@Piinks I've updated the branch.

@fluttergithubbot fluttergithubbot merged commit 5fbbd73 into flutter:master Nov 23, 2020
@royarg02
Copy link
Contributor Author

royarg02 commented Nov 24, 2020 •
edited
Loading

Hey @Piinks sorry to bug you, but the docs aren't showing as expected in the website:

fab_location_doc

Update: This has been fixed in #71378.

@royarg02 royarg02 deleted the add_fab_location_diagrams branch March 4, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FloatingActionButtonLocation needs diagrams

3 participants

@royarg02 @fluttergithubbot @Piinks