Skip to content

Add diagrams for FloatingActionButtonLocation#123

Merged
gspencergoog merged 4 commits intoflutter:masterfrom
royarg02:floating_action_button_location_diagrams
Nov 14, 2020
Merged

Add diagrams for FloatingActionButtonLocation#123
gspencergoog merged 4 commits intoflutter:masterfrom
royarg02:floating_action_button_location_diagrams

Conversation

@royarg02
Copy link
Contributor

Adds diagrams for the different predefined values of FloatingActionButtonLocation.

Related issues

flutter/flutter#24732

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@gspencergoog
Copy link
Contributor

Sorry, could you also sort the dependencies in the pubspec.yaml too? I know your didn't introduce the problem, but it would help the analyzer test pass.

@royarg02
Copy link
Contributor Author

Hello @gspencergoog the CI is failing on deprecated parameters.

Should I just change the code accordingly? Or do I need to regenerate the assets too?

@gspencergoog
Copy link
Contributor

Sorry, I didn't realize this repo was in such a mess.

I fixed all the analyzer problems and updated the diagrams in #124

Just pull again, resolve any conflicts, and you should be good to go.

@royarg02 royarg02 force-pushed the floating_action_button_location_diagrams branch from 5138dea to e96d768 Compare November 14, 2020 08:14
@gspencergoog gspencergoog merged commit cf8cbab into flutter:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants