Skip to content

Conversation

@gayanpathirage
Copy link

@gayanpathirage gayanpathirage commented Nov 1, 2020

Description

flutter doctor reports "Flutter plugin not installed" and "Dart plugin not installed" errors for Android Studio 4.1 and above in MacOS. Issue #69514 is reported due to that. This is the fix for that issue in flutter doctor.

Related Issues

#69514

Tests

No tests modified

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

renyou and others added 8 commits September 11, 2020 14:46
* Deprecate VelocityTracker default constructor and added VelocityTracker.withKind constructor (flutter#66043)

* [flutter_tools] fix failure to create ansi spinner if download needs to be retried (flutter#65797)

* Listen to Debug VM stream to get Stdout logs from VMService (flutter#66310)

* Update cherry picked engine

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
Co-authored-by: Jenn Magder <magder@google.com>
* [Icons][iOS] Pointing to version of material icon font that includes more metadata in the xml. (flutter#66684)
* apply engine cherrypicks
* Page-subclasses to take children instead of builder (flutter#66694)
* Update pub dependencies to support dart 2.10.0
* cherry-pick 76ad864
* Fix the inconsistency between the local state of the input and the engine state (flutter#65754)

Co-authored-by: Will Larche <larche@google.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: xubaolin <xubaolin@oppo.com>
* [Docs] [Material] Fix Icons api docs (flutter#66508)

* [Docs] [Icons] Updating dart doc styles to recognize more styles of icons. All the 4 icon styles we support have to be pulled from 4 individual web fonts when we show the html page for api docs.

* Better documentation and that special awful case.

* Couple more places to remove.

* Add back the autovalidate class property (flutter#66267)

* Add back autovalidate property

* Add autovalidate property back (include tests)

* Fix typos

* One more test :)

* [flutter_tools] prevent running analyze-size with split-debug-info (flutter#66983)

Running a build command with split debug info and analyze size causes a crash in the snapshot analysis library. Disable the combination of these two flags.

Fixes flutter#66962

* fix invocatiion of non-existent function after cherry pick

* update engine revision

Co-authored-by: Will Larche <larche@google.com>
Co-authored-by: Pedro Massango <pedromassango.developer@gmail.com>
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
* [flutter_tools] support Android Studio 4.1 on Windows (flutter#67992)

Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.

fixes flutter#67986

* [gestures] make stylus pointer types use touch pan/drag slop (flutter#67885)

* Update engine cherrypicks

* pin customer_testing and add back windows to cirrus

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
* Fix TextField bug when the formatter repeatedly format (flutter#67892)
* Adjust constraints (flutter#68437)
* update engine

Co-authored-by: xubaolin <xubaolin@oppo.com>
Co-authored-by: Michael Thomsen <mit@google.com>
@flutter-dashboard flutter-dashboard bot changed the base branch from stable to master November 1, 2020 05:46
@flutter-dashboard flutter-dashboard bot requested a review from Piinks as a code owner November 1, 2020 05:46
@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to stable. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 1, 2020
@google-cla google-cla bot added the cla: yes label Nov 1, 2020
@gayanpathirage
Copy link
Author

This is originally intended as a hotfix to flutter doctor in the stable branch. Since it is kept on looking at the wrong path for plugins of Android Studio.

@jonahwilliams
Copy link
Contributor

We will not accept hotfix PRs for plugin fixes. If you're interested in working them please create a new PR for submission to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants