[Icons][iOS] Pointing to version of material icon font that includes more metadata in the xml. #66684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more metadata in the xml.
Member
|
LGTM. Any way we can test this? Such as by loading a custom font by file and name in an integration test and doing a golden test etc? Feel free to do it in a separate PR to unblock as well. |
Contributor
Author
|
@Piinks and I did chat about it. She says there's nothing at the moment but it would be not too hard to add. |
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Sep 28, 2020
…more metadata in the xml. (flutter#66684)
christopherfujino
added a commit
that referenced
this pull request
Sep 29, 2020
* [Icons][iOS] Pointing to version of material icon font that includes more metadata in the xml. (#66684) * apply engine cherrypicks * Page-subclasses to take children instead of builder (#66694) * Update pub dependencies to support dart 2.10.0 * cherry-pick 76ad864 * Fix the inconsistency between the local state of the input and the engine state (#65754) Co-authored-by: Will Larche <larche@google.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: xubaolin <xubaolin@oppo.com>
willlockwood
pushed a commit
to willlockwood/flutter
that referenced
this pull request
Dec 25, 2020
* [Icons][iOS] Pointing to version of material icon font that includes more metadata in the xml. (flutter#66684) * apply engine cherrypicks * Page-subclasses to take children instead of builder (flutter#66694) * Update pub dependencies to support dart 2.10.0 * cherry-pick 76ad864 * Fix the inconsistency between the local state of the input and the engine state (flutter#65754) Co-authored-by: Will Larche <larche@google.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: xubaolin <xubaolin@oppo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Material Icon font at this sha has nameIds at 0-6. (3-5 were not there before)
Related Issues
Fixes #65991
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.