Skip to content

Flutter 1.22.0-12.2.pre Framework cherrypicks #66500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christopherfujino merged 4 commits into from
Sep 25, 2020
Merged

Flutter 1.22.0-12.2.pre Framework cherrypicks #66500

christopherfujino merged 4 commits into from
Sep 25, 2020

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Sep 23, 2020 •
edited
Loading

Scheduled Cherrypicks

Jonah Williams and others added 3 commits September 23, 2020 15:42
@christopherfujino
Deprecate VelocityTracker default constructor and added VelocityTrack…
ded0213 
…er.withKind constructor (flutter#66043)

We've gotten feedback that the VelocityTracker change was disruptive, though it did not break any of the flutter framework or customer tests. In order to make the change non-breaking, PointerDeviceKind parameter can be made optional.

Nevertheless, this parameter should be provided so that the existing touch handlers can use more accurate gestures on mouse/stylus inputs, so we can encourage this by deprecating the default constructor and pointing users towards the VelocityTracker.withKind constructor that takes a non-optional parameter
@christopherfujino
[flutter_tools] fix failure to create ansi spinner if download needs …
c8f45c3 
…to be retried (flutter#65797)

Because the Status spinner was only created on setup, the second stop would asset/crash.

Fixes flutter#65449
@jmagman @christopherfujino
Listen to Debug VM stream to get Stdout logs from VMService (flutter#…
d79acb2 
…66310)
@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.22-candidate.12 to master September 23, 2020 22:55
@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 23, 2020

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. work in progress; do not review labels Sep 23, 2020
@christopherfujino christopherfujino changed the base branch from master to flutter-1.22-candidate.12 September 23, 2020 22:56
@christopherfujino christopherfujino changed the title Flutter 1.22.0-12.2.pre engine cherrypicks Flutter 1.22.0-12.2.pre Framework cherrypicks Sep 23, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 25, 2020
@christopherfujino christopherfujino marked this pull request as ready for review September 25, 2020 17:14
jmagman
jmagman approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#65519 LGTM

jonahwilliams
jonahwilliams approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

goderbauer
goderbauer approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino merged commit 2bafdc8 into flutter:flutter-1.22-candidate.12 Sep 25, 2020
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.22-candidate.12 branch September 25, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

@goderbauer goderbauer goderbauer approved these changes

@pcsosinski pcsosinski Awaiting requested review from pcsosinski

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@christopherfujino @jmagman @goderbauer @jonahwilliams @googlebot