Skip to content

Revert "Fix a multiple pointers bug"#68841

Merged
jonahwilliams merged 1 commit intomasterfrom
revert-68587-1020bug
Oct 23, 2020
Merged

Revert "Fix a multiple pointers bug"#68841
jonahwilliams merged 1 commit intomasterfrom
revert-68587-1020bug

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Oct 23, 2020

Reverts #68587

10:14 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:15 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:16 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:17 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:18 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:19 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:20 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:21 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:22 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:23 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:24 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:25 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:26 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:27 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:28 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:29 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:30 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:31 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:32 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:33 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:34 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:35 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:36 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:37 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:38 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:39 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:40 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:41 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:42 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:43 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:44 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:45 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:46 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:47 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:48 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:49 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:50 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:51 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:52 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:53 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:54 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:55 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:56 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:57 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:58 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
10:59 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:00 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:01 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:02 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:03 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:04 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:05 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:06 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:07 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:08 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:09 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:10 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:11 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:12 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:13 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:14 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:15 +3046 ~14: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations                                                     
11:15 +3046 ~14 -1: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: Screenshot composited transforms - with rotations [E]                                              
  TimeoutException after 0:10:00.000000: Test timed out after 10 minutes.
  dart:isolate  _RawReceivePortImpl._handleMessage
  

11:15 +3046 ~14 -1: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: getChildrenDetailsSubtree                                                                          
11:15 +3046 ~15 -1: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: getChildrenDetailsSubtree                                                                          
11:15 +3046 ~15 -1: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: InspectorSerializationDelegate addAdditionalPropertiesCallback                                     
11:16 +3046 ~15 -1: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: InspectorSerializationDelegate addAdditionalPropertiesCallback                                     
11:16 +3046 ~15 -1: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: InspectorSerializationDelegate addAdditionalPropertiesCallback                                     
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following StateError was thrown running a test:
Bad state: No element

When the exception was thrown, this was the stack:
#0      Iterable.first (dart:core/iterable.dart:524:7)
#1      _TestWidgetInspectorService.runTests.<anonymous closure> (file:///opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart:2649:59)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)

The test description was:
  Screenshot composited transforms - with rotations
════════════════════════════════════════════════════════════════════════════════════════════════════

11:16 +3046 ~15 -2: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: InspectorSerializationDelegate addAdditionalPropertiesCallback [E]                                 
  Test failed. See exception logs above.
  The test description was: Screenshot composited transforms - with rotations
  

11:16 +3046 ~15 -2: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: debugIsLocalCreationLocation test                                                                  
11:16 +3046 ~16 -2: /opt/s/w/ir/k/flutter/packages/flutter/test/widgets/widget_inspector_test.dart: debugIsLocalCreationLocation test                                                                  
11:16 +3046 ~16 -2: Some tests failed.                                                                                                                                                                 
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
ERROR: Last command exited with 1 (expected: zero).
Command: ../../bin/flutter test --no-track-widget-creation --enable-experiment=non-nullable --null-assertions --sound-null-safety test/widgets/
Relative working directory: packages/flutter
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

TBR @dkwingsmt

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 23, 2020
@jonahwilliams jonahwilliams merged commit b25ce5b into master Oct 23, 2020
@google-cla google-cla bot added the cla: yes label Oct 23, 2020
@jonahwilliams jonahwilliams deleted the revert-68587-1020bug branch October 23, 2020 02:16
@xu-baolin
Copy link
Member

xu-baolin commented Oct 23, 2020

Appears to be a flake. Looking into it.

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Oct 23, 2020

It failed on each of the windows/mac/linux shards so it seems unlikely to just be flaky.

@xu-baolin
Copy link
Member

xu-baolin commented Oct 23, 2020

Are the error messages in the log the same? Sorry, I can't view these logs.

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Oct 23, 2020

i posted the failure on the revert above

@xu-baolin xu-baolin mentioned this pull request Oct 24, 2020
Merged
@xu-baolin
Copy link
Member

xu-baolin commented Oct 29, 2020

@dkwingsmt Hi,
I'm sorry to bother you again. Do you have time to look at the failures? From the log at the description, it seems that it has nothing to do with our change, but I don't have permission to see all the logs. What is your opinion?

@dkwingsmt
Copy link
Contributor

dkwingsmt commented Oct 29, 2020

Sorry, I forgot this. I'll take a look later this evening and tomorrow. Thanks for the reminder!

dkwingsmt added a commit to dkwingsmt/flutter that referenced this pull request Oct 29, 2020
@dkwingsmt
Revert "Revert "Fix a multiple pointers bug (flutter#68587)" (flutter…
c9253fd 
…#68841)"

This reverts commit b25ce5b.
@dkwingsmt dkwingsmt mentioned this pull request Oct 29, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @xu-baolin @dkwingsmt