Fix a multiple pointers bug by xu-baolin · Pull Request #68587 · flutter/flutter

xu-baolin · 2020-10-20T09:50:44Z

Description

This bug can be reproduced with a high probability by #68373

The scenario where the bug occurs is:

Pointer 1 down and add two Recognize(TapGestureRecognizer & VerticalDragGestureRecognizer#5efda)
Pointer 2 down and add two Recognize(TapGestureRecognizer & VerticalDragGestureRecognizer#5efda)
Pointer 3 down and add two Recognize(TapGestureRecognizer & VerticalDragGestureRecognizer#5efda)
Pointer 4 down and add only one Recognize(VerticalDragGestureRecognizer#5efda)

Because there is only one gesture in Arena 4, the VerticalDragGestureRecognizer#5efda will win by default, and acceptGesture. Therefore, this gesture can no longer be accepted by another arena, otherwise, there will be the assertion information mentioned in the #68373.

Then release one of the fingers slightly before release all at the other fingers.

Why the issue happen?

From the log we can catch that:

When process the last finger event _TransformedPointerCancelEvent，What we expect is stopTrackingPointer and then reject this gesture, as the following code show:

  void _giveUpPointer(int pointer, {bool reject = true}) {
    stopTrackingPointer(pointer);
    if (reject) {
      if (_velocityTrackers.containsKey(pointer)) {
        _velocityTrackers.remove(pointer);
        resolvePointer(pointer, GestureDisposition.rejected);
      }
    }
  }

But when stop tracking the last pointer will call didStopTrackingLastPointer and clear the _velocityTrackers, This leads to the resolvePointer method cannot be called. This gesture becomes the last member and wins via sweeping incorrectly.

Related PR

This change is an improvement of #39017, @dkwingsmt Please review, thanks. :)

Log

Launching lib\main.dart on PDCM00 in debug mode...
Running Gradle task 'assembleDebug'...
Parameter format not correct -
√ Built build\app\outputs\flutter-apk\app-debug.apk.
Installing build\app\outputs\flutter-apk\app.apk...
Waiting for PDCM00 to report its views...
Debug service listening on ws://127.0.0.1:59993/0X88-HsbOEM=/ws
Syncing files to device PDCM00...
I/flutter ( 5750): Gesture arena 1    ❙ ★ Opening new gesture arena.
I/flutter ( 5750): Gesture arena 1    ❙ Adding: TapGestureRecognizer#93267(debugOwner: GestureDetector, state: ready, button: 1)
I/flutter ( 5750): addAllowedPointer this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.ready]
I/flutter ( 5750): Gesture arena 1    ❙ Adding: VerticalDragGestureRecognizer#aac43(start behavior: start)
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.possible]event[_TransformedPointerDownEvent#da02f(position: Offset(37.7, 134.0))][1]
I/flutter ( 5750): Gesture arena 1    ❙ Closing with 2 members.
I/flutter ( 5750): Gesture arena 2    ❙ ★ Opening new gesture arena.
I/flutter ( 5750): Gesture arena 2    ❙ Adding: TapGestureRecognizer#d4edf(debugOwner: GestureDetector, state: ready, button: 1)
I/flutter ( 5750): addAllowedPointer this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.possible]
I/flutter ( 5750): Gesture arena 2    ❙ Adding: VerticalDragGestureRecognizer#aac43(start behavior: start)
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.possible]event[_TransformedPointerDownEvent#ed1ae(position: Offset(48.7, 335.3))][2]
I/flutter ( 5750): Gesture arena 2    ❙ Closing with 2 members.
I/flutter ( 5750): Gesture arena 3    ❙ ★ Opening new gesture arena.
I/flutter ( 5750): Gesture arena 3    ❙ Adding: TapGestureRecognizer#3379a(debugOwner: GestureDetector, state: ready, button: 1)
I/flutter ( 5750): addAllowedPointer this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.possible]
I/flutter ( 5750): Gesture arena 3    ❙ Adding: VerticalDragGestureRecognizer#aac43(start behavior: start)
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.possible]event[_TransformedPointerDownEvent#68437(position: Offset(65.0, 192.3))][3]
I/flutter ( 5750): Gesture arena 3    ❙ Closing with 2 members.
I/flutter ( 5750): addAllowedPointer this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.possible]
I/flutter ( 5750): Gesture arena 4    ❙ ★ Opening new gesture arena.
I/flutter ( 5750): Gesture arena 4    ❙ Adding: VerticalDragGestureRecognizer#aac43(start behavior: start)
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.possible]event[_TransformedPointerDownEvent#1675a(position: Offset(63.7, 263.7))][4]
I/flutter ( 5750): Gesture arena 4    ❙ Closing with 1 member.
I/flutter ( 5750): Gesture arena 4    ❙ Default winner: VerticalDragGestureRecognizer#aac43(start behavior: start)
I/flutter ( 5750): acceptGesture pointer[4][VerticalDragGestureRecognizer#aac43(start behavior: start)]state[_DragState.possible]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#f3c66(position: Offset(37.7, 134.0))][1]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:53.504000]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#778c6(position: Offset(48.7, 335.3))][2]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:53.504000]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#6c668(position: Offset(65.0, 192.3))][3]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:53.504000]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#2ca47(position: Offset(63.7, 263.7))][4]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:53.504000]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#a0143(position: Offset(37.7, 134.0))][1]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:53.538000]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#355eb(position: Offset(48.7, 335.3))][2]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:53.538000]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#660c6(position: Offset(65.0, 192.3))][3]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:53.538000]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#09744(position: Offset(63.7, 263.7))][4]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:53.538000]
...
start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#aeb42(position: Offset(36.0, 131.0))][1]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:54.442000]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#e482e(position: Offset(48.7, 335.3))][2]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:54.442000]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#059bd(position: Offset(64.0, 193.3))][3]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:54.442000]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#91b4a(position: Offset(62.0, 267.0))][4]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:54.442000]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#64629(position: Offset(35.7, 131.0))][1]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:54.449000]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#cc7c2(position: Offset(64.0, 193.0))][3]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:54.449000]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerMoveEvent#4e474(position: Offset(62.0, 267.0))][4]
I/flutter ( 5750): handleEvent 2 this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]ts[745:29:54.449000]
I/flutter ( 5750): stopTrackingPointer pointer[2]_trackedPointers[{2}]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerUpEvent#42107(position: Offset(48.7, 335.3))][2]
I/flutter ( 5750): _giveUpPointer [0] [2]reject[false]_velocityTrackers[{1: Instance of 'VelocityTracker', 2: Instance of 'VelocityTracker', 3: Instance of 'VelocityTracker', 4: Instance of 'VelocityTracker'}]
I/flutter ( 5750): stopTrackingPointer pointer[2]_trackedPointers[{1, 2, 3, 4}]
I/flutter ( 5750): _giveUpPointer [1] [2]reject[false]_velocityTrackers[{1: Instance of 'VelocityTracker', 2: Instance of 'VelocityTracker', 3: Instance of 'VelocityTracker', 4: Instance of 'VelocityTracker'}]
I/flutter ( 5750): Gesture arena 2    ❙ Sweeping with 2 members.
I/flutter ( 5750): Gesture arena 2    ❙ Winner: TapGestureRecognizer#d4edf(debugOwner: GestureDetector, state: ready, finalPosition: Offset(48.7, 335.3), finalLocalPosition: Offset(48.7, 15.3), button: 1, sent tap down)
I/flutter ( 5750): _giveUpPointer [0] [2]reject[true]_velocityTrackers[{1: Instance of 'VelocityTracker', 2: Instance of 'VelocityTracker', 3: Instance of 'VelocityTracker', 4: Instance of 'VelocityTracker'}]
I/flutter ( 5750): stopTrackingPointer pointer[2]_trackedPointers[{1, 3, 4}]
I/flutter ( 5750): _giveUpPointer [1] [2]reject[true]_velocityTrackers[{1: Instance of 'VelocityTracker', 2: Instance of 'VelocityTracker', 3: Instance of 'VelocityTracker', 4: Instance of 'VelocityTracker'}]
I/flutter ( 5750): resolvePointer [2]disposition[GestureDisposition.rejected]_entries[{1: Instance of 'GestureArenaEntry', 2: Instance of 'GestureArenaEntry', 3: Instance of 'GestureArenaEntry', 4: Instance of 'GestureArenaEntry'}]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerCancelEvent#8b921(position: Offset(0.0, 0.0))][4]
I/flutter ( 5750): _giveUpPointer [0] [4]reject[true]_velocityTrackers[{1: Instance of 'VelocityTracker', 3: Instance of 'VelocityTracker', 4: Instance of 'VelocityTracker'}]
I/flutter ( 5750): stopTrackingPointer pointer[4]_trackedPointers[{1, 3, 4}]
I/flutter ( 5750): _giveUpPointer [1] [4]reject[true]_velocityTrackers[{1: Instance of 'VelocityTracker', 3: Instance of 'VelocityTracker', 4: Instance of 'VelocityTracker'}]
I/flutter ( 5750): resolvePointer [4]disposition[GestureDisposition.rejected]_entries[{1: Instance of 'GestureArenaEntry', 3: Instance of 'GestureArenaEntry', 4: Instance of 'GestureArenaEntry'}]
I/flutter ( 5750): Gesture arena 3    ❙ Rejecting: TapGestureRecognizer#3379a(debugOwner: GestureDetector, state: possible, button: 1, sent tap down)
I/flutter ( 5750): stopTrackingPointer pointer[3]_trackedPointers[{3}]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerCancelEvent#cb079(position: Offset(0.0, 0.0))][3]
I/flutter ( 5750): _giveUpPointer [0] [3]reject[true]_velocityTrackers[{1: Instance of 'VelocityTracker', 3: Instance of 'VelocityTracker'}]
I/flutter ( 5750): stopTrackingPointer pointer[3]_trackedPointers[{1, 3}]
I/flutter ( 5750): _giveUpPointer [1] [3]reject[true]_velocityTrackers[{1: Instance of 'VelocityTracker', 3: Instance of 'VelocityTracker'}]
I/flutter ( 5750): resolvePointer [3]disposition[GestureDisposition.rejected]_entries[{1: Instance of 'GestureArenaEntry', 3: Instance of 'GestureArenaEntry'}]
I/flutter ( 5750): Gesture arena 3    ❙ Rejecting: VerticalDragGestureRecognizer#aac43(start behavior: start)
I/flutter ( 5750): _giveUpPointer [0] [3]reject[true]_velocityTrackers[{1: Instance of 'VelocityTracker'}]
I/flutter ( 5750): stopTrackingPointer pointer[3]_trackedPointers[{1}]
I/flutter ( 5750): _giveUpPointer [1] [3]reject[true]_velocityTrackers[{1: Instance of 'VelocityTracker'}]
I/flutter ( 5750): Gesture arena 3    ❙ Arena empty.
I/flutter ( 5750): Gesture arena 1    ❙ Rejecting: TapGestureRecognizer#93267(debugOwner: GestureDetector, state: possible, button: 1, sent tap down)
I/flutter ( 5750): stopTrackingPointer pointer[1]_trackedPointers[{1}]
I/flutter ( 5750): handleEvent this[VerticalDragGestureRecognizer#aac43(start behavior: start)]_state[_DragState.accepted]event[_TransformedPointerCancelEvent#7e63e(position: Offset(0.0, 0.0))][1]
I/flutter ( 5750): _giveUpPointer [0] [1]reject[true]_velocityTrackers[{1: Instance of 'VelocityTracker'}]
I/flutter ( 5750): stopTrackingPointer pointer[1]_trackedPointers[{1}]
I/flutter ( 5750): _giveUpPointer [1] [1]reject[true]_velocityTrackers[{}]
I/flutter ( 5750): Gesture arena 1    ❙ Default winner: VerticalDragGestureRecognizer#aac43(start behavior: start)
I/flutter ( 5750): acceptGesture pointer[1][VerticalDragGestureRecognizer#aac43(start behavior: start)]state[_DragState.ready]
E/flutter ( 5750): [ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: Null check operator used on a null value
E/flutter ( 5750): #0      DragGestureRecognizer.acceptGesture (package:flutter/src/gestures/monodrag.dart:328:60)
E/flutter ( 5750): #1      GestureArenaManager._resolveByDefault (package:flutter/src/gestures/arena.dart:251:25)
E/flutter ( 5750): #2      GestureArenaManager._tryToResolveArena.<anonymous closure> (package:flutter/src/gestures/arena.dart:232:31)
E/flutter ( 5750): #3      _rootRun (dart:async/zone.dart:1182:47)
E/flutter ( 5750): #4      _CustomZone.run (dart:async/zone.dart:1093:19)
E/flutter ( 5750): #5      _CustomZone.runGuarded (dart:async/zone.dart:997:7)
E/flutter ( 5750): #6      _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1037:23)
E/flutter ( 5750): #7      _rootRun (dart:async/zone.dart:1190:13)
E/flutter ( 5750): #8      _CustomZone.run (dart:async/zone.dart:1093:19)
E/flutter ( 5750): #9      _CustomZone.runGuarded (dart:async/zone.dart:997:7)
E/flutter ( 5750): #10     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1037:23)
E/flutter ( 5750): #11     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
E/flutter ( 5750): #12     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
E/flutter ( 5750):

Related Issues

Fixes #68373

Tests

See files.

flutter-dashboard · 2020-10-20T09:50:47Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

dkwingsmt · 2020-10-20T11:31:03Z

Thank you so much for the investigation and the writeup! Can you come up with a unit test so that we don't accidentally regress it?

xu-baolin · 2020-10-20T11:46:40Z

Thank you so much for the investigation and the writeup! Can you come up with a unit test so that we don't accidentally regress it?

Coming soon.

xu-baolin · 2020-10-20T14:46:47Z

Thank you so much for the investigation and the writeup! Can you come up with a unit test so that we don't accidentally regress it?

Done.

dkwingsmt · 2020-10-20T21:04:33Z

packages/flutter/lib/src/gestures/recognizer.dart

  @mustCallSuper
  void resolvePointer(int pointer, GestureDisposition disposition) {
-    final GestureArenaEntry? entry = _entries[pointer];
+    final Map<int, GestureArenaEntry> localEntries = Map<int, GestureArenaEntry>.from(_entries);


Why is this clone needed?

entry. resolve() will trigger nested
calls to this function, so we should remove the entry first as following do.

The entry in the map is a reference type here, I think we can use it after removing it from the map without clone, I will double check:)

I have removed the unnecessary map clone.

dkwingsmt

LGTM except for one comment. Thank you for the PR!

xu-baolin · 2020-10-22T12:25:13Z

@dkwingsmt I think it is ready for landing now. : )

This reverts commit bde85ea.

yitong12580 · 2020-10-24T03:43:41Z

你好这边已经是最新版本 master 分支
但是还是会出现这个问题。
重现方式：
tabbarview 左右切换的时候双指同时多次点击屏幕

xu-baolin · 2020-10-24T05:06:27Z

你好这边已经是最新版本 master 分支
但是还是会出现这个问题。
重现方式：
tabbarview 左右切换的时候双指同时多次点击屏幕

抱歉这个修正昨天被回退了#68841 ，请确认你验证的版本，如果包含了这个修正还是有问题，请帮忙提供版本信息，和一个最小范围内可以直接运行的复现问题的用例，谢谢。我会尽快调查影响然后重新合入这个修正。

Sorry, this fix was revert yesterday #68841 . Please confirm the version you verified. If there is still a problem with the change, please provide the version information and a minimal sample code that can be run directly. Thank you. I'll look into the impact as soon as possible and then reland this PR.

xu-baolin · 2020-10-24T05:16:19Z

@dkwingsmt
I am so sorry for breaking something.
From this error log #68841 , it seems that it has nothing to do with our change, also waiting for your opinions. I have no right see all the logs. Can you help me downlload all the failed logs?

…#68841)" This reverts commit b25ce5b.

This relands #68587

Fix mutiple pointers bug

073eaaf

flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 20, 2020

google-cla bot added the cla: yes label Oct 20, 2020

Add unit test case

395bdb0

dkwingsmt reviewed Oct 20, 2020

View reviewed changes

dkwingsmt approved these changes Oct 20, 2020

View reviewed changes

Remove unnecessary map clone

6188b7e

dkwingsmt merged commit bde85ea into flutter:master Oct 22, 2020

jonahwilliams pushed a commit that referenced this pull request Oct 23, 2020

Revert "Fix a multiple pointers bug (#68587)"

7b84a0a

This reverts commit bde85ea.

jonahwilliams mentioned this pull request Oct 23, 2020

Revert "Fix a multiple pointers bug" #68841

Merged

jonahwilliams pushed a commit that referenced this pull request Oct 23, 2020

Revert "Fix a multiple pointers bug (#68587)" (#68841)

b25ce5b

This reverts commit bde85ea.

dkwingsmt added a commit to dkwingsmt/flutter that referenced this pull request Oct 29, 2020

Revert "Revert "Fix a multiple pointers bug (flutter#68587)" (flutter…

c9253fd

…#68841)" This reverts commit b25ce5b.

dkwingsmt mentioned this pull request Oct 29, 2020

Reland: Fix a multiple pointers bug #69328

Merged

13 tasks

dkwingsmt added a commit that referenced this pull request Nov 6, 2020

Reland: Fix a multiple pointers bug

e1712cc

This relands #68587

xu-baolin mentioned this pull request Nov 26, 2020

Gesture handling causing a null-unsafe operation #71092

Closed

Conversation

xu-baolin commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Why the issue happen?

Related PR

Log

Related Issues

Tests

Uh oh!

flutter-dashboard bot commented Oct 20, 2020

Uh oh!

dkwingsmt commented Oct 20, 2020

Uh oh!

xu-baolin commented Oct 20, 2020

Uh oh!

xu-baolin commented Oct 20, 2020

Uh oh!

dkwingsmt Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

xu-baolin Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

xu-baolin Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

xu-baolin Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xu-baolin commented Oct 22, 2020

Uh oh!

yitong12580 commented Oct 24, 2020

Uh oh!

xu-baolin commented Oct 24, 2020

Uh oh!

xu-baolin commented Oct 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xu-baolin commented Oct 20, 2020 •

edited

Loading

dkwingsmt left a comment •

edited

Loading