[flutter_tools] add --android-gradle-daemon option, use in devicelab #68409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Oct 19, 2020
|
|
||
| /// Whether to enable the Gradle daemon when performing an Android build. | ||
| /// | ||
| /// Starting the daemon is the default behavior of the gradle wrapper script created |
Member
There was a problem hiding this comment.
Should this go in the help text for the flag?
| } finally { | ||
| if (!runnerFinished) | ||
| runner.kill(ProcessSignal.sigkill); | ||
| await cleanupSystem(); |
Member
There was a problem hiding this comment.
Is there any way to check that the gradle daemon is not running?
Contributor
Author
There was a problem hiding this comment.
We could look for still running java processes in the before/after process check
Contributor
Author
|
iOS/macOS failures is the current SDK flake and is unrelated |
Contributor
|
This was relanded in #68491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove devicelab specific code for shutting down gradle daemon, add
--android-gradle-daemonoption to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone.Example:
flutter build apk --no-android-gradle-daemonwill pass--no-daemonon to gradle