Skip to content

Revert "[flutter_tools] add --android-gradle-daemon option, use in devicelab" #68489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Oct 19, 2020
Merged

Revert "[flutter_tools] add --android-gradle-daemon option, use in devicelab" #68489

jonahwilliams merged 1 commit into from
Oct 19, 2020

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Oct 19, 2020

Reverts #68409

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 19, 2020
@google-cla google-cla bot added the cla: yes label Oct 19, 2020
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Oct 19, 2020

TBR @zanderso

@jonahwilliams jonahwilliams merged commit ed5482d into master Oct 19, 2020
@jonahwilliams jonahwilliams deleted the revert-68409-no_gradle_daemon branch October 19, 2020 16:33
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Oct 19, 2020

build commands are weird, this needs to go after the subcommand because of how we handle the args

2020-10-19T09:31:37.643905: 
Executing: /home/flutter/.cocoon/flutter/bin/flutter build --no-android-gradle-daemon apk --profile -t test_driver/transitions_perf.dart --target-platform android-arm,android-arm64 in /home/flutter/.cocoon/flutter/dev/integration_tests/flutter_gallery with environment {}
2020-10-19T09:31:37.959425: stderr: Could not find an option named "android-gradle-daemon".
stderr: 
2020-10-19T09:31:37.959536: stderr: Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.
2020-10-19T09:31:37.978411: "/home/flutter/.cocoon/flutter/bin/flutter" exit code: 64
2020-10-19T09:31:37.984431: Task failed: Executable "/home/flutter/.cocoon/flutter/bin/flutter" failed with exit code 64.2020-10-19T09:31:37.984590:

zanderso
zanderso reviewed Oct 19, 2020
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@whesse
Copy link
Contributor

whesse commented Oct 25, 2023

This revert was relanded in #68491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso left review comments

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @whesse @zanderso