Skip to content

Revert "Re-land ScaffoldMessenger"#65482

Merged
HansMuller merged 1 commit intomasterfrom
revert-65416-scaffold_messenger
Sep 10, 2020
Merged

Revert "Re-land ScaffoldMessenger"#65482
HansMuller merged 1 commit intomasterfrom
revert-65416-scaffold_messenger

Conversation

@HansMuller
Copy link
Copy Markdown
Contributor

@HansMuller HansMuller commented Sep 9, 2020

Reverts #65416

Some internal golden image tests failed. Most of the failures featured an unexpected snackbar-sized gap at the bottom of the screen. Not clear what's causing that, reverting this PR for now.

Internal issue: b/168072890

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 9, 2020
Copy link
Copy Markdown
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@HansMuller HansMuller merged commit 13860a7 into master Sep 10, 2020
@HansMuller HansMuller deleted the revert-65416-scaffold_messenger branch September 10, 2020 20:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants