Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

Reverts #64308

FYI @dnfield

Broken framework tests:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8870051401946575216/+/steps/run_test.dart_for_framework_tests_shard_and_subshard_misc/0/stdout

00:12 +11 -1: C:\b\s\w\ir\k\flutter\packages\flutter_driver\test\src\real_tests\find_test.dart: Ancestor finder deserialize [E]                                                                        
  NoSuchMethodError: The method 'deserializeFinder' was called on null.
  Receiver: null
  Tried calling: deserializeFinder(_LinkedHashMap len:2)
  dart:core                                           Object.noSuchMethod
  package:flutter_driver/src/common/find.dart 416:25  Ancestor.deserialize
  test\src\real_tests\find_test.dart 42:33            main.<fn>
  

00:12 +12 -1: loading C:\b\s\w\ir\k\flutter\packages\flutter_driver\test\src\real_tests\io_extension_test.dart                                                                                         
00:12 +12 -1: C:\b\s\w\ir\k\flutter\packages\flutter_driver\test\src\real_tests\find_test.dart: Descendant finder serialize                                                                            
00:12 +13 -1: C:\b\s\w\ir\k\flutter\packages\flutter_driver\test\src\real_tests\extension_test.dart: ... waiting for NoPendingPlatformMessages returns until a single method channel call returns      
00:12 +14 -2: loading C:\b\s\w\ir\k\flutter\packages\flutter_driver\test\src\real_tests\io_extension_test.dart                                                                                         
00:12 +14 -2: C:\b\s\w\ir\k\flutter\packages\flutter_driver\test\src\real_tests\extension_test.dart: ... waiting for NoPendingPlatformMessages returns until both method channel calls return          
00:12 +14 -2: C:\b\s\w\ir\k\flutter\packages\flutter_driver\test\src\real_tests\find_test.dart: Descendant finder deserialize [E]                                                                      
  NoSuchMethodError: The method 'deserializeFinder' was called on null.
  Receiver: null
  Tried calling: deserializeFinder(_LinkedHashMap len:2)
  dart:core                                           Object.noSuchMethod
  package:flutter_driver/src/common/find.dart 361:25  Descendant.deserialize
  test\src\real_tests\find_test.dart 77:37            main.<fn>
  

00:12 +15 -2: loading C:\b\s\w\ir\k\flutter\packages\flutter_driver\test\src\real_tests\io_extension_test.dart    

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Sep 5, 2020
@jonahwilliams
Copy link
Contributor Author

landing on red to fix build

@jonahwilliams jonahwilliams merged commit 14af5bb into master Sep 5, 2020
@jonahwilliams jonahwilliams deleted the revert-64308-master branch September 5, 2020 00:01
@dnfield
Copy link
Contributor

dnfield commented Sep 5, 2020

LGTM

/Cc @Im-Kevin

@Im-Kevin
Copy link
Contributor

Im-Kevin commented Sep 5, 2020

already fixed #65276

@Im-Kevin
Copy link
Contributor

Im-Kevin commented Sep 5, 2020

@dnfield

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants