Skip to content

Add finders for enableFlutterDriverExtension #64308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 20 commits into from
Sep 4, 2020
Merged

Add finders for enableFlutterDriverExtension #64308

fluttergithubbot merged 20 commits into from
Sep 4, 2020

Conversation

@Im-Kevin
Copy link
Contributor

@Im-Kevin Im-Kevin commented Aug 21, 2020 •
edited
Loading

Description

Add Custom Finder Support

Related Issues

#62299

Tests

I modified the following test:

  • extension_test.dart
    • waitUntilNoTransientCallbacks
    • waitForCondition
    • getSemanticsId
    • getOffset
    • getText
    • descendant finder
    • descendant finder firstMatchOnly
    • ancestor finder
    • ancestor finder firstMatchOnly
    • GetDiagnosticsTree
    • waitUntilFrameSync
  • find_test.dart
    • Ancestor finder deserialize
    • Descendant finder deserialize

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Aug 21, 2020
@googlebot
Copy link

googlebot commented Aug 21, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Im-Kevin
Copy link
Contributor Author

Im-Kevin commented Aug 21, 2020

@googlebot I signed it!

@googlebot
Copy link

googlebot commented Aug 21, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@goderbauer
Copy link
Member

goderbauer commented Aug 21, 2020

/cc @dnfield

dnfield
dnfield suggested changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I might be missing something here - a few nits, and some of the documentation needs more work.

Biggest question is about whether we can avoid just passing callbacks around so much, particularly ones that are just using Maps of stringly typed data.

@Im-Kevin
Copy link
Contributor Author

Im-Kevin commented Aug 29, 2020

@dnfield See how it is now

@Im-Kevin Im-Kevin requested a review from dnfield August 29, 2020 08:22
dnfield
dnfield reviewed Aug 29, 2020
View reviewed changes
dnfield
dnfield reviewed Aug 29, 2020
View reviewed changes
dnfield
dnfield reviewed Aug 29, 2020
View reviewed changes
dnfield
dnfield reviewed Aug 29, 2020
View reviewed changes
dnfield
dnfield reviewed Aug 29, 2020
View reviewed changes
dnfield
dnfield reviewed Aug 29, 2020
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is getting closer!

Im-Kevin and others added 4 commits August 30, 2020 09:47
@Im-Kevin @dnfield
Update packages/flutter_driver/lib/src/extension/extension.dart
d19b906 
Fix Code Style Error

Co-authored-by: Dan Field <dfield@gmail.com>
@Im-Kevin @dnfield
Update packages/flutter_driver/test/src/real_tests/find_test.dart
dde689e 
Fix Code Style Error

Co-authored-by: Dan Field <dfield@gmail.com>
@Im-Kevin @dnfield
Update packages/flutter_driver/lib/src/extension/extension.dart
1521b30 
Fix Code Style Error

Co-authored-by: Dan Field <dfield@gmail.com>
@Im-Kevin
Modified find_test.dart
34f6278 
Modified [enableFlutterDriverExtension] Code Note
@marcin-jelenski
Copy link
Contributor

marcin-jelenski commented Aug 31, 2020

Fingers crossed @Im-Kevin.
Relates to the issue #62299.

dnfield
dnfield suggested changes Aug 31, 2020
View reviewed changes
Im-Kevin and others added 2 commits September 1, 2020 11:16
@Im-Kevin @dnfield
Update packages/flutter_driver/lib/src/common/find.dart
d829f8b 
Co-authored-by: Dan Field <dfield@gmail.com>
@Im-Kevin @dnfield
Update packages/flutter_driver/lib/src/extension/extension.dart
bae44ef 
Co-authored-by: Dan Field <dfield@gmail.com>
@Im-Kevin Im-Kevin requested a review from dnfield September 1, 2020 03:34
@Im-Kevin
Copy link
Contributor Author

Im-Kevin commented Sep 1, 2020

image

@Im-Kevin
Copy link
Contributor Author

Im-Kevin commented Sep 3, 2020

@dnfield

dnfield
dnfield reviewed Sep 3, 2020
View reviewed changes
dnfield
dnfield reviewed Sep 3, 2020
View reviewed changes
@Im-Kevin
Copy link
Contributor Author

Im-Kevin commented Sep 3, 2020

@dnfield See how it is now

dnfield
dnfield reviewed Sep 3, 2020
View reviewed changes
@dnfield
Copy link
Contributor

dnfield commented Sep 3, 2020

Tests are failing.

@Im-Kevin
Copy link
Contributor Author

Im-Kevin commented Sep 4, 2020

@dnfield See how it is now

dnfield
dnfield approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit db4dda2 into flutter:master Sep 4, 2020
jonahwilliams pushed a commit that referenced this pull request Sep 5, 2020
Revert "Add finders for enableFlutterDriverExtension (#64308)"
bd0f1d4 
This reverts commit db4dda2.
@jonahwilliams jonahwilliams mentioned this pull request Sep 5, 2020
Merged
jonahwilliams pushed a commit that referenced this pull request Sep 5, 2020
Revert "Add finders for enableFlutterDriverExtension (#64308)" (#65273)
14af5bb 
This reverts commit db4dda2.
@Im-Kevin Im-Kevin mentioned this pull request Sep 5, 2020
Merged
9 tasks
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@Im-Kevin @mingwandroid
Add finders for enableFlutterDriverExtension (flutter#64308)
b1a31de
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@mingwandroid
Revert "Add finders for enableFlutterDriverExtension (flutter#64308)" (…
0b01e38 
…flutter#65273)

This reverts commit db4dda2.
@dnfield dnfield mentioned this pull request Sep 9, 2020
Merged
@marcin-jelenski marcin-jelenski mentioned this pull request Oct 6, 2020
Merged
9 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Im-Kevin @googlebot @goderbauer @marcin-jelenski @dnfield @fluttergithubbot