Skip to content

Allow modification of ListTile's horizontalTitleGap, minVerticalPadding, minLeadingWidth #64222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darrenaustin merged 18 commits into from
Nov 6, 2020
Merged

Allow modification of ListTile's horizontalTitleGap, minVerticalPadding, minLeadingWidth #64222

darrenaustin merged 18 commits into from
Nov 6, 2020

Conversation

@Playhi
Copy link
Contributor

@Playhi Playhi commented Aug 20, 2020 •
edited by Piinks
Loading

Description

Allow the modification of ListTile's default horizontalTitleGap, minVerticalPadding, minLeadingWidth.

Related Issues

Tests

I added the following tests:

  • Added test ListTile horizontalTitleGap = 0.0
  • Added test ListTile horizontalTitleGap = (default)
  • Added test ListTile minVerticalPadding = 80.0
  • Added test ListTile minLeadingWidth = (default)
  • Added test ListTile minLeadingWidth = 60.0

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

Playhi added 3 commits August 19, 2020 12:31
@Playhi
Allow modification of ListTile's horizontalTitleGap, minVerticalPaddi…
9d475d4 
…ng, minLeadingWidth

Allow modification of ListTile's horizontalTitleGap, minVerticalPadding, minLeadingWidth.
@Playhi
Some fixes
b28e44f
@Playhi
Add test
76f7689
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 20, 2020
@Playhi Playhi mentioned this pull request Aug 20, 2020
Closed
10 tasks
@xilibro
Copy link

xilibro commented Sep 15, 2020

More than half a year has passed... #47647

@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 5, 2020

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

darrenaustin
darrenaustin suggested changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Playhi thanks so much for the contribution. My apologies on not getting to this sooner. It looks good. I just have a quibble with the introduction of a new defaults class interface, but otherwise it looks great.

@Playhi Playhi requested a review from darrenaustin November 3, 2020 15:06
darrenaustin
darrenaustin approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution.

@darrenaustin
Copy link
Contributor

darrenaustin commented Nov 4, 2020

@Playhi, unfortunately there was a recent change to some community tests dealing with package versioning. This is throwing off the tests for this PR. Can you merge with the latest from master and push to this PR?

The easiest way to do this is something like:

git pull --rebase upstream master
git push --force origin list_tile_more_customizable

Hopefully that will clear up the tests and we can land this change.

@darrenaustin
Copy link
Contributor

darrenaustin commented Nov 5, 2020

@Playhi thanks for the update, but it looks like there is a still a merge conflict with what is on master. Perhaps someone else checked in something conflicting since your update? Can you merge one more time?

Playhi and others added 2 commits November 6, 2020 09:06
@Playhi
Sync flutter/flutter/master to Playhi/flutter/master
5e3f7c7 
Sync flutter/flutter/master to Playhi/flutter/master
@Playhi
Merge branch 'master' into list_tile_more_customizable
ff08100 
# Conflicts:
#	packages/flutter/lib/src/material/list_tile.dart
#	packages/flutter/test/material/list_tile_test.dart
@darrenaustin darrenaustin merged commit 8cb2665 into flutter:master Nov 6, 2020
@HansMuller HansMuller mentioned this pull request Nov 6, 2020
Merged
@darrenaustin darrenaustin mentioned this pull request Nov 10, 2020
Merged
9 tasks
darrenaustin added a commit that referenced this pull request Nov 10, 2020
@darrenaustin
Fix for the ListTile horizontalTitleGap calculation introduced with PR …
fb63371 
…#64222. (#70149)
This was referenced Jun 3, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow modification of ListTile's horizontalTitleGap

4 participants

@Playhi @xilibro @darrenaustin @googlebot