Fix for the ListTile horizontalTitleGap calculation introduced with PR #64222. #70149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
There was a subtle bug introduced with #64222 that is addressed by the PR. The original
_horizontalTitleGapgetter on the_RenderListTilerecalculated the gap based on the visual density every time it was accessed. With the changes in #64222, this is now a property and the calculation only took place on construction. On an update the value was not recalculated but used as is. This caused some internal layout tests to fail. Apologies for not catching this in the review.Tests
I added a new test that exercises the gap with visual density calculations across multiple frames so that the update mechanism is triggered.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them?