Skip to content

Conversation

@darrenaustin
Copy link
Contributor

Description

There was a subtle bug introduced with #64222 that is addressed by the PR. The original _horizontalTitleGap getter on the _RenderListTile recalculated the gap based on the visual density every time it was accessed. With the changes in #64222, this is now a property and the calculation only took place on construction. On an update the value was not recalculated but used as is. This caused some internal layout tests to fail. Apologies for not catching this in the review.

Tests

I added a new test that exercises the gap with visual density calculations across multiple frames so that the update mechanism is triggered.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them?

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 10, 2020
@google-cla google-cla bot added the cla: yes label Nov 10, 2020
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@darrenaustin darrenaustin merged commit fb63371 into flutter:master Nov 10, 2020
@darrenaustin darrenaustin deleted the list_tile_fix branch November 10, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants