Skip to content

Clean up PollingDeviceDiscovery dispose#59709

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:dispose-polling
Jun 18, 2020
Merged

Clean up PollingDeviceDiscovery dispose#59709
fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:dispose-polling

Conversation

@jmagman

@jmagman jmagman commented Jun 17, 2020

Copy link
Copy Markdown
Member

Description

Follow up to @tvolkert comments in #58137.

Make PollingDeviceDiscovery dispose and daemon shutdown methods async.

Tests

Add test to check dispose cancels polling subscription.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 17, 2020
@jmagman jmagman self-assigned this Jun 17, 2020
@jmagman

jmagman commented Jun 17, 2020

Copy link
Copy Markdown
Member Author

Note I'm not particularly concerned about this for the cherry-pick at #59695. This shutdown path is called when the daemon process is about to get killed, and the daemon docs say "It is not necessary to call this before shutting down the daemon; it is perfectly acceptable to just kill the daemon process."

@jmagman jmagman mentioned this pull request Jun 17, 2020
Merged
jonahwilliams
jonahwilliams approved these changes Jun 18, 2020
View reviewed changes

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit f41f795 into flutter:master Jun 18, 2020
zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
@jmagman @zljj0818
Clean up PollingDeviceDiscovery dispose (flutter#59709)
29235d8
@jmagman jmagman deleted the dispose-polling branch June 24, 2020 19:34
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Clean up PollingDeviceDiscovery dispose (flutter#59709)
a2f0785
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@jonahwilliams jonahwilliams jonahwilliams approved these changes
@tvolkert tvolkert tvolkert approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jmagman @jonahwilliams @tvolkert @googlebot @fluttergithubbot