Change iOS device discovery from polling to long-running observation#59695
Conversation
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.17-candidate.3. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly. In order to pass this check, please resolve this problem and then comment ℹ️ Googlers: Go here for more info. |
|
@jonahwilliams Can I get a LGTM on the merge? There were a few trivial conflicts around the |
|
@googlebot I fixed it. |
|
@googlebot come on bro |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
LGTM for submitting to the branch, docs-linux looks like it is gonna time out |
|
@tvolkert just added change requests on the original PR. Following up on master at #59709. However I don't think that change is critical for this cherry pick. The dispose/shutdown path is called when the daemon process is about to get killed, and the daemon docs say "It is not necessary to call this before shutting down the daemon; it is perfectly acceptable to just kill the daemon process." |
Description
#58137 cherry-pick on 1.17-candidate.3