Skip to content

Change iOS device discovery from polling to long-running observation#59695

Merged
jmagman merged 1 commit into
flutter:flutter-1.17-candidate.3from
jmagman:polling-cp
Jun 17, 2020
Merged

Change iOS device discovery from polling to long-running observation#59695
jmagman merged 1 commit into
flutter:flutter-1.17-candidate.3from
jmagman:polling-cp

Conversation

@jmagman

@jmagman jmagman commented Jun 17, 2020

Copy link
Copy Markdown
Member

Description

#58137 cherry-pick on 1.17-candidate.3

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.17-candidate.3. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@fluttergithubbot fluttergithubbot changed the base branch from flutter-1.17-candidate.3 to master June 17, 2020 18:26
@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 17, 2020
@jmagman jmagman removed a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) cla: no d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 17, 2020
@jmagman jmagman marked this pull request as draft June 17, 2020 18:27
@jmagman jmagman changed the base branch from master to flutter-1.17-candidate.3 June 17, 2020 18:28
@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Jun 17, 2020
@jmagman jmagman requested a review from jonahwilliams June 17, 2020 18:36
@jmagman

jmagman commented Jun 17, 2020

Copy link
Copy Markdown
Member Author

@jonahwilliams Can I get a LGTM on the merge? There were a few trivial conflicts around the _items->deviceNotifier rename, and less trivial ones in the tests, which I'm not worried about.

@jmagman

jmagman commented Jun 17, 2020

Copy link
Copy Markdown
Member Author

@googlebot I fixed it.

@jmagman

jmagman commented Jun 17, 2020

Copy link
Copy Markdown
Member Author

@googlebot come on bro

@jmagman jmagman marked this pull request as ready for review June 17, 2020 19:01

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@pcsosinski

Copy link
Copy Markdown

LGTM for submitting to the branch, docs-linux looks like it is gonna time out

@jmagman

jmagman commented Jun 17, 2020

Copy link
Copy Markdown
Member Author

@tvolkert just added change requests on the original PR. Following up on master at #59709.

However I don't think that change is critical for this cherry pick. The dispose/shutdown path is called when the daemon process is about to get killed, and the daemon docs say "It is not necessary to call this before shutting down the daemon; it is perfectly acceptable to just kill the daemon process."

@jmagman jmagman merged commit 1ad9baa into flutter:flutter-1.17-candidate.3 Jun 17, 2020
@jmagman jmagman deleted the polling-cp branch June 17, 2020 21:41
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants