Revert " Bring back paste button hide behavior 3" #57286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8de07d5.
justinmc
approved these changes
May 15, 2020
Contributor
There was a problem hiding this comment.
LGTM 👍
That makes sense on web. This PR is used to hide/show the paste button in the text selection menu, which isn't necessary on the web because the web uses the native text selection menu.
I think if I just always set the clipboard status to pasteable on web without checking the clipboard, then this should work on web and shouldn't ever ask the user for permission.
Contributor
Contributor
Author
Contributor
Author
|
Merging the PR since it's related to broken tests, on the engine side. |
justinmc
added a commit
to justinmc/flutter
that referenced
this pull request
May 15, 2020
…)" (flutter#57286)" This reverts commit 32547dc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #57139
This causes Flutter for Web to fail for all pages which have an Editable Text.
We caught it in our integration tests: https://ci.chromium.org/p/flutter/builders/try/Linux%20Web%20Engine/4099?
These tests only run on the engine side so we were able to catch it only now.
Overall getData means paste, reading the clipboard on web, which requires permission and should only be done with user permission. Calling getData will bring a browser popup window and will ask user for permission. It is not the best practice to ask user for their clipboard's access without an explicit event that might trigger it. Let's discuss a solution that will also work for web before remerging this PR.