Fix Web asking for clipboard permissions #57324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@nturgut Is it possible to run those failing web tests locally to make sure that this fixes it? |
Contributor
|
We also have this control for the toolbar: Is it related? For a text field on the web, we don't render a copy/paste menu, we use the one that browser shows. |
Contributor
Author
|
Yeah, these changes in EditableText are still needed in addition to that check because EditableText uses the clipboard status to decide to allow pasting via semantics/accessibility. |
nturgut
approved these changes
May 15, 2020
…)" (flutter#57286)" This reverts commit 32547dc.
7ff5606 to
6a4c68a
Compare
Contributor
Author
Contributor
|
One option (for local development) is using felt tool. You can run: |
Contributor
|
Flutter Web integration tests are passing, I run them on my local against this PR. |
Contributor
Author
|
Confirmed that those tests pass locally now ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#57139 checked the clipboard to see if it could show the paste button, but this broke web because it has to ask for the user's permission to use the clipboard (see #57139 (comment)). Web doesn't draw its own text selection menu though, so it doesn't need to check the clipboard, and this PR removes that functionality for web.
Related Issues
#57286
Tests
I added the following tests: