[flutter_tools] fix type error in symbolize #55212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Apr 20, 2020
| } | ||
| ); | ||
| } | ||
| final DwarfSymbolizationService symbolizationService = DwarfSymbolizationService( |
Member
There was a problem hiding this comment.
Maybe a DwarfSymbolizationService.test() with this transformer?
Contributor
Author
|
The tests don't seem to be running |
Contributor
Author
|
fyi @fkorotkov |
zanderso
approved these changes
Apr 20, 2020
| }) : _transformer = symbolsTransformer; | ||
|
|
||
| /// Create a DwarfSymbolizationService with a no-op transformer for testing. | ||
| factory DwarfSymbolizationService.test() { |
Member
There was a problem hiding this comment.
Can this be @visibleForTesting?
Contributor
|
@jonahwilliams it's the same issue as yesterday (here is a list of all the suites). I'm about to deploy a tweak to try to workaround it. I've also reached out to GitHub folks about it. |
pcsosinski
pushed a commit
to pcsosinski/flutter
that referenced
this pull request
Apr 28, 2020
pcsosinski
pushed a commit
that referenced
this pull request
Apr 28, 2020
* [flutter_tools] fix type error in symbolize (#55212) * [flutter_tools] check first for stable tag, then dev tag (#55342) * [flutter_tools] enable `flutter upgrade` to support force pushed branches (#55594) * [flutter_tools] catch ProcessException and throw ToolExit during upgrade (#55759) * Update engine version to 376ad6a64b08aa26005e3f82aed26de2e290b572 Co-authored-by: Jonah Williams <campfish91@gmail.com> Co-authored-by: Christopher Fujino <fujino@google.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Symbolize had a type error, probably introduced some time after I stopped manually testing and started doing some refactoring on the code. Something, Something contravariance instead of covariance
Fixes #55214