Skip to content

Flutter 1.17.0.dev.3.3 cherrypicks #55871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcsosinski merged 5 commits into from
Apr 28, 2020
Merged

Flutter 1.17.0.dev.3.3 cherrypicks #55871

pcsosinski merged 5 commits into from
Apr 28, 2020

Conversation

@pcsosinski
Copy link

@pcsosinski pcsosinski commented Apr 28, 2020

@pcsosinski pcsosinski marked this pull request as ready for review April 28, 2020 16:56
@fluttergithubbot fluttergithubbot changed the base branch from flutter-1.17-candidate.3 to master April 28, 2020 16:56
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 28, 2020

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.17-candidate.3. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

@fluttergithubbot fluttergithubbot added engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 28, 2020
@pcsosinski pcsosinski changed the base branch from master to flutter-1.17-candidate.3 April 28, 2020 16:57
christopherfujino
christopherfujino approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My changes LGTM

jonahwilliams
jonahwilliams approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcsosinski pcsosinski merged commit 0da1ab0 into flutter:flutter-1.17-candidate.3 Apr 28, 2020
@pcsosinski pcsosinski deleted the flutter-1.17-candidate.3 branch April 28, 2020 19:17
@christopherfujino christopherfujino mentioned this pull request Apr 28, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pcsosinski @fluttergithubbot @christopherfujino @jonahwilliams @googlebot