Skip to content

update flutter run --devfs #4942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devoncarew merged 3 commits into from
Jul 18, 2016
Merged

update flutter run --devfs #4942

devoncarew merged 3 commits into from
Jul 18, 2016

Conversation

@devoncarew
Copy link
Contributor

@devoncarew devoncarew commented Jul 18, 2016

  • update flutter run --devfs to handle changes to the _createDevFS observatory call
  • add logic and timeouts to flutter run to better handle when the observatory becomes unresponsive to calls (w/o the service protocol connection itself closing)

@yjbanov

yjbanov
yjbanov reviewed Jul 18, 2016
View reviewed changes
packages/flutter_tools/lib/src/observatory.dart Outdated
Future<CreateDevFSResponse> createDevFS(String fsName) {
return sendRequest(
'_createDevFS', <String, dynamic> { 'fsName': fsName }
).then((Response response) => new CreateDevFSResponse(response.response));
Copy link
Contributor

@yjbanov yjbanov Jul 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good place to take advantage of async/await

Copy link
Contributor Author

@devoncarew devoncarew Jul 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@yjbanov
Copy link
Contributor

yjbanov commented Jul 18, 2016

I'm afraid of leaking timed out HTTP requests. What level of robustness are we shooting for? LGTM otherwise.

@devoncarew devoncarew merged commit d0f43ed into flutter:master Jul 18, 2016
cbracken added a commit to cbracken/flutter that referenced this pull request Apr 5, 2018
@cbracken
Roll engine to aa9ce70
a687fb4 
Includes:
* Add armv7 support to create_ios_framework script (flutter#4942)
* Roll Dart to version 09e1766e6caa537e1271fbce04ebcbf8212b6569 (flutter#4941)
@cbracken cbracken mentioned this pull request Apr 5, 2018
Merged
cbracken added a commit that referenced this pull request Apr 6, 2018
@cbracken
Roll engine to aa9ce70 (#16289)
2134adc 
Includes:
* Add armv7 support to create_ios_framework script (#4942)
* Roll Dart to version 09e1766e6caa537e1271fbce04ebcbf8212b6569 (#4941)
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@cbracken
Roll engine to aa9ce70 (flutter#16289)
6835956 
Includes:
* Add armv7 support to create_ios_framework script (flutter#4942)
* Roll Dart to version 09e1766e6caa537e1271fbce04ebcbf8212b6569 (flutter#4941)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devoncarew @yjbanov