Skip to content

Switch to the Win32 Windows embedding #39836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stuartmorgan-g merged 1 commit into from
Sep 5, 2019
Merged

Switch to the Win32 Windows embedding #39836

stuartmorgan-g merged 1 commit into from
Sep 5, 2019

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Sep 4, 2019

Description

Pulls the Win32 embedding artifacts instead of the GLFW versions for
Windows.

Related Issues

Fixes #38590

Tests

I added the following tests: Updated existing tests

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

This is a breaking change for Windows, but Windows is explicitly not stable at this point.

@stuartmorgan-g
Switch to the Win32 Windows embedding
24dcd58 
Pulls the Win32 embedding artifacts instead of the GLFW versions for
Windows.
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 4, 2019
@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Sep 4, 2019

The FDE side still needs a bit of work, but I'd like to have this ready to go when it's done.

@stuartmorgan-g stuartmorgan-g added a: desktop Running on desktop platform-windows Building on or for Windows specifically labels Sep 4, 2019
@codecov
Copy link

codecov bot commented Sep 4, 2019 •
edited
Loading

Codecov Report

Merging #39836 into master will decrease coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39836      +/-   ##
==========================================
- Coverage   57.33%   56.79%   -0.54%     
==========================================
  Files         194      194              
  Lines       18691    18691              
==========================================
- Hits        10716    10616     -100     
- Misses       7975     8075     +100
Flag Coverage Δ
#flutter_tool 56.79% <ø> (-0.54%) ⬇️
Impacted Files Coverage Δ
...er_tools/lib/src/build_system/targets/windows.dart 93.75% <ø> (ø) ⬆️
packages/flutter_tools/lib/src/cache.dart 43.5% <ø> (-0.73%) ⬇️
...ackages/flutter_tools/lib/src/commands/unpack.dart 4.95% <ø> (ø) ⬆️
...ages/flutter_tools/lib/src/commands/build_apk.dart 27.65% <0%> (-72.35%) ⬇️
...ackages/flutter_tools/lib/src/commands/daemon.dart 0.23% <0%> (-33.96%) ⬇️
packages/flutter_tools/lib/src/base/utils.dart 87.12% <0%> (-7.43%) ⬇️
...flutter_tools/lib/src/android/android_builder.dart 9.37% <0%> (-3.13%) ⬇️
packages/flutter_tools/lib/src/device.dart 55.88% <0%> (-2.36%) ⬇️
packages/flutter_tools/lib/src/version.dart 90.9% <0%> (-1.92%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9f210...24dcd58. Read the comment docs.

@clarkezone clarkezone mentioned this pull request Sep 4, 2019
Merged
jonahwilliams
jonahwilliams approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g merged commit 4c2c7c4 into flutter:master Sep 5, 2019
@stuartmorgan-g stuartmorgan-g deleted the win32-switch branch September 5, 2019 17:09
stuartmorgan-g pushed a commit to google/flutter-desktop-embedding that referenced this pull request Sep 5, 2019
@clarkezone @stuartmorgan-g
[Windows] Update example and testbed to use the native win32 Windows …
1306acd 
…engine (#493)

Updates Windows example and testbed for flutter/flutter#39836

Also switches the projects to Unicode, since the new code uses more Win32 APIs, and
we want to be using the modern versions of those APIs.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop platform-windows Building on or for Windows specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch windows embedding to Win32 version

4 participants

@stuartmorgan-g @jonahwilliams @googlebot @fluttergithubbot