[Windows] Update example and testbed to use the native win32 Windows engine #493
Conversation
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Started doing a review before belatedly realizing that this wasn't posted for review yet. Publishing them in case any of it is useful, but otherwise feel free to ignore and I'll review when it's actually ready.
| #include "win32_window.h" | ||
| #include "shellscalingapi.h" | ||
|
|
||
| // the Windows DPI system is based on this |
There was a problem hiding this comment.
Anonymous namespace for this and the helper to give them internal linkage.
example/windows/win32_window.h
Outdated
| const unsigned int x, | ||
| const unsigned int y, | ||
| const unsigned int width, | ||
| const unsigned int height); |
There was a problem hiding this comment.
Same question here about whether there are better types we could use.
There was a problem hiding this comment.
For now I'm going to add a Point and Size to this class to make things a bit more self-documenting. Not an ideal solution, but we can easily iterate later.
|
Synced with master, fixed all the references to |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Addressed the remaining cleanup; this is good to land when the Flutter side lands!
This change is WIP for the consumption of the following engine PR:
flutter/engine#11327
This PR shouldn't be accepted until native win32 is the default Windows embedder: flutter/flutter#39836