Skip to content

fix sliver fixed pinned appbar #36333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 4 commits into from
Jul 18, 2019
Merged

fix sliver fixed pinned appbar #36333

dnfield merged 4 commits into from
Jul 18, 2019

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 17, 2019 •
edited
Loading

Description

Fixes a bug introduced in #35574 by splitting the semantics logic from the overlap shadow logic.

Fixes #35488 again

Tests

I added the following tests:

New test to cover that a sliver app bar that is fixed and pinned does not cast a shadow when it is not overlapping content.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@dnfield dnfield requested a review from gspencergoog July 17, 2019 04:16
@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 17, 2019
@dnfield dnfield requested a review from goderbauer July 17, 2019 16:25
Piinks
Piinks approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/flutter/test/widgets/slivers_appbar_floating_pinned_test.dart Outdated
import 'package:flutter_test/flutter_test.dart';
import 'package:flutter/material.dart';


Copy link
Contributor

@Piinks Piinks Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Extra blank line

@dnfield dnfield merged commit b7a49c4 into flutter:master Jul 18, 2019
@dnfield dnfield deleted the sliver_fixed branch July 18, 2019 17:37
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@dnfield @johnsonmh
fix sliver fixed pinned appbar (flutter#36333)
cff6b6c
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Piinks Piinks Piinks approved these changes

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

implicit a11y scrolling broken with pinned & floating AppBar

4 participants

@dnfield @Piinks @googlebot @fluttergithubbot