Fix semantics for floating pinned sliver app bar #35574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
approved these changes
Jul 8, 2019
Member
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
Thanks for tracking this down!
packages/flutter/test/widgets/slivers_appbar_floating_pinned_test.dart
Outdated
Show resolved
Hide resolved
…est.dart Co-Authored-By: Michael Goderbauer <goderbauer@google.com>
Contributor
Author
|
I'm going to merge this - this has 0 impact on the tool tests, which are taking a long time to schedule right now for some reason on mac. |
This was referenced Jul 16, 2019
dnfield
added a commit
that referenced
this pull request
Jul 17, 2019
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
…)" (flutter#36319) This reverts commit 39baa09.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SliverAppBars that are floating and pinned without a bottom aren't doing semantics traversal correctly. This is because when there is no bottom, the effective scroll offset can be equal to the constraints.scrollOffset when overlapping children.
The bug was introduced by #11996, which first allowed such app bars to not have a bottom.
Related Issues
Fixes #35488
Tests
I added the following tests:
Test to check the semantics tree is good after scrolling such a sliver app bar.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?