Skip to content

Revert "Fix semantics for floating pinned sliver app bar" #36319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 1 commit into from
Jul 17, 2019
Merged

Revert "Fix semantics for floating pinned sliver app bar" #36319

dnfield merged 1 commit into from
Jul 17, 2019

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 16, 2019

Reverts #35574

This broke some internal tests. Need to figure out why.

@dnfield dnfield requested a review from gspencergoog July 16, 2019 23:52
@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 16, 2019
gspencergoog
gspencergoog approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dnfield dnfield merged commit 5923f34 into master Jul 17, 2019
@dnfield dnfield deleted the revert-35574-fix_scrolling_app_bar_semantics branch July 17, 2019 16:24
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@dnfield @johnsonmh
Revert "Fix semantics for floating pinned sliver app bar (flutter#35574…
4fb7c24 
…)" (flutter#36319)

This reverts commit 39baa09.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnfield @gspencergoog @googlebot @fluttergithubbot