Skip to content

Conversation

@flar
Copy link
Contributor

@flar flar commented Jun 18, 2019

See: #21826

@flar flar requested a review from liyuqian June 18, 2019 19:43
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@GaryQian GaryQian Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: defaults to sounds slightly better? Not sure what the grammar overlords will say, but it sounds better to me. Up to you if you want to change it or not.

@flar flar requested a review from GaryQian June 19, 2019 00:39
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@goderbauer goderbauer added the framework flutter/packages/flutter repository. See also f: labels. label Jun 19, 2019
@flar flar merged commit e6f896e into flutter:master Jun 19, 2019
@flar flar deleted the bug21826_docfix branch July 11, 2019 01:11
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants