Missing default hardEdge clip for ClipRectLayer #21826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my local tests, this should finally fix flutter#21617
GaryQian
approved these changes
Sep 13, 2018
Contributor
GaryQian
left a comment
There was a problem hiding this comment.
Need to fix tests, but otherwise LGTM
liyuqian
added a commit
to flutter/goldens
that referenced
this pull request
Sep 13, 2018
Contributor
|
It looks like the default value for the field in the docs was missed on this change. It still says the default is AA. |
Contributor
Author
|
Feel encouraged to write a PR to fix the doc @flar 😄 |
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
(and fix grammar) See: flutter#21826
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my local tests, this should finally fix #21617