Skip to content

Conversation

@goderbauer
Copy link
Member

Description

Provides access to the raw (unadjusted) time stamp that was passed from the engine to the framework.

Related Issues

#33216

Tests

I added the following tests:

  • currentSystemFrameTimeStamp is the raw timestamp

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@goderbauer goderbauer requested a review from Hixie June 4, 2019 23:47
@Piinks Piinks added the framework flutter/packages/flutter repository. See also f: labels. label Jun 5, 2019
@Hixie
Copy link
Contributor

Hixie commented Jun 5, 2019

LGTM

@goderbauer goderbauer merged commit 61b83d3 into flutter:master Jun 6, 2019
@goderbauer goderbauer deleted the frames branch June 6, 2019 01:02
zanderso added a commit that referenced this pull request Jun 6, 2019
Revert "Add currentSystemFrameTimeStamp to SchedulerBinding (#33886)"

This reverts commit 61b83d3.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants