Skip to content

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Jun 6, 2019

This reverts two engine rolls:

c84767c
881cdfd

For consistent bot failures in the android_views integration test.

Looks related: flutter/engine@5ea125e @matthew-carroll @amirh

@zanderso zanderso requested a review from tvolkert June 6, 2019 15:37
@zanderso
Copy link
Member Author

zanderso commented Jun 6, 2019

@bparrishMines

Revert "Add currentSystemFrameTimeStamp to SchedulerBinding (#33886)"

This reverts commit 61b83d3.
@zanderso
Copy link
Member Author

zanderso commented Jun 6, 2019

Also reverting 61b83d3 @goderbauer

@goderbauer
Copy link
Member

Why is 61b83d3 getting reverted?

@zanderso
Copy link
Member Author

zanderso commented Jun 6, 2019

@goderbauer There were failures related to that change in the presubmit checks for the engine revert by itself.

@goderbauer
Copy link
Member

Can you link to the failure so I can debug that for re-landing?

@zanderso
Copy link
Member Author

zanderso commented Jun 6, 2019

https://api.cirrus-ci.com/v1/task/6642212578787328/logs/test.log

00:19 +100 -1: /tmp/flutter sdk/packages/flutter/test/scheduler/scheduler_test.dart: currentSystemFrameTimeStamp is the raw timestamp [E]                                                              
  Expected: Duration:<0:00:00.000000>
    Actual: Duration:<-5:07:02.107324>
  
  package:test_api                     expect
  scheduler/scheduler_test.dart 152:5  main.<fn>

@zanderso zanderso merged commit 366dcb1 into flutter:master Jun 6, 2019
@zanderso zanderso deleted the revert-engine-roll branch June 6, 2019 16:50
@matthew-carroll
Copy link
Contributor

@zanderso do you know what I can do to repro whatever the problems were with flutter/engine@5ea125e ? I ran an app locally before putting up the PR, and the PR checks were green...

@amirh
Copy link
Contributor

amirh commented Jun 6, 2019

@matthew-carroll run the android_views driver test

@zanderso
Copy link
Member Author

zanderso commented Jun 6, 2019

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants