-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Revert engine back to afb9d510c3bb0f1b97980434b41200a2d3491697 #33982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Also reverting 61b83d3 @goderbauer |
|
Why is 61b83d3 getting reverted? |
|
@goderbauer There were failures related to that change in the presubmit checks for the engine revert by itself. |
|
Can you link to the failure so I can debug that for re-landing? |
|
https://api.cirrus-ci.com/v1/task/6642212578787328/logs/test.log |
|
@zanderso do you know what I can do to repro whatever the problems were with flutter/engine@5ea125e ? I ran an app locally before putting up the PR, and the PR checks were green... |
|
@matthew-carroll run the android_views driver test |
|
It looks like the test might have only been failing on Mac, so that might be where to start: https://flutter-dashboard.appspot.com/api/get-log?ownerKey=ahNzfmZsdXR0ZXItZGFzaGJvYXJkclgLEglDaGVja2xpc3QiOGZsdXR0ZXIvZmx1dHRlci9jODQ3NjdjYWU4Yzg4NzRiMTkyZTM1ZTk3NzdhNzA0NmM0YWZmNjBjDAsSBFRhc2sYgIDA8L2HlwkM |
This reverts two engine rolls:
c84767c
881cdfd
For consistent bot failures in the android_views integration test.
Looks related: flutter/engine@5ea125e @matthew-carroll @amirh