Skip to content

Sniff service protocol port from device #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnmccutchan merged 1 commit into from
Mar 17, 2016
Merged

Sniff service protocol port from device #2707

johnmccutchan merged 1 commit into from
Mar 17, 2016

Conversation

@johnmccutchan
Copy link
Contributor

@johnmccutchan johnmccutchan commented Mar 15, 2016

Fixes #1988

@johnmccutchan
Copy link
Contributor Author

johnmccutchan commented Mar 15, 2016

@abarth @devoncarew

@johnmccutchan
Copy link
Contributor Author

johnmccutchan commented Mar 15, 2016

@abarth mostly for how you want the other part of this change to land in sky_engine.

abarth
abarth reviewed Mar 15, 2016
View reviewed changes
packages/flutter_tools/lib/src/android/android_device.dart Outdated
Copy link
Contributor

@abarth abarth Mar 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please alphabetize

Copy link
Contributor Author

@johnmccutchan johnmccutchan Mar 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@devoncarew
Copy link
Contributor

devoncarew commented Mar 15, 2016

lgtm

(in atom you can sort directives using cmd-option-o)

@johnmccutchan
Copy link
Contributor Author

johnmccutchan commented Mar 17, 2016

Related flutter/engine#2515

@johnmccutchan
Copy link
Contributor Author

johnmccutchan commented Mar 17, 2016

@chinmaygarde for iOS changes.

johnmccutchan added a commit that referenced this pull request Mar 17, 2016
@johnmccutchan
Merge pull request #2707 from johnmccutchan/sniff_service_protocol_port
7e2df44 
Sniff service protocol port from device
@johnmccutchan johnmccutchan merged commit 7e2df44 into flutter:master Mar 17, 2016
@johnmccutchan johnmccutchan deleted the sniff_service_protocol_port branch November 22, 2016 00:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Atom ⌘-R fails if there's another Flutter app running in background on the Android device

3 participants

@johnmccutchan @devoncarew @abarth