This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Auto select Observatory port on Android and iOS simulators #2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
sky/engine/core/script/dart_init.cc
Outdated
| const intptr_t port = settings.observatory_port; | ||
| // We auto select the port on Android and iOS simulators. | ||
| const intptr_t port = | ||
| IsRunningPrecompiledCode() ? settings.observatory_port : 0; |
Contributor
There was a problem hiding this comment.
Does this ignore the command-line flag to set the observatory port?
Contributor
There was a problem hiding this comment.
Rather than ignoring the setting, maybe we should make the default value of the setting zero (i.e., in sky_settings.h).
Contributor
|
I suspect this entire CL could be reduced to changing 8181 to 0 in SkySettings.h |
Contributor
Author
|
@eseidelGoogle PTAL. I checked with Chinmay and he is fine with how this will affect the iOS device workflow. |
| LOG(INFO) | ||
| << "Observatory port specified was malformed. Will default to 8181"; | ||
| << "Observatory port specified was malformed. Will default to " | ||
| << settings.observatory_port; |
Contributor
There was a problem hiding this comment.
This will always be 0, no?
Contributor
|
lgtm |
johnmccutchan
added a commit
that referenced
this pull request
Mar 17, 2016
Auto select Observatory port on Android and iOS simulators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.