Skip to content

[flutter_tools] Add doctor validator warning for multiple adb installations#186031

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
mboetger:fix-multiple-adb-warning
Jun 12, 2026
Merged

[flutter_tools] Add doctor validator warning for multiple adb installations#186031
auto-submit[bot] merged 4 commits into
flutter:masterfrom
mboetger:fix-multiple-adb-warning

Conversation

@mboetger

@mboetger mboetger commented May 4, 2026

Copy link
Copy Markdown
Contributor

Detects if multiple unique adb binaries are installed on the user's PATH or Android SDK platform-tools. Having multiple adb versions can lead to conflicting server instances and device detection failures during development.

This change adds an OperatingSystemUtils dependency injection to AndroidValidator, resolves canonical paths using resolveSymbolicLinksSync to avoid duplicate symlink warnings, and outputs a hint in flutter doctor if multiple unique binaries are found.

Fixes #9709

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@mboetger
[flutter_tools] Add doctor validator warning for multiple adb install…
3adf52e 
…ations

Detects if multiple unique adb binaries are installed on the user's PATH
or Android SDK platform-tools. Having multiple adb versions can lead to
conflicting server instances and device detection failures during development.

This change adds an `OperatingSystemUtils` dependency injection to
`AndroidValidator`, resolves canonical paths using `resolveSymbolicLinksSync`
to avoid duplicate symlink warnings, and outputs a hint in `flutter doctor` if
multiple unique binaries are found.

Fixes flutter#9709
@mboetger mboetger requested a review from a team as a code owner May 4, 2026 23:12
@mboetger mboetger requested review from jesswrd and removed request for a team May 4, 2026 23:12
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label May 4, 2026
@github-actions github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. team-android Owned by Android platform team labels May 4, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 4, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the AndroidValidator to detect and warn users when multiple adb binaries are found, which can lead to device detection conflicts. The changes include adding an OperatingSystemUtils dependency to AndroidValidator, updating the context runner, and adding unit tests for the new validation logic. Feedback suggests refactoring the duplicated symbolic link resolution logic into a helper function and refining the warning message phrasing for better accuracy and consistency with other tool hints.

Comment thread packages/flutter_tools/lib/src/android/android_workflow.dart Outdated
Comment thread packages/flutter_tools/lib/src/android/android_workflow.dart Outdated
@github-actions github-actions Bot removed the CICD Run CI/CD label May 7, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label May 7, 2026
@camsim99 camsim99 requested a review from reidbaker May 26, 2026 21:01
@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2026
@auto-submit

auto-submit Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/186031, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 11, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 11, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 11, 2026
@auto-submit

auto-submit Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/186031, Failed to enqueue flutter/flutter/186031 with HTTP 400: Pull request Required status check "Merge Queue Guard" is expected..

@mboetger mboetger added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Jun 12, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Jun 12, 2026
Merged via the queue into flutter:master with commit e1e4265 Jun 12, 2026
171 of 172 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2026
This was referenced Jun 13, 2026
Closed
Closed
This was referenced Jun 13, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jun 15, 2026
@engine-flutter-autoroll
Roll Flutter from b7cb925419e6 to 5827d5fd2b8d (35 revisions) (#11908)
8286d39 
Roll Flutter from b7cb925419e6 to 5827d5fd2b8d (35 revisions)

flutter/flutter@b7cb925...5827d5f

2026-06-15 engine-flutter-autoroll@skia.org Roll Skia from 7128af60575a to c8d9f80f13e4 (1 revision) (flutter/flutter#188015)
2026-06-15 jason-simmons@users.noreply.github.com In the APNG decoder, validate the chunk data length before calling GetChunkSize to avoid potential overflow in the chunk size calculation (flutter/flutter#187949)
2026-06-15 engine-flutter-autoroll@skia.org Roll Skia from 6b4ac3bfb39d to 7128af60575a (1 revision) (flutter/flutter#188011)
2026-06-15 engine-flutter-autoroll@skia.org Roll Skia from 0a3b8549cbf0 to 6b4ac3bfb39d (7 revisions) (flutter/flutter#188007)
2026-06-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[a11y] Map some framework semantics roles to android classes.  (#185217)" (flutter/flutter#188008)
2026-06-15 chris@bracken.jp [ios] Filter UIScene events to those relating to Flutter VC scene (flutter/flutter#187987)
2026-06-15 jhy03261997@gmail.com [a11y] Map some framework semantics roles to android classes.  (flutter/flutter#185217)
2026-06-15 engine-flutter-autoroll@skia.org Roll Skia from f46928e7f50c to 0a3b8549cbf0 (1 revision) (flutter/flutter#188004)
2026-06-14 stuartmorgan@google.com Rework docs for flutter/packages changelogs (flutter/flutter#187666)
2026-06-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from nvzMQAmuRSzo7-wAP... to TbB86Po_HDe1dvXvT... (flutter/flutter#187997)
2026-06-14 engine-flutter-autoroll@skia.org Roll Skia from 4e2c9b5e4dad to f46928e7f50c (1 revision) (flutter/flutter#187996)
2026-06-14 engine-flutter-autoroll@skia.org Roll Skia from c52667607242 to 4e2c9b5e4dad (1 revision) (flutter/flutter#187990)
2026-06-14 737941+loic-sharma@users.noreply.github.com Improve RenderTargetCache docs (flutter/flutter#187893)
2026-06-13 brackenavaron@gmail.com [Test cross_imports] Check cross imports in flutter_test/** (flutter/flutter#187587)
2026-06-13 matt.kosarek@canonical.com Fixing corrupted window size OnEmptyFrameGenerated due to transpsed width/height (flutter/flutter#187954)
2026-06-13 engine-flutter-autoroll@skia.org Roll Skia from 42355271a335 to c52667607242 (2 revisions) (flutter/flutter#187979)
2026-06-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from A3eaUn9mQ_EkSNxVI... to nvzMQAmuRSzo7-wAP... (flutter/flutter#187975)
2026-06-13 engine-flutter-autoroll@skia.org Roll Skia from 9ef46390c2d1 to 42355271a335 (1 revision) (flutter/flutter#187974)
2026-06-13 bdero@google.com [Flutter GPU] Make ShaderLibrary.fromAsset asynchronous (flutter/flutter#187716)
2026-06-13 engine-flutter-autoroll@skia.org Roll Skia from 8c89bf2b0ee3 to 9ef46390c2d1 (6 revisions) (flutter/flutter#187968)
2026-06-12 bdero@google.com [Flutter GPU] Add surface API for framework presentation (flutter/flutter#187358)
2026-06-12 bkonyi@google.com [gen_l10n] Exclude inherited keys from untranslated-messages-file (flutter/flutter#187950)
2026-06-12 31859944+LongCatIsLooong@users.noreply.github.com Update `MediaQueryData` docs for devicePixelRatio overriding (flutter/flutter#187542)
2026-06-12 bdero@google.com [Impeller] Fix dirty-range race in DeviceBufferGLES uploads (flutter/flutter#187932)
2026-06-12 pascal@phntm.xyz Compare isModifiedAfter against the given time (flutter/flutter#187727)
2026-06-12 planetmarshall@users.noreply.github.com Enable unit tests for compilation of compute shaders on non-metal backends (flutter/flutter#179683)
2026-06-12 matt.boetger@gmail.com [flutter_tools] Add doctor validator warning for multiple adb installations (flutter/flutter#186031)
2026-06-12 matt.boetger@gmail.com Optimize SHA hash calculation of generated APK (flutter/flutter#187184)
2026-06-12 mu7ammadkamel@hotmail.com Scope widget inspector overlay to the selected widget's modal route (flutter/flutter#186784)
2026-06-12 30870216+gaaclarke@users.noreply.github.com Switches Windows to OpenGLESSDF (flutter/flutter#187877)
2026-06-12 matt.boetger@gmail.com [integration_test] Update README to support modern Kotlin-based setups by default (flutter/flutter#186080)
2026-06-12 jason-simmons@users.noreply.github.com Convert the PNG signature constant in APNGImageGenerator to a std::array and use it in the APNG tests (flutter/flutter#187930)
2026-06-12 matt.boetger@gmail.com Correct backoff retry time cap unit and add regression tests (flutter/flutter#187250)
2026-06-12 chingjun@google.com Fix std::vector out-of-bounds access in Flutter Android JNI and Delegate (flutter/flutter#187218)
2026-06-12 matt.boetger@gmail.com [Android] Adding 30-second timeouts to adb stopApp and uninstallApp (flutter/flutter#187876)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
...
@mboetger mboetger added the l:backlog LLM created PR addressing a backlog issue. label Jun 18, 2026
via-guy pushed a commit to via-guy/flutter that referenced this pull request Jun 26, 2026
@mboetger @via-guy
[flutter_tools] Add doctor validator warning for multiple adb install…
a6693d3 
…ations (flutter#186031)

Detects if multiple unique adb binaries are installed on the user's PATH
or Android SDK platform-tools. Having multiple adb versions can lead to
conflicting server instances and device detection failures during
development.

This change adds an `OperatingSystemUtils` dependency injection to
`AndroidValidator`, resolves canonical paths using
`resolveSymbolicLinksSync` to avoid duplicate symlink warnings, and
outputs a hint in `flutter doctor` if multiple unique binaries are
found.

Fixes flutter#9709

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes
@jesswrd jesswrd Awaiting requested review from jesswrd jesswrd is a code owner automatically assigned from flutter/android-reviewers
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD l:backlog LLM created PR addressing a backlog issue. team-android Owned by Android platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a doctor validator warning for multiple adb installations

3 participants

@mboetger @reidbaker @camsim99