[flutter_tools] Fix `flutter drive --chrome-binary` being ignored on web by temoorx · Pull Request #185481 · flutter/flutter

temoorx · 2026-04-23T16:17:53Z

Description

Fixes a mismatch in the internal web platform args used by flutter drive.

For web runs, DriveCommand was passing --no-launch-chrome, but
ChromiumDevice.startApp checks for no-launch-chrome. Because of that,
Flutter still launched its default Chrome instance instead of leaving browser
startup to WebDriver, which made --chrome-binary ineffective.

This change updates the platform arg key to match what the web device expects
and adds a regression test covering the web flutter drive path.

Fixes #171504

Tests

FLUTTER_ROOT=/Users/temoor/Documents/Codex/2026-04-23-so-i-wanna-be-contributor-on/flutter ../../bin/cache/dart-sdk/bin/dart test test/commands.shard/hermetic/drive_test.dart -r expanded
FLUTTER_ROOT=/Users/temoor/Documents/Codex/2026-04-23-so-i-wanna-be-contributor-on/flutter ../../bin/cache/dart-sdk/bin/dart test test/general.shard/drive/web_driver_service_test.dart -r expanded

gemini-code-assist

Code Review

This pull request updates the DriveCommand to use 'no-launch-chrome' instead of '--no-launch-chrome' in the platform arguments for web targets. It introduces a new test case and several helper classes in drive_test.dart to verify this change. The review feedback identifies that the newly added public classes lack documentation, which is a requirement of the repository's style guide.

gemini-code-assist · 2026-04-23T16:22:09Z

  }
 }

+class CapturingFlutterDriverFactory extends Fake implements FlutterDriverFactory {


The class CapturingFlutterDriverFactory is missing documentation. According to the Flutter style guide, all public members should have documentation.

Suggested change

class CapturingFlutterDriverFactory extends Fake implements FlutterDriverFactory {

/// A [FlutterDriverFactory] that returns a [CapturingDriverService].

class CapturingFlutterDriverFactory extends Fake implements FlutterDriverFactory {

References

All public members should have documentation. ^(link)

gemini-code-assist · 2026-04-23T16:22:10Z

  }
 }

+class CapturingDriverService extends Fake implements DriverService {


The class CapturingDriverService is missing documentation. According to the Flutter style guide, all public members should have documentation.

Suggested change

class CapturingDriverService extends Fake implements DriverService {

/// A [DriverService] that captures the [platformArgs] passed to [start].

class CapturingDriverService extends Fake implements DriverService {

References

All public members should have documentation. ^(link)

gemini-code-assist · 2026-04-23T16:22:10Z

  Future<TargetPlatform> get targetPlatform async => TargetPlatform.ios;
 }

+class FakeChromiumDriveDevice extends Fake implements ChromiumDevice {


The class FakeChromiumDriveDevice is missing documentation. According to the Flutter style guide, all public members should have documentation.

Suggested change

class FakeChromiumDriveDevice extends Fake implements ChromiumDevice {

/// A [ChromiumDevice] for testing web drive commands.

class FakeChromiumDriveDevice extends Fake implements ChromiumDevice {

References

All public members should have documentation. ^(link)

bkonyi

LGTM!

mdebbar · 2026-05-04T14:38:40Z

Thanks for contributing this fix! This is a good first step towards fixing the issue. But I'm worried it doesn't fully resolve it.

Looking at the code here:

flutter/packages/flutter_tools/lib/src/drive/web_driver_service.dart

Line 74 in 7955780

Map<String, Object> platformArgs = const <String, Object>{},

the platformArgs parameter isn't passed anywhere. There's still some work to do to make sure platformArgs is reaching all the way to ChromiumDevice.startApp.

temoorx · 2026-05-04T15:09:10Z

Thanks, good catch. You're right — platformArgs was reaching WebDriverService.start, but it was not being forwarded through the web runner path to ChromiumDevice.startApp. I've updated the fix to thread platformArgs through WebRunnerFactory and ResidentWebRunner, and added coverage for that path as well.

bkonyi · 2026-05-06T15:22:35Z

It looks like there's some failing tests that we'll need to resolve before this can land.

temoorx · 2026-05-11T16:35:02Z

@mdebbar

auto-submit · 2026-05-13T18:25:59Z

autosubmit label was removed for flutter/flutter/185481, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

auto-submit · 2026-05-15T14:33:28Z

autosubmit label was removed for flutter/flutter/185481, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 2 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

temoorx · 2026-05-18T13:58:31Z

All checks are green now. Please let me know if anything else is needed from my side. Thanks!

auto-submit · 2026-05-19T17:58:50Z

autosubmit label was removed for flutter/flutter/185481, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

flutter/flutter@54e199a...701665b 2026-06-02 engine-flutter-autoroll@skia.org Roll Skia from c97e939eb5c9 to 279b17fe9fc1 (16 revisions) (flutter/flutter#187425) 2026-06-02 bdero@google.com [Flutter GPU] Add block-compressed texture format support (BC, ETC2, ASTC LDR) (flutter/flutter#187281) 2026-06-02 bdero@google.com [Impeller] Allow attaching specific texture mip levels and slices (flutter/flutter#187066) 2026-06-02 bdero@google.com [Impeller] Fix GLES command submission status before context is current (flutter/flutter#187293) 2026-06-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 3cdc25e8ffe9 to d39850bf4a01 (9 revisions) (flutter/flutter#187409) 2026-06-01 jason-simmons@users.noreply.github.com [Impeller] Use glVertexAttribDivisor on GLES3 and glVertexAttribDivisorEXT on GLES2 with the extension (flutter/flutter#187313) 2026-06-01 matt.boetger@gmail.com [Android] Add Javadoc documentation to TextInputChannel (flutter/flutter#186018) 2026-06-01 mvincentong@gmail.com Read FLTEnableWideGamut from Dart bundle (flutter/flutter#186509) 2026-06-01 matt.boetger@gmail.com [flutter_tools] Remove obsolete AndroidX console warning during Gradle builds (flutter/flutter#186077) 2026-06-01 kjlubick@users.noreply.github.com [skia] Update gni file list name hsw -> ml3 (flutter/flutter#184892) 2026-06-01 zhongliu88889@gmail.com [web] Always sync slider input attrs regardless of gesture mode (flutter/flutter#187217) 2026-06-01 zhongliu88889@gmail.com [flutter_driver] Don't throw when stderr is unavailable on web (flutter/flutter#187190) 2026-06-01 116356835+AbdeMohlbi@users.noreply.github.com Remove unused code in `FlutterPluginUtils.kt` (flutter/flutter#187012) 2026-06-01 taak140@gmail.com [flutter_tools] Fix `flutter drive --chrome-binary` being ignored on web (flutter/flutter#185481) 2026-06-01 davidmartos96@gmail.com Eager failure when building and no XCode build settings (flutter/flutter#184726) 2026-06-01 goung123@gmail.com Fix Windows Korean IME caret position during composition (flutter/flutter#186353) 2026-06-01 okorohelijah@google.com iOS: update provisioning profile for 2026-2027 cert (flutter/flutter#187280) 2026-06-01 154381524+flutteractionsbot@users.noreply.github.com Sync CHANGELOG.md from stable (flutter/flutter#187380) 2026-06-01 jason-simmons@users.noreply.github.com Reland "Move dart-lang/ai to a top level third party dependency in engine (#187268)" (flutter/flutter#187378) 2026-06-01 stuartmorgan@google.com Add vector_math to Framework triage (flutter/flutter#187389) 2026-06-01 engine-flutter-autoroll@skia.org Roll Packages from e930ced to f5d50ca (4 revisions) (flutter/flutter#187381) 2026-06-01 mr_nadeem_iqbal@yahoo.com [flutter_tools] Reject archive entries that escape into a sibling directory by name prefix (#185794) (flutter/flutter#186647) 2026-06-01 bkonyi@google.com [flutter_tools] Fix widget_preview unawaited async write race condition (flutter/flutter#187177) 2026-06-01 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#187375) 2026-06-01 engine-flutter-autoroll@skia.org Roll Skia from 0aee4675e0ad to c97e939eb5c9 (7 revisions) (flutter/flutter#187371) 2026-06-01 mr_nadeem_iqbal@yahoo.com docs: Stack.clipBehavior = Clip.none does not extend hit testing (#160787) (flutter/flutter#186643) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#11822) flutter/flutter@54e199a...701665b 2026-06-02 engine-flutter-autoroll@skia.org Roll Skia from c97e939eb5c9 to 279b17fe9fc1 (16 revisions) (flutter/flutter#187425) 2026-06-02 bdero@google.com [Flutter GPU] Add block-compressed texture format support (BC, ETC2, ASTC LDR) (flutter/flutter#187281) 2026-06-02 bdero@google.com [Impeller] Allow attaching specific texture mip levels and slices (flutter/flutter#187066) 2026-06-02 bdero@google.com [Impeller] Fix GLES command submission status before context is current (flutter/flutter#187293) 2026-06-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 3cdc25e8ffe9 to d39850bf4a01 (9 revisions) (flutter/flutter#187409) 2026-06-01 jason-simmons@users.noreply.github.com [Impeller] Use glVertexAttribDivisor on GLES3 and glVertexAttribDivisorEXT on GLES2 with the extension (flutter/flutter#187313) 2026-06-01 matt.boetger@gmail.com [Android] Add Javadoc documentation to TextInputChannel (flutter/flutter#186018) 2026-06-01 mvincentong@gmail.com Read FLTEnableWideGamut from Dart bundle (flutter/flutter#186509) 2026-06-01 matt.boetger@gmail.com [flutter_tools] Remove obsolete AndroidX console warning during Gradle builds (flutter/flutter#186077) 2026-06-01 kjlubick@users.noreply.github.com [skia] Update gni file list name hsw -> ml3 (flutter/flutter#184892) 2026-06-01 zhongliu88889@gmail.com [web] Always sync slider input attrs regardless of gesture mode (flutter/flutter#187217) 2026-06-01 zhongliu88889@gmail.com [flutter_driver] Don't throw when stderr is unavailable on web (flutter/flutter#187190) 2026-06-01 116356835+AbdeMohlbi@users.noreply.github.com Remove unused code in `FlutterPluginUtils.kt` (flutter/flutter#187012) 2026-06-01 taak140@gmail.com [flutter_tools] Fix `flutter drive --chrome-binary` being ignored on web (flutter/flutter#185481) 2026-06-01 davidmartos96@gmail.com Eager failure when building and no XCode build settings (flutter/flutter#184726) 2026-06-01 goung123@gmail.com Fix Windows Korean IME caret position during composition (flutter/flutter#186353) 2026-06-01 okorohelijah@google.com iOS: update provisioning profile for 2026-2027 cert (flutter/flutter#187280) 2026-06-01 154381524+flutteractionsbot@users.noreply.github.com Sync CHANGELOG.md from stable (flutter/flutter#187380) 2026-06-01 jason-simmons@users.noreply.github.com Reland "Move dart-lang/ai to a top level third party dependency in engine (#187268)" (flutter/flutter#187378) 2026-06-01 stuartmorgan@google.com Add vector_math to Framework triage (flutter/flutter#187389) 2026-06-01 engine-flutter-autoroll@skia.org Roll Packages from e930ced to f5d50ca (4 revisions) (flutter/flutter#187381) 2026-06-01 mr_nadeem_iqbal@yahoo.com [flutter_tools] Reject archive entries that escape into a sibling directory by name prefix (#185794) (flutter/flutter#186647) 2026-06-01 bkonyi@google.com [flutter_tools] Fix widget_preview unawaited async write race condition (flutter/flutter#187177) 2026-06-01 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#187375) 2026-06-01 engine-flutter-autoroll@skia.org Roll Skia from 0aee4675e0ad to c97e939eb5c9 (7 revisions) (flutter/flutter#187371) 2026-06-01 mr_nadeem_iqbal@yahoo.com docs: Stack.clipBehavior = Clip.none does not extend hit testing (#160787) (flutter/flutter#186643) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…web (flutter#185481) ## Description Fixes a mismatch in the internal web platform args used by `flutter drive`. For web runs, `DriveCommand` was passing `--no-launch-chrome`, but `ChromiumDevice.startApp` checks for `no-launch-chrome`. Because of that, Flutter still launched its default Chrome instance instead of leaving browser startup to WebDriver, which made `--chrome-binary` ineffective. This change updates the platform arg key to match what the web device expects and adds a regression test covering the web `flutter drive` path. Fixes flutter#171504 ## Tests - `FLUTTER_ROOT=/Users/temoor/Documents/Codex/2026-04-23-so-i-wanna-be-contributor-on/flutter ../../bin/cache/dart-sdk/bin/dart test test/commands.shard/hermetic/drive_test.dart -r expanded` - `FLUTTER_ROOT=/Users/temoor/Documents/Codex/2026-04-23-so-i-wanna-be-contributor-on/flutter ../../bin/cache/dart-sdk/bin/dart test test/general.shard/drive/web_driver_service_test.dart -r expanded` --------- Co-authored-by: Ben Konyi <bkonyi@google.com>

[flutter_tools] Fix flutter drive chrome-binary handling on web

68217f5

github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 23, 2026

temoorx marked this pull request as ready for review April 23, 2026 16:20

gemini-code-assist Bot reviewed Apr 23, 2026

View reviewed changes

bkonyi requested review from bkonyi and mdebbar May 4, 2026 14:22

bkonyi previously approved these changes May 4, 2026

View reviewed changes

bkonyi mentioned this pull request May 4, 2026

[flutter_tools] Pass --chrome-binary to app hosting Chrome in flutter drive #179935

Closed

bkonyi added the CICD Run CI/CD label May 4, 2026

[flutter_tools] Forward web drive platform args through the web runner

382c24c

temoorx dismissed bkonyi’s stale review via 382c24c May 4, 2026 15:06

github-actions Bot removed the CICD Run CI/CD label May 4, 2026

bkonyi added the CICD Run CI/CD label May 5, 2026

[flutter_tools] Fix resident web runner platform args test

af0e887

github-actions Bot removed the CICD Run CI/CD label May 6, 2026

bkonyi added the CICD Run CI/CD label May 7, 2026

bkonyi previously approved these changes May 11, 2026

View reviewed changes

mdebbar previously approved these changes May 13, 2026

View reviewed changes

mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label May 13, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 13, 2026

Merge branch 'master' into codex/fix-drive-chrome-binary-web

b7c87ea

github-actions Bot removed the CICD Run CI/CD label May 13, 2026

bkonyi added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels May 13, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 13, 2026

bkonyi added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels May 15, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2026

bkonyi previously approved these changes May 15, 2026

View reviewed changes

kevmoo added the fyi-web For the attention of Web platform team label May 15, 2026

temoorx requested a review from mdebbar May 19, 2026 16:03

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2026

Merge branch 'master' into codex/fix-drive-chrome-binary-web

c9ac33c

bkonyi dismissed their stale review via c9ac33c May 25, 2026 16:34

github-actions Bot removed the CICD Run CI/CD label May 25, 2026

bkonyi approved these changes May 25, 2026

View reviewed changes

Merge branch 'master' into codex/fix-drive-chrome-binary-web

f7d6e68

bkonyi added team-web Owned by Web platform team CICD Run CI/CD labels Jun 1, 2026

mdebbar approved these changes Jun 1, 2026

View reviewed changes

mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 1, 2026

auto-submit Bot added this pull request to the merge queue Jun 1, 2026

Merged via the queue into flutter:master with commit 4d5e75f Jun 1, 2026
170 of 171 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 1, 2026

temoorx deleted the codex/fix-drive-chrome-binary-web branch June 2, 2026 07:24

This was referenced Jun 2, 2026

Roll Flutter from 54e199ac49e0 to 701665b97818 (26 revisions) flutter/packages#11821

Closed

Roll Flutter from 54e199ac49e0 to 701665b97818 (26 revisions) flutter/packages#11822

Merged

	class CapturingFlutterDriverFactory extends Fake implements FlutterDriverFactory {
	/// A [FlutterDriverFactory] that returns a [CapturingDriverService].
	class CapturingFlutterDriverFactory extends Fake implements FlutterDriverFactory {

	class CapturingDriverService extends Fake implements DriverService {
	/// A [DriverService] that captures the [platformArgs] passed to [start].
	class CapturingDriverService extends Fake implements DriverService {

	class FakeChromiumDriveDevice extends Fake implements ChromiumDevice {
	/// A [ChromiumDevice] for testing web drive commands.
	class FakeChromiumDriveDevice extends Fake implements ChromiumDevice {

Uh oh!

Conversation

temoorx commented Apr 23, 2026

Description

Tests

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

mdebbar commented May 4, 2026

Uh oh!

temoorx commented May 4, 2026

Uh oh!

bkonyi commented May 6, 2026

Uh oh!

temoorx commented May 11, 2026

Uh oh!

auto-submit Bot commented May 13, 2026

Uh oh!

auto-submit Bot commented May 15, 2026

Uh oh!

temoorx commented May 18, 2026

Uh oh!

auto-submit Bot commented May 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants