[CP-stable]Only use LLDB breakpoint in debug mode#185348
Merged
auto-submit[bot] merged 1 commit intoApr 24, 2026
Merged
Conversation
The JIT breakpoint workaround is only needed and only enabled on the Dart side in debug mode. When running `--profile` mode, the breakpoint is never set and therefore causes the process to hang. This PR skips the JIT breakpoint workaround for profile mode. Fixes flutter#185150. - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the iOS app launching and LLDB attachment logic to support different build modes. It introduces a BuildMode parameter to IOSCoreDeviceLauncher.launchApp and LLDB.attachAndStart, allowing the debugger to conditionally set breakpoints and match specific log patterns during process resumption. Feedback suggests improving regex consistency for process ID matching and updating documentation to clarify that certain logic applies to all non-debug modes.
| /// Pattern of lldb log when the process is resuming. | ||
| /// | ||
| /// Example: (lldb) Process 6152 resuming | ||
| static final _lldbProcessResuming = RegExp(r'Process \d+ resuming'); |
Contributor
There was a problem hiding this comment.
For consistency with _lldbProcessStopped on line 44, consider using \d* instead of \d+ in the regex. While a PID should always be present, the existing pattern for stopped processes allows for an optional PID, and following that pattern here would make the regexes more robust to variations in LLDB output formatting.
static final _lldbProcessResuming = RegExp(r'Process \d* resuming');
Comment on lines
+261
to
+263
| // When using debug mode, a breakpoint is added once the process resumes and no resume log | ||
| // is shown. Instead we match on the breakpoint added log. In profile mode, a resume log is | ||
| // shown once the process resumes and no breakpoint log is shown. |
Contributor
There was a problem hiding this comment.
The comment specifically mentions 'profile mode', but the logic in the code (using the ternary operator) applies to all non-debug modes (including release). It might be clearer to phrase this as 'In other modes (such as profile mode)...' to accurately reflect the implementation.
// When using debug mode, a breakpoint is added once the process resumes and no resume log
// is shown. Instead we match on the breakpoint added log. In other modes (such as profile mode), a resume log is
// shown once the process resumes and no breakpoint log is shown.
jmagman
approved these changes
Apr 21, 2026
justinmc
approved these changes
Apr 24, 2026
justinmc
left a comment
Contributor
There was a problem hiding this comment.
CPLGTM 👍 . Apologies that I missed this PR earlier in the week, it will likely not be released until next week.
c5b90e1
into
flutter:flutter-3.41-candidate.0
134 checks passed
Xbectordash
pushed a commit
to Xbectordash/abhi_flutter_fork
that referenced
this pull request
May 13, 2026
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. What is the link to the issue this cherry-pick is addressing? flutter#185150 What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping of production apps (the app crashes on launch). This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick. Deploying to a physical iOS device in profile mode with Xcode 26 will hang. Explain this cherry pick: * In one line that is accessible to most Flutter developers. * That describes the state prior to the fix. * That includes which platforms are impacted. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples. < Replace with changelog description here > [flutter/185150] When using profile mode on a physical iOS device, the app may fail to connect to the Dart VM. Is there a workaround for this issue? Disable LLDB debuggin (`flutter config --no-enable-lldb-debugging`) or run through Xcode What is the risk level of this cherry-pick? Are you confident that your fix is well-tested by automated tests? What are the steps to validate that this fix works? Run one of these tests: flutter#185150 (comment)
Xbectordash
pushed a commit
to Xbectordash/abhi_flutter_fork
that referenced
this pull request
May 13, 2026
The changelong entry for the 3.41.8 stable hotfix release (flutter#185549) for the single cherry picked PR, flutter#185348.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#185150
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.
Deploying to a physical iOS device in profile mode with Xcode 26 will hang.
Changelog Description:
Explain this cherry pick:
See best practices for examples.
< Replace with changelog description here >
[flutter/185150] When using profile mode on a physical iOS device, the app may fail to connect to the Dart VM.
Workaround:
Is there a workaround for this issue?
Disable LLDB debuggin (
flutter config --no-enable-lldb-debugging) or run through XcodeRisk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Run one of these tests: #185150 (comment)