Update changelog with single change.#185554
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request adds a changelog entry for Flutter 3.41.8 regarding Dart VM connection issues on iOS devices. Feedback indicates that the entry contains an incorrect reference number and link, suggesting a correction to point to the specific pull request.
| ## Flutter 3.41 Changes | ||
|
|
||
| ### [3.41.8](https://github.com/flutter/flutter/releases/tag/3.41.8) | ||
| - [flutter/185150](https://github.com/flutter/flutter/releases/tag/3.41.8) When using profile mode on a physical iOS device, the app may fail to connect to the Dart VM. |
There was a problem hiding this comment.
The link for this changelog entry incorrectly points to the release tag instead of the specific pull request or issue. Additionally, the number 185150 in the text does not match the pull request (185348) or the issue (185549) mentioned in the PR description. To ensure the documentation is useful and accurate, the link should point to the specific change.
| - [flutter/185150](https://github.com/flutter/flutter/releases/tag/3.41.8) When using profile mode on a physical iOS device, the app may fail to connect to the Dart VM. | |
| - [flutter/185348](https://github.com/flutter/flutter/pull/185348) When using profile mode on a physical iOS device, the app may fail to connect to the Dart VM. |
References
- Documentation should be useful and explain the why and how. Providing an incorrect link to a release tag instead of the specific change reduces the utility of the changelog. (link)
There was a problem hiding this comment.
Gemini is correct. Looks like a copy-paste error. Can you fix?
There was a problem hiding this comment.
Whoops that's right. Fixed!
| ## Flutter 3.41 Changes | ||
|
|
||
| ### [3.41.8](https://github.com/flutter/flutter/releases/tag/3.41.8) | ||
| - [flutter/185150](https://github.com/flutter/flutter/releases/tag/3.41.8) When using profile mode on a physical iOS device, the app may fail to connect to the Dart VM. |
There was a problem hiding this comment.
Gemini is correct. Looks like a copy-paste error. Can you fix?
02085fe
into
flutter:flutter-3.41-candidate.0
The changelong entry for the 3.41.8 stable hotfix release (flutter#185549) for the single cherry picked PR, flutter#185348.
The changelong entry for the 3.41.8 stable hotfix release (#185549) for the single cherry picked PR, #185348.