Linux reuse sibling by richardexfo · Pull Request #183653 · flutter/flutter

richardexfo · 2026-03-13T18:03:41Z

Add reuse render_sibling to avoid memory leak. to @robert-ancell PR #183539

We observed a memory leak on Linux Desktop with Wayland on embedded ARM cpu and an OpenGL ES driver.
While the fix works in our environment, I'm not sure it's correct in all scenarios. Maybe someone with more experience in the Flutter Linux rendering can review and provide some feedback.
The memory leak seems related to issue mentioned below.

#182192

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

This ensures it is destroyed when no object is using it. It was previously leaking. Fixes flutter#182192

gemini-code-assist

Code Review

This pull request addresses a memory leak on Linux with Wayland by reusing a sibling framebuffer instead of creating a new one for each frame. This is implemented by adding a render_sibling member to FlCompositorOpenGL. To support this and correctly manage the lifecycle of the underlying EGL image, a new GObject wrapper, FlEGLImage, is introduced, which uses reference counting. The changes are well-structured and address the reported issue. I've found one critical memory leak in the constructor of the new FlEGLImage class that should be addressed.

robert-ancell · 2026-03-17T03:25:15Z

Merged and retested - I'm still getting black window contents when the window is resized. This does not occur in master. Have not investigated beyond that.

richardexfo · 2026-03-17T17:35:15Z

@robert-ancell thank you for testing. I simplified the managing of the sibling, and I can't reproduce the black screen window. Could you give me some guidance how to reproduce the black screen and the system you are using (OS? GPU? Wayland?).

robert-ancell · 2026-03-18T03:51:59Z

With the simplification it's working here, so this is now good to land.

This reverts commit ed5bda4.

robert-ancell · 2026-03-19T02:29:38Z

Further testing shows this breaking multi-window support: #183871

flutter/flutter@d117642...dd64978 2026-03-18 engine-flutter-autoroll@skia.org Roll Skia from 2fb5fa71eb12 to f0a13e5efbad (2 revisions) (flutter/flutter#183830) 2026-03-18 engine-flutter-autoroll@skia.org Roll Skia from ae3d36cb9e29 to 2fb5fa71eb12 (3 revisions) (flutter/flutter#183823) 2026-03-18 94012149+richardexfo@users.noreply.github.com Linux reuse sibling (flutter/flutter#183653) 2026-03-18 engine-flutter-autoroll@skia.org Roll Skia from 84a180a1fa80 to ae3d36cb9e29 (4 revisions) (flutter/flutter#183812) 2026-03-18 1961493+harryterkelsen@users.noreply.github.com fix(web): handle asynchronously disposed platform views (flutter/flutter#183666) 2026-03-17 87018443+mayanksharma9@users.noreply.github.com (Test cross-imports) Remove legacy Material import from sliver_constraints_test (flutter/flutter#183351) 2026-03-17 74057391+jhonathanqz@users.noreply.github.com Fix Android Studio pluginsPath when version is unknown (do not use 0.0) (flutter/flutter#182681) 2026-03-17 50643541+Mairramer@users.noreply.github.com Fixes animation glitch into bottom sheet (flutter/flutter#183303) 2026-03-17 ahmedsameha1@gmail.com Handle#6537 second grouped test (flutter/flutter#182529) 2026-03-17 ahmedsameha1@gmail.com Add a Clarification for the docs of suggestionsBuilder of SearchAnchor (flutter/flutter#183106) 2026-03-17 nate.w5687@gmail.com Remove obsolete null checks from style guide (flutter/flutter#181703) 2026-03-17 jason-simmons@users.noreply.github.com [Impeller] Do not delete the GL object in a HandleGLES if the handle has a cleanup callback (flutter/flutter#183561) 2026-03-17 jason-simmons@users.noreply.github.com Encode source file patches as UTF-8 in the code formatter script (flutter/flutter#183761) 2026-03-17 82673815+gktirkha@users.noreply.github.com Fix widget inspector control layout and add safe area regression test (flutter/flutter#180789) 2026-03-17 43054281+camsim99@users.noreply.github.com Reland "[Android] Add mechanism for setting Android engine flags via Android manifest (take 2)" (flutter/flutter#182522) 2026-03-17 1961493+harryterkelsen@users.noreply.github.com fix(web): fix crash in Skwasm when transferring non-transferable texture sources (flutter/flutter#183799) 2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from dba893a44d7a to 84a180a1fa80 (7 revisions) (flutter/flutter#183803) 2026-03-17 brunocorona.alcantar@gmail.com Framework: Improve DropdownButton selectedItemBuilder assertion (flutter/flutter#183732) 2026-03-17 brunocorona.alcantar@gmail.com Add mainAxisAlignment to NavigationRail (flutter/flutter#183514) 2026-03-17 34871572+gmackall@users.noreply.github.com Update android triage process to not look at unassigned p1s every week (flutter/flutter#183805) 2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds macos impeller new gallery transition perf test. (flutter/flutter#183802) 2026-03-17 1961493+harryterkelsen@users.noreply.github.com fix(web_ui): move prepareToDraw after raster to improve concurrency and stability (flutter/flutter#183791) 2026-03-17 rmacnak@google.com [build] Generate debug info for assembly. (flutter/flutter#183425) 2026-03-17 mdebbar@google.com [web] Fix occasional failure to find Chrome tab (flutter/flutter#183737) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This reverts commit ed5bda4. When running the `examples/multiple_windows` and creating a regular window then closing it causes the content of the main window to stop being updated. The terminal shows: ``` GrGLGpu::flushRenderTargetNoColorWrites glCheckFramebufferStatus 8cd7 ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLGpu.cpp(2271) : Clear(clearMask) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(225) : DrawRangeElements(glPrimType, minIndexValue, maxIndexValue, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex)) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(203) : DrawArrays(glPrimType, baseVertex, vertexCount) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLTexture.cpp(192) : ObjectLabel(0x1702, fID, -1, label.c_str()) ```

This reverts commit ed5bda4.

…r#11281) flutter/flutter@d117642...dd64978 2026-03-18 engine-flutter-autoroll@skia.org Roll Skia from 2fb5fa71eb12 to f0a13e5efbad (2 revisions) (flutter/flutter#183830) 2026-03-18 engine-flutter-autoroll@skia.org Roll Skia from ae3d36cb9e29 to 2fb5fa71eb12 (3 revisions) (flutter/flutter#183823) 2026-03-18 94012149+richardexfo@users.noreply.github.com Linux reuse sibling (flutter/flutter#183653) 2026-03-18 engine-flutter-autoroll@skia.org Roll Skia from 84a180a1fa80 to ae3d36cb9e29 (4 revisions) (flutter/flutter#183812) 2026-03-18 1961493+harryterkelsen@users.noreply.github.com fix(web): handle asynchronously disposed platform views (flutter/flutter#183666) 2026-03-17 87018443+mayanksharma9@users.noreply.github.com (Test cross-imports) Remove legacy Material import from sliver_constraints_test (flutter/flutter#183351) 2026-03-17 74057391+jhonathanqz@users.noreply.github.com Fix Android Studio pluginsPath when version is unknown (do not use 0.0) (flutter/flutter#182681) 2026-03-17 50643541+Mairramer@users.noreply.github.com Fixes animation glitch into bottom sheet (flutter/flutter#183303) 2026-03-17 ahmedsameha1@gmail.com Handle#6537 second grouped test (flutter/flutter#182529) 2026-03-17 ahmedsameha1@gmail.com Add a Clarification for the docs of suggestionsBuilder of SearchAnchor (flutter/flutter#183106) 2026-03-17 nate.w5687@gmail.com Remove obsolete null checks from style guide (flutter/flutter#181703) 2026-03-17 jason-simmons@users.noreply.github.com [Impeller] Do not delete the GL object in a HandleGLES if the handle has a cleanup callback (flutter/flutter#183561) 2026-03-17 jason-simmons@users.noreply.github.com Encode source file patches as UTF-8 in the code formatter script (flutter/flutter#183761) 2026-03-17 82673815+gktirkha@users.noreply.github.com Fix widget inspector control layout and add safe area regression test (flutter/flutter#180789) 2026-03-17 43054281+camsim99@users.noreply.github.com Reland "[Android] Add mechanism for setting Android engine flags via Android manifest (take 2)" (flutter/flutter#182522) 2026-03-17 1961493+harryterkelsen@users.noreply.github.com fix(web): fix crash in Skwasm when transferring non-transferable texture sources (flutter/flutter#183799) 2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from dba893a44d7a to 84a180a1fa80 (7 revisions) (flutter/flutter#183803) 2026-03-17 brunocorona.alcantar@gmail.com Framework: Improve DropdownButton selectedItemBuilder assertion (flutter/flutter#183732) 2026-03-17 brunocorona.alcantar@gmail.com Add mainAxisAlignment to NavigationRail (flutter/flutter#183514) 2026-03-17 34871572+gmackall@users.noreply.github.com Update android triage process to not look at unassigned p1s every week (flutter/flutter#183805) 2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds macos impeller new gallery transition perf test. (flutter/flutter#183802) 2026-03-17 1961493+harryterkelsen@users.noreply.github.com fix(web_ui): move prepareToDraw after raster to improve concurrency and stability (flutter/flutter#183791) 2026-03-17 rmacnak@google.com [build] Generate debug info for assembly. (flutter/flutter#183425) 2026-03-17 mdebbar@google.com [web] Fix occasional failure to find Chrome tab (flutter/flutter#183737) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@robert-ancell

Add reuse render_sibling to avoid memory leak. to @robert-ancell PR flutter#183539 We observed a memory leak on Linux Desktop with Wayland on embedded ARM cpu and an OpenGL ES driver. While the fix works in our environment, I'm not sure it's correct in all scenarios. Maybe someone with more experience in the Flutter Linux rendering can review and provide some feedback. The memory leak seems related to issue mentioned below. flutter#182192 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Robert Ancell <robert.ancell@canonical.com>

This reverts commit ed5bda4. When running the `examples/multiple_windows` and creating a regular window then closing it causes the content of the main window to stop being updated. The terminal shows: ``` GrGLGpu::flushRenderTargetNoColorWrites glCheckFramebufferStatus 8cd7 ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLGpu.cpp(2271) : Clear(clearMask) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(225) : DrawRangeElements(glPrimType, minIndexValue, maxIndexValue, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex)) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(203) : DrawArrays(glPrimType, baseVertex, vertexCount) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLTexture.cpp(192) : ObjectLabel(0x1702, fID, -1, label.c_str()) ```

@robert-ancell

Add reuse render_sibling to avoid memory leak. to @robert-ancell PR flutter#183539 We observed a memory leak on Linux Desktop with Wayland on embedded ARM cpu and an OpenGL ES driver. While the fix works in our environment, I'm not sure it's correct in all scenarios. Maybe someone with more experience in the Flutter Linux rendering can review and provide some feedback. The memory leak seems related to issue mentioned below. flutter#182192 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Robert Ancell <robert.ancell@canonical.com>

This reverts commit ed5bda4. When running the `examples/multiple_windows` and creating a regular window then closing it causes the content of the main window to stop being updated. The terminal shows: ``` GrGLGpu::flushRenderTargetNoColorWrites glCheckFramebufferStatus 8cd7 ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLGpu.cpp(2271) : Clear(clearMask) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(225) : DrawRangeElements(glPrimType, minIndexValue, maxIndexValue, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex)) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(203) : DrawArrays(glPrimType, baseVertex, vertexCount) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLOpsRenderPass.cpp(216) : DrawElementsInstancedBaseVertexBaseInstance( glPrimType, indexCount, 0x1403, this->offsetForBaseIndex(baseIndex), 1, baseVertex, 0) ---- glGetError 0x506(Unknown) at ../../flutter/third_party/skia/src/gpu/ganesh/gl/GrGLTexture.cpp(192) : ObjectLabel(0x1702, fID, -1, label.c_str()) ```

…r#11281) flutter/flutter@d117642...dd64978 2026-03-18 engine-flutter-autoroll@skia.org Roll Skia from 2fb5fa71eb12 to f0a13e5efbad (2 revisions) (flutter/flutter#183830) 2026-03-18 engine-flutter-autoroll@skia.org Roll Skia from ae3d36cb9e29 to 2fb5fa71eb12 (3 revisions) (flutter/flutter#183823) 2026-03-18 94012149+richardexfo@users.noreply.github.com Linux reuse sibling (flutter/flutter#183653) 2026-03-18 engine-flutter-autoroll@skia.org Roll Skia from 84a180a1fa80 to ae3d36cb9e29 (4 revisions) (flutter/flutter#183812) 2026-03-18 1961493+harryterkelsen@users.noreply.github.com fix(web): handle asynchronously disposed platform views (flutter/flutter#183666) 2026-03-17 87018443+mayanksharma9@users.noreply.github.com (Test cross-imports) Remove legacy Material import from sliver_constraints_test (flutter/flutter#183351) 2026-03-17 74057391+jhonathanqz@users.noreply.github.com Fix Android Studio pluginsPath when version is unknown (do not use 0.0) (flutter/flutter#182681) 2026-03-17 50643541+Mairramer@users.noreply.github.com Fixes animation glitch into bottom sheet (flutter/flutter#183303) 2026-03-17 ahmedsameha1@gmail.com Handle#6537 second grouped test (flutter/flutter#182529) 2026-03-17 ahmedsameha1@gmail.com Add a Clarification for the docs of suggestionsBuilder of SearchAnchor (flutter/flutter#183106) 2026-03-17 nate.w5687@gmail.com Remove obsolete null checks from style guide (flutter/flutter#181703) 2026-03-17 jason-simmons@users.noreply.github.com [Impeller] Do not delete the GL object in a HandleGLES if the handle has a cleanup callback (flutter/flutter#183561) 2026-03-17 jason-simmons@users.noreply.github.com Encode source file patches as UTF-8 in the code formatter script (flutter/flutter#183761) 2026-03-17 82673815+gktirkha@users.noreply.github.com Fix widget inspector control layout and add safe area regression test (flutter/flutter#180789) 2026-03-17 43054281+camsim99@users.noreply.github.com Reland "[Android] Add mechanism for setting Android engine flags via Android manifest (take 2)" (flutter/flutter#182522) 2026-03-17 1961493+harryterkelsen@users.noreply.github.com fix(web): fix crash in Skwasm when transferring non-transferable texture sources (flutter/flutter#183799) 2026-03-17 engine-flutter-autoroll@skia.org Roll Skia from dba893a44d7a to 84a180a1fa80 (7 revisions) (flutter/flutter#183803) 2026-03-17 brunocorona.alcantar@gmail.com Framework: Improve DropdownButton selectedItemBuilder assertion (flutter/flutter#183732) 2026-03-17 brunocorona.alcantar@gmail.com Add mainAxisAlignment to NavigationRail (flutter/flutter#183514) 2026-03-17 34871572+gmackall@users.noreply.github.com Update android triage process to not look at unassigned p1s every week (flutter/flutter#183805) 2026-03-17 30870216+gaaclarke@users.noreply.github.com Adds macos impeller new gallery transition perf test. (flutter/flutter#183802) 2026-03-17 1961493+harryterkelsen@users.noreply.github.com fix(web_ui): move prepareToDraw after raster to improve concurrency and stability (flutter/flutter#183791) 2026-03-17 rmacnak@google.com [build] Generate debug info for assembly. (flutter/flutter#183425) 2026-03-17 mdebbar@google.com [web] Fix occasional failure to find Chrome tab (flutter/flutter#183737) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

robert-ancell and others added 4 commits March 13, 2026 13:59

Wrap EGL image usage in a GObject

6759cf0

This ensures it is destroyed when no object is using it. It was previously leaking. Fixes flutter#182192

Add missing files...

e327092

Add test

3cd38d9

reuse sibling in fl_compositor_opengl.cc

ab7b755

richardexfo requested a review from a team as a code owner March 13, 2026 18:03

github-actions Bot added engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop team-linux Owned by the Linux platform team labels Mar 13, 2026

gemini-code-assist Bot reviewed Mar 13, 2026

View reviewed changes

Comment thread engine/src/flutter/shell/platform/linux/fl_egl_image.cc Outdated

robert-ancell mentioned this pull request Mar 13, 2026

Wrap EGL image usage in a GObject #183539

Merged

robert-ancell added 2 commits March 13, 2026 18:46

Ensure constructor always succeeds

5f705a7

Merge branch 'master' into linux-reuse-sibling

dbc32f3

robert-ancell added the CICD Run CI/CD label Mar 17, 2026

Reset render_sibling every time.

e8833ea

github-actions Bot removed the CICD Run CI/CD label Mar 17, 2026

Merge branch 'master' into linux-reuse-sibling

e436169

robert-ancell approved these changes Mar 18, 2026

View reviewed changes

robert-ancell enabled auto-merge March 18, 2026 03:52

robert-ancell added the CICD Run CI/CD label Mar 18, 2026

robert-ancell added this pull request to the merge queue Mar 18, 2026

Merged via the queue into flutter:master with commit ed5bda4 Mar 18, 2026
187 checks passed

richardexfo deleted the linux-reuse-sibling branch March 18, 2026 13:57

engine-flutter-autoroll mentioned this pull request Mar 18, 2026

Roll Flutter from d117642c18e0 to dd64978dfae1 (24 revisions) flutter/packages#11281

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2026

ed5bda45a Linux reuse sibling (flutter/flutter#183653)

75228e9

engine-flutter-autoroll mentioned this pull request Mar 18, 2026

Roll Flutter from d117642c18e0 to e6ed6e9e1678 (25 revisions) flutter/packages#11282

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2026

ed5bda45a Linux reuse sibling (flutter/flutter#183653)

7288a3b

engine-flutter-autoroll mentioned this pull request Mar 18, 2026

Roll Flutter from d117642c18e0 to 7189eb4d128c (26 revisions) flutter/packages#11284

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2026

ed5bda45a Linux reuse sibling (flutter/flutter#183653)

8b96a4f

engine-flutter-autoroll mentioned this pull request Mar 18, 2026

Roll Flutter from d117642c18e0 to 6df82a9ec022 (27 revisions) flutter/packages#11286

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2026

ed5bda45a Linux reuse sibling (flutter/flutter#183653)

11e0e36

engine-flutter-autoroll mentioned this pull request Mar 18, 2026

Roll Flutter from d117642c18e0 to 73d6bccaf322 (30 revisions) flutter/packages#11288

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2026

ed5bda45a Linux reuse sibling (flutter/flutter#183653)

dd0f1f6

engine-flutter-autoroll mentioned this pull request Mar 18, 2026

Roll Flutter from d117642c18e0 to c0aee3b4ca7d (31 revisions) flutter/packages#11289

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2026

ed5bda45a Linux reuse sibling (flutter/flutter#183653)

d70573a

robert-ancell added a commit to robert-ancell/flutter that referenced this pull request Mar 19, 2026

Revert "Linux reuse sibling (flutter#183653)"

4473889

This reverts commit ed5bda4.

robert-ancell added a commit to robert-ancell/flutter that referenced this pull request Mar 19, 2026

Revert "Linux reuse sibling (flutter#183653)"

0f6c272

This reverts commit ed5bda4.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Linux reuse sibling#183653

Linux reuse sibling#183653
robert-ancell merged 8 commits into
flutter:masterfrom
richardexfo:linux-reuse-sibling

richardexfo commented Mar 13, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

robert-ancell commented Mar 17, 2026

Uh oh!

richardexfo commented Mar 17, 2026

Uh oh!

robert-ancell commented Mar 18, 2026

Uh oh!

Uh oh!

robert-ancell commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

richardexfo commented Mar 13, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

robert-ancell commented Mar 17, 2026

Uh oh!

richardexfo commented Mar 17, 2026

Uh oh!

robert-ancell commented Mar 18, 2026

Uh oh!

Uh oh!

robert-ancell commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants