Linux reuse sibling (#183653)

richardexfo · robert-ancell · web-flow · commit ed5bda45a93f · 2026-03-18T05:39:38.000Z
Add reuse render_sibling to avoid memory leak. to @robert-ancell PR #183539 We observed a memory leak on Linux Desktop with Wayland on embedded ARM cpu and an OpenGL ES driver. While the fix works in our environment, I'm not sure it's correct in all scenarios. Maybe someone with more experience in the Flutter Linux rendering can review and provide some feedback. The memory leak seems related to issue mentioned below. #182192 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Robert Ancell <robert.ancell@canonical.com>
diff --git a/engine/src/flutter/shell/platform/linux/fl_compositor_opengl.cc b/engine/src/flutter/shell/platform/linux/fl_compositor_opengl.cc
@@ -53,6 +53,10 @@ struct _FlCompositorOpenGL {
   // Last rendered frame.
   FlFramebuffer* framebuffer;
 
+  // Reusable sibling framebuffer for gdk_cairo_draw_from_gl (Wayland).
+  // Avoids per-frame texture churn that GTK/Wayland retains.
+  FlFramebuffer* render_sibling;
+
   // Last rendered frame pixels (only set if shareable is TRUE).
   uint8_t* pixels;
 
@@ -251,9 +255,12 @@ static gboolean fl_compositor_opengl_present_layers(FlCompositor* compositor,
   if (self->framebuffer == nullptr ||
       fl_framebuffer_get_width(self->framebuffer) != width ||
       fl_framebuffer_get_height(self->framebuffer) != height) {
-    g_clear_object(&self->framebuffer);
-    self->framebuffer =
+    // Allocate new framebuffer before disposing old ones to avoid GL texture
+    // ID collision (engine may dispose backing stores later with recycled IDs).
+    FlFramebuffer* new_framebuffer =
         fl_framebuffer_new(general_format, width, height, self->shareable);
+    g_clear_object(&self->framebuffer);
+    self->framebuffer = new_framebuffer;
 
     // If not shareable make buffer to copy frame pixels into.
     if (!self->shareable) {
@@ -423,9 +430,10 @@ static gboolean fl_compositor_opengl_render(FlCompositor* compositor,
   }
 
   if (fl_framebuffer_get_shareable(self->framebuffer)) {
-    g_autoptr(FlFramebuffer) sibling =
-        fl_framebuffer_create_sibling(self->framebuffer);
-    gdk_cairo_draw_from_gl(cr, window, fl_framebuffer_get_texture_id(sibling),
+    g_clear_object(&self->render_sibling);
+    self->render_sibling = fl_framebuffer_create_sibling(self->framebuffer);
+    gdk_cairo_draw_from_gl(cr, window,
+                           fl_framebuffer_get_texture_id(self->render_sibling),
                            GL_TEXTURE, scale_factor, 0, 0, width, height);
   } else {
     GLint saved_texture_binding;
@@ -459,6 +467,7 @@ static void fl_compositor_opengl_dispose(GObject* object) {
 
   g_clear_object(&self->task_runner);
   g_clear_object(&self->opengl_manager);
+  g_clear_object(&self->render_sibling);
   g_clear_object(&self->framebuffer);
   g_clear_pointer(&self->pixels, g_free);
   g_mutex_clear(&self->frame_mutex);
