refactor: remove material import from sliver_resizing_header_test and sliver_prototype_item_extent_test by rkishan516 · Pull Request #183562 · flutter/flutter

rkishan516 · 2026-03-12T02:50:35Z

This PR removes Material imports from sliver_resizing_header_test and sliver_prototype_item_extent_test.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

gemini-code-assist

Code Review

This pull request refactors two test files, sliver_resizing_header_test.dart and sliver_prototype_item_extent_test.dart, to remove dependencies on the Material library by replacing MaterialApp and Scaffold with TestWidgetsApp. The check_tests_cross_imports.dart script is updated to remove sliver_resizing_header_test.dart from the allowlist, but an equivalent removal for sliver_prototype_item_extent_test.dart is missing, which will likely cause CI failure.

navaronbracke

LGTM, with nit

navaronbracke · 2026-03-12T07:06:02Z

+          slivers: <Widget>[
+            SliverPrototypeExtentList.list(
+              prototypeItem: const TestItem(item: -1, height: 100.0),
+              children: <int>[


Can we use https://api.flutter.dev/flutter/widgets/SliverPrototypeExtentList/SliverPrototypeExtentList.builder.html

similar to the other tests in this PR? That makes it a little easier to read :)

Suggested change

children: <int>[

SliverPrototypeExtentList.builder(

prototypeItem: const TestItem(item: -1, height: 100.0),

itemCount: 8,

itemBuilder: (BuildContext context, int index) => TestItem(item: index),

)

Sure, updating.

… sliver_prototype_item_extent_test

justinmc

LGTM 👍

justinmc · 2026-03-12T17:46:19Z

+              itemBuilder: (BuildContext context, int index) => TestItem(item: index),
+              itemCount: 8,


Good call refactoring this as well.

victorsanni

LGTM

…r_test and sliver_prototype_item_extent_test (flutter/flutter#183562)

flutter/flutter@9e36adb...732e05d 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from 330b797abd09 to d5f6d3c17499 (1 revision) (flutter/flutter#183640) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9eb5598e1b2c to 029229d8be91 (3 revisions) (flutter/flutter#183638) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9be8fdf31ff4 to 9eb5598e1b2c (2 revisions) (flutter/flutter#183630) 2026-03-13 victorsanniay@gmail.com Add awaits to flutter/test callsites (flutter/flutter#183487) 2026-03-13 victorsanniay@gmail.com Add await to more flutter/flutter callsites (flutter/flutter#183413) 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d1d84ab7ef0d to 330b797abd09 (2 revisions) (flutter/flutter#183624) 2026-03-13 34465683+rkishan516@users.noreply.github.com refactor: remove material import from sliver_resizing_header_test and sliver_prototype_item_extent_test (flutter/flutter#183562) 2026-03-13 36861262+QuncCccccc@users.noreply.github.com Fix reselection issue after the text is cleared (flutter/flutter#183545) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 255bd243276b to 9be8fdf31ff4 (5 revisions) (flutter/flutter#183616) 2026-03-12 git@reb0.org ci: Remove `bringup` from orchestrator for windows_arm_host_engine on Linux (flutter/flutter#183574) 2026-03-12 chingjun@google.com Use operator<=> instead of std::less for UniqueID. (flutter/flutter#183600) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Specified the repo the cp label will be removed from (flutter/flutter#183611) 2026-03-12 1961493+harryterkelsen@users.noreply.github.com [web] Fix Web SDK build on macOS (flutter/flutter#183549) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 38761e1803d0 to 255bd243276b (3 revisions) (flutter/flutter#183603) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 2e1e7a09fce6 to d1d84ab7ef0d (1 revision) (flutter/flutter#183604) 2026-03-12 15619084+vashworth@users.noreply.github.com Fix macOS relative plugin Xcode file path (flutter/flutter#183593) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Made cp labels get rejected on issues. (flutter/flutter#183595) 2026-03-12 engine-flutter-autoroll@skia.org Roll Packages from ecace66 to 02f231f (4 revisions) (flutter/flutter#183594) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 59be21f25f2d to 2e1e7a09fce6 (1 revision) (flutter/flutter#183577) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 46f41493ebf4 to 38761e1803d0 (6 revisions) (flutter/flutter#183590) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#11242) flutter/flutter@9e36adb...732e05d 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from 330b797abd09 to d5f6d3c17499 (1 revision) (flutter/flutter#183640) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9eb5598e1b2c to 029229d8be91 (3 revisions) (flutter/flutter#183638) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9be8fdf31ff4 to 9eb5598e1b2c (2 revisions) (flutter/flutter#183630) 2026-03-13 victorsanniay@gmail.com Add awaits to flutter/test callsites (flutter/flutter#183487) 2026-03-13 victorsanniay@gmail.com Add await to more flutter/flutter callsites (flutter/flutter#183413) 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d1d84ab7ef0d to 330b797abd09 (2 revisions) (flutter/flutter#183624) 2026-03-13 34465683+rkishan516@users.noreply.github.com refactor: remove material import from sliver_resizing_header_test and sliver_prototype_item_extent_test (flutter/flutter#183562) 2026-03-13 36861262+QuncCccccc@users.noreply.github.com Fix reselection issue after the text is cleared (flutter/flutter#183545) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 255bd243276b to 9be8fdf31ff4 (5 revisions) (flutter/flutter#183616) 2026-03-12 git@reb0.org ci: Remove `bringup` from orchestrator for windows_arm_host_engine on Linux (flutter/flutter#183574) 2026-03-12 chingjun@google.com Use operator<=> instead of std::less for UniqueID. (flutter/flutter#183600) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Specified the repo the cp label will be removed from (flutter/flutter#183611) 2026-03-12 1961493+harryterkelsen@users.noreply.github.com [web] Fix Web SDK build on macOS (flutter/flutter#183549) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 38761e1803d0 to 255bd243276b (3 revisions) (flutter/flutter#183603) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 2e1e7a09fce6 to d1d84ab7ef0d (1 revision) (flutter/flutter#183604) 2026-03-12 15619084+vashworth@users.noreply.github.com Fix macOS relative plugin Xcode file path (flutter/flutter#183593) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Made cp labels get rejected on issues. (flutter/flutter#183595) 2026-03-12 engine-flutter-autoroll@skia.org Roll Packages from ecace66 to 02f231f (4 revisions) (flutter/flutter#183594) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 59be21f25f2d to 2e1e7a09fce6 (1 revision) (flutter/flutter#183577) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 46f41493ebf4 to 38761e1803d0 (6 revisions) (flutter/flutter#183590) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

… sliver_prototype_item_extent_test (flutter#183562) This PR removes Material imports from sliver_resizing_header_test and sliver_prototype_item_extent_test. part of: flutter#177415 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…r#11242) flutter/flutter@9e36adb...732e05d 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from 330b797abd09 to d5f6d3c17499 (1 revision) (flutter/flutter#183640) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9eb5598e1b2c to 029229d8be91 (3 revisions) (flutter/flutter#183638) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9be8fdf31ff4 to 9eb5598e1b2c (2 revisions) (flutter/flutter#183630) 2026-03-13 victorsanniay@gmail.com Add awaits to flutter/test callsites (flutter/flutter#183487) 2026-03-13 victorsanniay@gmail.com Add await to more flutter/flutter callsites (flutter/flutter#183413) 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d1d84ab7ef0d to 330b797abd09 (2 revisions) (flutter/flutter#183624) 2026-03-13 34465683+rkishan516@users.noreply.github.com refactor: remove material import from sliver_resizing_header_test and sliver_prototype_item_extent_test (flutter/flutter#183562) 2026-03-13 36861262+QuncCccccc@users.noreply.github.com Fix reselection issue after the text is cleared (flutter/flutter#183545) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 255bd243276b to 9be8fdf31ff4 (5 revisions) (flutter/flutter#183616) 2026-03-12 git@reb0.org ci: Remove `bringup` from orchestrator for windows_arm_host_engine on Linux (flutter/flutter#183574) 2026-03-12 chingjun@google.com Use operator<=> instead of std::less for UniqueID. (flutter/flutter#183600) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Specified the repo the cp label will be removed from (flutter/flutter#183611) 2026-03-12 1961493+harryterkelsen@users.noreply.github.com [web] Fix Web SDK build on macOS (flutter/flutter#183549) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 38761e1803d0 to 255bd243276b (3 revisions) (flutter/flutter#183603) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 2e1e7a09fce6 to d1d84ab7ef0d (1 revision) (flutter/flutter#183604) 2026-03-12 15619084+vashworth@users.noreply.github.com Fix macOS relative plugin Xcode file path (flutter/flutter#183593) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Made cp labels get rejected on issues. (flutter/flutter#183595) 2026-03-12 engine-flutter-autoroll@skia.org Roll Packages from ecace66 to 02f231f (4 revisions) (flutter/flutter#183594) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 59be21f25f2d to 2e1e7a09fce6 (1 revision) (flutter/flutter#183577) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 46f41493ebf4 to 38761e1803d0 (6 revisions) (flutter/flutter#183590) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

rkishan516 requested review from justinmc and victorsanni March 12, 2026 02:50

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Mar 12, 2026

gemini-code-assist Bot reviewed Mar 12, 2026

View reviewed changes

Comment thread dev/bots/check_tests_cross_imports.dart

rkishan516 mentioned this pull request Mar 12, 2026

(Test cross-imports) Don't import Material in tests for convenience #177415

Open

rkishan516 force-pushed the simple-cross-imports-1 branch from a94a516 to 0d4589e Compare March 12, 2026 03:29

rkishan516 added this to Test cross-imports Review Queue Mar 12, 2026

github-project-automation Bot moved this to Todo in Test cross-imports Review Queue Mar 12, 2026

rkishan516 moved this from Todo to In Progress in Test cross-imports Review Queue Mar 12, 2026

navaronbracke previously approved these changes Mar 12, 2026

View reviewed changes

refactor: remove material import from sliver_resizing_header_test and…

1d7bfc2

… sliver_prototype_item_extent_test

rkishan516 force-pushed the simple-cross-imports-1 branch from 0d4589e to 1d7bfc2 Compare March 12, 2026 14:02

justinmc approved these changes Mar 12, 2026

View reviewed changes

justinmc added the CICD Run CI/CD label Mar 12, 2026

rkishan516 dismissed navaronbracke’s stale review via 1d7bfc2 March 12, 2026 22:21

victorsanni approved these changes Mar 12, 2026

View reviewed changes

rkishan516 added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2026

auto-submit Bot added this pull request to the merge queue Mar 13, 2026

Merged via the queue into flutter:master with commit 1e9bb43 Mar 13, 2026
156 checks passed

github-project-automation Bot moved this from In Progress to Done in Test cross-imports Review Queue Mar 13, 2026

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2026

engine-flutter-autoroll mentioned this pull request Mar 13, 2026

Roll Flutter from 9e36adba5069 to 732e05dd483c (20 revisions) flutter/packages#11242

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2026

1e9bb434c refactor: remove material import from sliver_resizing_heade…

ac4c58a

…r_test and sliver_prototype_item_extent_test (flutter/flutter#183562)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2026

1e9bb434c refactor: remove material import from sliver_resizing_heade…

12d18a0

…r_test and sliver_prototype_item_extent_test (flutter/flutter#183562)

engine-flutter-autoroll mentioned this pull request Mar 13, 2026

Roll Flutter from 9e36adba5069 to cc7d8fb66d5a (22 revisions) flutter/packages#11243

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2026

1e9bb434c refactor: remove material import from sliver_resizing_heade…

987a88d

…r_test and sliver_prototype_item_extent_test (flutter/flutter#183562)

engine-flutter-autoroll mentioned this pull request Mar 13, 2026

Roll Flutter from 9e36adba5069 to 91b322419d84 (25 revisions) flutter/packages#11244

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2026

1e9bb434c refactor: remove material import from sliver_resizing_heade…

cc09243

…r_test and sliver_prototype_item_extent_test (flutter/flutter#183562)

engine-flutter-autoroll mentioned this pull request Mar 14, 2026

Roll Flutter from 9e36adba5069 to a96f2738be69 (37 revisions) flutter/packages#11245

Closed

rkishan516 deleted the simple-cross-imports-1 branch April 8, 2026 15:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: remove material import from sliver_resizing_header_test and sliver_prototype_item_extent_test#183562

refactor: remove material import from sliver_resizing_header_test and sliver_prototype_item_extent_test#183562
auto-submit[bot] merged 1 commit into
flutter:masterfrom
rkishan516:simple-cross-imports-1

rkishan516 commented Mar 12, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

navaronbracke left a comment

Uh oh!

navaronbracke Mar 12, 2026 •

edited

Loading

Uh oh!

rkishan516 Mar 12, 2026

Uh oh!

justinmc left a comment

Uh oh!

justinmc Mar 12, 2026

Uh oh!

victorsanni left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		itemBuilder: (BuildContext context, int index) => TestItem(item: index),
		itemCount: 8,

Uh oh!

Conversation

rkishan516 commented Mar 12, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

navaronbracke left a comment

Choose a reason for hiding this comment

Uh oh!

navaronbracke Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rkishan516 Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

navaronbracke Mar 12, 2026 •

edited

Loading