Add awaits to flutter/test callsites#183487
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds await to several test call sites where functions now return a Future. This is a necessary change to ensure tests behave correctly. The changes also include some refactoring in widget_inspector_test.dart to use standard widgets and color constants, which improves readability. I've found one instance where a test was modified in a way that makes it no longer correctly test an asynchronous operation, and I've left a comment with a suggestion to fix it.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/flutter/test/widgets/widget_inspector_test.dart (5185-5189)
Since service.testExtension is now an async method, using expect(..., returnsNormally) will not correctly test the asynchronous operation. The test will pass vacuously because it's not awaiting the Future. You should use await expectLater(..., completes) to ensure the Future completes without an error.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 13, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 14, 2026
flutter/flutter@9e36adb...732e05d 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from 330b797abd09 to d5f6d3c17499 (1 revision) (flutter/flutter#183640) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9eb5598e1b2c to 029229d8be91 (3 revisions) (flutter/flutter#183638) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9be8fdf31ff4 to 9eb5598e1b2c (2 revisions) (flutter/flutter#183630) 2026-03-13 victorsanniay@gmail.com Add awaits to flutter/test callsites (flutter/flutter#183487) 2026-03-13 victorsanniay@gmail.com Add await to more flutter/flutter callsites (flutter/flutter#183413) 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d1d84ab7ef0d to 330b797abd09 (2 revisions) (flutter/flutter#183624) 2026-03-13 34465683+rkishan516@users.noreply.github.com refactor: remove material import from sliver_resizing_header_test and sliver_prototype_item_extent_test (flutter/flutter#183562) 2026-03-13 36861262+QuncCccccc@users.noreply.github.com Fix reselection issue after the text is cleared (flutter/flutter#183545) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 255bd243276b to 9be8fdf31ff4 (5 revisions) (flutter/flutter#183616) 2026-03-12 git@reb0.org ci: Remove `bringup` from orchestrator for windows_arm_host_engine on Linux (flutter/flutter#183574) 2026-03-12 chingjun@google.com Use operator<=> instead of std::less for UniqueID. (flutter/flutter#183600) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Specified the repo the cp label will be removed from (flutter/flutter#183611) 2026-03-12 1961493+harryterkelsen@users.noreply.github.com [web] Fix Web SDK build on macOS (flutter/flutter#183549) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 38761e1803d0 to 255bd243276b (3 revisions) (flutter/flutter#183603) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 2e1e7a09fce6 to d1d84ab7ef0d (1 revision) (flutter/flutter#183604) 2026-03-12 15619084+vashworth@users.noreply.github.com Fix macOS relative plugin Xcode file path (flutter/flutter#183593) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Made cp labels get rejected on issues. (flutter/flutter#183595) 2026-03-12 engine-flutter-autoroll@skia.org Roll Packages from ecace66 to 02f231f (4 revisions) (flutter/flutter#183594) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 59be21f25f2d to 2e1e7a09fce6 (1 revision) (flutter/flutter#183577) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 46f41493ebf4 to 38761e1803d0 (6 revisions) (flutter/flutter#183590) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nateshmbhat
pushed a commit
to nateshmbhat/flutter_packages
that referenced
this pull request
Mar 25, 2026
…r#11242) flutter/flutter@9e36adb...732e05d 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from 330b797abd09 to d5f6d3c17499 (1 revision) (flutter/flutter#183640) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9eb5598e1b2c to 029229d8be91 (3 revisions) (flutter/flutter#183638) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9be8fdf31ff4 to 9eb5598e1b2c (2 revisions) (flutter/flutter#183630) 2026-03-13 victorsanniay@gmail.com Add awaits to flutter/test callsites (flutter/flutter#183487) 2026-03-13 victorsanniay@gmail.com Add await to more flutter/flutter callsites (flutter/flutter#183413) 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d1d84ab7ef0d to 330b797abd09 (2 revisions) (flutter/flutter#183624) 2026-03-13 34465683+rkishan516@users.noreply.github.com refactor: remove material import from sliver_resizing_header_test and sliver_prototype_item_extent_test (flutter/flutter#183562) 2026-03-13 36861262+QuncCccccc@users.noreply.github.com Fix reselection issue after the text is cleared (flutter/flutter#183545) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 255bd243276b to 9be8fdf31ff4 (5 revisions) (flutter/flutter#183616) 2026-03-12 git@reb0.org ci: Remove `bringup` from orchestrator for windows_arm_host_engine on Linux (flutter/flutter#183574) 2026-03-12 chingjun@google.com Use operator<=> instead of std::less for UniqueID. (flutter/flutter#183600) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Specified the repo the cp label will be removed from (flutter/flutter#183611) 2026-03-12 1961493+harryterkelsen@users.noreply.github.com [web] Fix Web SDK build on macOS (flutter/flutter#183549) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 38761e1803d0 to 255bd243276b (3 revisions) (flutter/flutter#183603) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 2e1e7a09fce6 to d1d84ab7ef0d (1 revision) (flutter/flutter#183604) 2026-03-12 15619084+vashworth@users.noreply.github.com Fix macOS relative plugin Xcode file path (flutter/flutter#183593) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Made cp labels get rejected on issues. (flutter/flutter#183595) 2026-03-12 engine-flutter-autoroll@skia.org Roll Packages from ecace66 to 02f231f (4 revisions) (flutter/flutter#183594) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 59be21f25f2d to 2e1e7a09fce6 (1 revision) (flutter/flutter#183577) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 46f41493ebf4 to 38761e1803d0 (6 revisions) (flutter/flutter#183590) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah
pushed a commit
to okorohelijah/packages
that referenced
this pull request
Mar 26, 2026
…r#11242) flutter/flutter@9e36adb...732e05d 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from 330b797abd09 to d5f6d3c17499 (1 revision) (flutter/flutter#183640) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9eb5598e1b2c to 029229d8be91 (3 revisions) (flutter/flutter#183638) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9be8fdf31ff4 to 9eb5598e1b2c (2 revisions) (flutter/flutter#183630) 2026-03-13 victorsanniay@gmail.com Add awaits to flutter/test callsites (flutter/flutter#183487) 2026-03-13 victorsanniay@gmail.com Add await to more flutter/flutter callsites (flutter/flutter#183413) 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d1d84ab7ef0d to 330b797abd09 (2 revisions) (flutter/flutter#183624) 2026-03-13 34465683+rkishan516@users.noreply.github.com refactor: remove material import from sliver_resizing_header_test and sliver_prototype_item_extent_test (flutter/flutter#183562) 2026-03-13 36861262+QuncCccccc@users.noreply.github.com Fix reselection issue after the text is cleared (flutter/flutter#183545) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 255bd243276b to 9be8fdf31ff4 (5 revisions) (flutter/flutter#183616) 2026-03-12 git@reb0.org ci: Remove `bringup` from orchestrator for windows_arm_host_engine on Linux (flutter/flutter#183574) 2026-03-12 chingjun@google.com Use operator<=> instead of std::less for UniqueID. (flutter/flutter#183600) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Specified the repo the cp label will be removed from (flutter/flutter#183611) 2026-03-12 1961493+harryterkelsen@users.noreply.github.com [web] Fix Web SDK build on macOS (flutter/flutter#183549) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 38761e1803d0 to 255bd243276b (3 revisions) (flutter/flutter#183603) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 2e1e7a09fce6 to d1d84ab7ef0d (1 revision) (flutter/flutter#183604) 2026-03-12 15619084+vashworth@users.noreply.github.com Fix macOS relative plugin Xcode file path (flutter/flutter#183593) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Made cp labels get rejected on issues. (flutter/flutter#183595) 2026-03-12 engine-flutter-autoroll@skia.org Roll Packages from ecace66 to 02f231f (4 revisions) (flutter/flutter#183594) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 59be21f25f2d to 2e1e7a09fce6 (1 revision) (flutter/flutter#183577) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 46f41493ebf4 to 38761e1803d0 (6 revisions) (flutter/flutter#183590) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Mar 26, 2026
Part of [Add @awaitNotRequired annotation to flutter sdk](flutter#181513)
10 tasks
ahmedsameha1
pushed a commit
to ahmedsameha1/flutter
that referenced
this pull request
Apr 14, 2026
Part of [Add @awaitNotRequired annotation to flutter sdk](flutter#181513)
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#11242) flutter/flutter@9e36adb...732e05d 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from 330b797abd09 to d5f6d3c17499 (1 revision) (flutter/flutter#183640) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9eb5598e1b2c to 029229d8be91 (3 revisions) (flutter/flutter#183638) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 9be8fdf31ff4 to 9eb5598e1b2c (2 revisions) (flutter/flutter#183630) 2026-03-13 victorsanniay@gmail.com Add awaits to flutter/test callsites (flutter/flutter#183487) 2026-03-13 victorsanniay@gmail.com Add await to more flutter/flutter callsites (flutter/flutter#183413) 2026-03-13 engine-flutter-autoroll@skia.org Roll Dart SDK from d1d84ab7ef0d to 330b797abd09 (2 revisions) (flutter/flutter#183624) 2026-03-13 34465683+rkishan516@users.noreply.github.com refactor: remove material import from sliver_resizing_header_test and sliver_prototype_item_extent_test (flutter/flutter#183562) 2026-03-13 36861262+QuncCccccc@users.noreply.github.com Fix reselection issue after the text is cleared (flutter/flutter#183545) 2026-03-13 engine-flutter-autoroll@skia.org Roll Skia from 255bd243276b to 9be8fdf31ff4 (5 revisions) (flutter/flutter#183616) 2026-03-12 git@reb0.org ci: Remove `bringup` from orchestrator for windows_arm_host_engine on Linux (flutter/flutter#183574) 2026-03-12 chingjun@google.com Use operator<=> instead of std::less for UniqueID. (flutter/flutter#183600) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Specified the repo the cp label will be removed from (flutter/flutter#183611) 2026-03-12 1961493+harryterkelsen@users.noreply.github.com [web] Fix Web SDK build on macOS (flutter/flutter#183549) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 38761e1803d0 to 255bd243276b (3 revisions) (flutter/flutter#183603) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 2e1e7a09fce6 to d1d84ab7ef0d (1 revision) (flutter/flutter#183604) 2026-03-12 15619084+vashworth@users.noreply.github.com Fix macOS relative plugin Xcode file path (flutter/flutter#183593) 2026-03-12 30870216+gaaclarke@users.noreply.github.com Made cp labels get rejected on issues. (flutter/flutter#183595) 2026-03-12 engine-flutter-autoroll@skia.org Roll Packages from ecace66 to 02f231f (4 revisions) (flutter/flutter#183594) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 59be21f25f2d to 2e1e7a09fce6 (1 revision) (flutter/flutter#183577) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 46f41493ebf4 to 38761e1803d0 (6 revisions) (flutter/flutter#183590) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Add @awaitNotRequired annotation to flutter sdk