Standardize review timeline guidance#183465
Merged
auto-submit[bot] merged 6 commits intoMar 11, 2026
Merged
Conversation
Currently on the same page we say to ping people: - After two weeks (in When) (and the tl;dr). - After one week (in Who). - Immediately, in step 7 of the PR process overview. This makes it hard for new contributors to understand what the actual expectation is, and in practice the step 7 version creates behavior we don't want (immediately pinging people, usually the wrong ones, instead of waiting for the normal triage process). This standardizes everything on two weeks.
Contributor
There was a problem hiding this comment.
Code Review
This pull request standardizes the review timeline guidance in docs/contributing/Tree-hygiene.md to two weeks, resolving inconsistencies across the document. The changes align the instructions for when to ping for a review. I've found a minor typo in the updated text that should be corrected.
Note: Security Review has been skipped due to the limited scope of the PR.
Piinks
reviewed
Mar 11, 2026
| that's probably a good place to start. | ||
| 7. Get your code reviewed (see below). If you are a team member, request review | ||
| from the relevant expert(s) for the areas you touched. Otherwise, wait for | ||
| [reviewers to be assigned](#who). |
Contributor
There was a problem hiding this comment.
I noticed something strange under #who about material and cupertino PRs not being assigned. Which is weird. I've asked around if anyone recalls why. I can put up a PR to remove it, unless you want to add it to this PR?
Contributor
Author
There was a problem hiding this comment.
I've asked around if anyone recalls why.
Ian added it on August 14th, 2023. Discord spelunking turned up this discussion. The key part is this comment from Hans:
Most Material (and Cupertino) and framework contributions from the community are assigned a reviewer within a week and should get the reviewer's attention as needed. It's assumed that engineers on Flutter team who need reviewers will advocate for themselves
If that's outdated I can remove it here.
Contributor
There was a problem hiding this comment.
Impressive! Thanks for finding that. I think it's outdated. Let's remove it.
Contributor
Author
There was a problem hiding this comment.
Done. I left this more general text here though, since I think having team members request review is still generally the right guidance.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 12, 2026
flutter/flutter@3f400d7...9e36adb 2026-03-12 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QD887D4OanteB7UKM... to jJbpv4J_tjW-wuKDq... (flutter/flutter#183584) 2026-03-12 matt.kosarek@canonical.com Adding the SatelliteWindowController interface to `_window.dart` (flutter/flutter#182903) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 0cab3e4ee34b to 46f41493ebf4 (17 revisions) (flutter/flutter#183553) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 8531f7c2bdae to 59be21f25f2d (4 revisions) (flutter/flutter#183547) 2026-03-12 koji.wakamiya@gmail.com [ios][engine] Fix keyboard flicker when switching text fields (flutter/flutter#182661) 2026-03-11 34871572+gmackall@users.noreply.github.com Rename hcpp opt in flag to `enable-hcpp` (flutter/flutter#183151) 2026-03-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183541) 2026-03-11 97480502+b-luk@users.noreply.github.com Re-enable gpu_test.dart for opengles, but disable specific tests in the file (flutter/flutter#183531) 2026-03-11 jacksongardner@google.com Use CLA-approved email and username for github workflow commits. (flutter/flutter#183540) 2026-03-11 okorohelijah@google.com [integration_test]UIScene Migration (flutter/flutter#182631) 2026-03-11 git@reb0.org ci: Run orchestrator for windows_arm_host_engine on Linux (flutter/flutter#181075) 2026-03-11 mdebbar@google.com [web] Prevent Firefox auto-updates (flutter/flutter#183330) 2026-03-11 koji.wakamiya@gmail.com Add scrollCacheExtent to PageView (flutter/flutter#180411) 2026-03-11 danny@tuppeny.com Remove redundant VS Code code/tests (flutter/flutter#183506) 2026-03-11 danny@tuppeny.com Roll pub packages (flutter/flutter#183527) 2026-03-11 34871572+gmackall@users.noreply.github.com Reapply "Make HCPP upgrading work for vd/tlhc (#181024)" (#183310) (flutter/flutter#183360) 2026-03-11 victorsanniay@gmail.com Add awaits to dev/ callsites (flutter/flutter#183479) 2026-03-11 stuartmorgan@google.com Standardize review timeline guidance (flutter/flutter#183465) 2026-03-11 chingjun@google.com Rename ExecutionModelToString to ExecutionModelToStringName. (flutter/flutter#183461) 2026-03-11 34871572+gmackall@users.noreply.github.com Fix input mirroring in platform views when system language is RTL, and support is set in manifest. (flutter/flutter#183472) 2026-03-11 engine-flutter-autoroll@skia.org Roll Packages from ee460d6 to ecace66 (10 revisions) (flutter/flutter#183517) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah
pushed a commit
to okorohelijah/packages
that referenced
this pull request
Mar 26, 2026
…r#11233) flutter/flutter@3f400d7...9e36adb 2026-03-12 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QD887D4OanteB7UKM... to jJbpv4J_tjW-wuKDq... (flutter/flutter#183584) 2026-03-12 matt.kosarek@canonical.com Adding the SatelliteWindowController interface to `_window.dart` (flutter/flutter#182903) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 0cab3e4ee34b to 46f41493ebf4 (17 revisions) (flutter/flutter#183553) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 8531f7c2bdae to 59be21f25f2d (4 revisions) (flutter/flutter#183547) 2026-03-12 koji.wakamiya@gmail.com [ios][engine] Fix keyboard flicker when switching text fields (flutter/flutter#182661) 2026-03-11 34871572+gmackall@users.noreply.github.com Rename hcpp opt in flag to `enable-hcpp` (flutter/flutter#183151) 2026-03-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183541) 2026-03-11 97480502+b-luk@users.noreply.github.com Re-enable gpu_test.dart for opengles, but disable specific tests in the file (flutter/flutter#183531) 2026-03-11 jacksongardner@google.com Use CLA-approved email and username for github workflow commits. (flutter/flutter#183540) 2026-03-11 okorohelijah@google.com [integration_test]UIScene Migration (flutter/flutter#182631) 2026-03-11 git@reb0.org ci: Run orchestrator for windows_arm_host_engine on Linux (flutter/flutter#181075) 2026-03-11 mdebbar@google.com [web] Prevent Firefox auto-updates (flutter/flutter#183330) 2026-03-11 koji.wakamiya@gmail.com Add scrollCacheExtent to PageView (flutter/flutter#180411) 2026-03-11 danny@tuppeny.com Remove redundant VS Code code/tests (flutter/flutter#183506) 2026-03-11 danny@tuppeny.com Roll pub packages (flutter/flutter#183527) 2026-03-11 34871572+gmackall@users.noreply.github.com Reapply "Make HCPP upgrading work for vd/tlhc (#181024)" (#183310) (flutter/flutter#183360) 2026-03-11 victorsanniay@gmail.com Add awaits to dev/ callsites (flutter/flutter#183479) 2026-03-11 stuartmorgan@google.com Standardize review timeline guidance (flutter/flutter#183465) 2026-03-11 chingjun@google.com Rename ExecutionModelToString to ExecutionModelToStringName. (flutter/flutter#183461) 2026-03-11 34871572+gmackall@users.noreply.github.com Fix input mirroring in platform views when system language is RTL, and support is set in manifest. (flutter/flutter#183472) 2026-03-11 engine-flutter-autoroll@skia.org Roll Packages from ee460d6 to ecace66 (10 revisions) (flutter/flutter#183517) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Mar 26, 2026
Currently on the same page we say to ping people: - After two weeks (in When) (and the tl;dr). - After one week (in Who). - Immediately, in step 7 of the PR process overview. This makes it hard for new contributors to understand what the actual expectation is, and in practice the step 7 version creates behavior we don't want (immediately pinging people, usually the wrong ones, instead of waiting for the normal triage process). This standardizes everything on two weeks. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ahmedsameha1
pushed a commit
to ahmedsameha1/flutter
that referenced
this pull request
Apr 14, 2026
Currently on the same page we say to ping people: - After two weeks (in When) (and the tl;dr). - After one week (in Who). - Immediately, in step 7 of the PR process overview. This makes it hard for new contributors to understand what the actual expectation is, and in practice the step 7 version creates behavior we don't want (immediately pinging people, usually the wrong ones, instead of waiting for the normal triage process). This standardizes everything on two weeks. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#11233) flutter/flutter@3f400d7...9e36adb 2026-03-12 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QD887D4OanteB7UKM... to jJbpv4J_tjW-wuKDq... (flutter/flutter#183584) 2026-03-12 matt.kosarek@canonical.com Adding the SatelliteWindowController interface to `_window.dart` (flutter/flutter#182903) 2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 0cab3e4ee34b to 46f41493ebf4 (17 revisions) (flutter/flutter#183553) 2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 8531f7c2bdae to 59be21f25f2d (4 revisions) (flutter/flutter#183547) 2026-03-12 koji.wakamiya@gmail.com [ios][engine] Fix keyboard flicker when switching text fields (flutter/flutter#182661) 2026-03-11 34871572+gmackall@users.noreply.github.com Rename hcpp opt in flag to `enable-hcpp` (flutter/flutter#183151) 2026-03-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183541) 2026-03-11 97480502+b-luk@users.noreply.github.com Re-enable gpu_test.dart for opengles, but disable specific tests in the file (flutter/flutter#183531) 2026-03-11 jacksongardner@google.com Use CLA-approved email and username for github workflow commits. (flutter/flutter#183540) 2026-03-11 okorohelijah@google.com [integration_test]UIScene Migration (flutter/flutter#182631) 2026-03-11 git@reb0.org ci: Run orchestrator for windows_arm_host_engine on Linux (flutter/flutter#181075) 2026-03-11 mdebbar@google.com [web] Prevent Firefox auto-updates (flutter/flutter#183330) 2026-03-11 koji.wakamiya@gmail.com Add scrollCacheExtent to PageView (flutter/flutter#180411) 2026-03-11 danny@tuppeny.com Remove redundant VS Code code/tests (flutter/flutter#183506) 2026-03-11 danny@tuppeny.com Roll pub packages (flutter/flutter#183527) 2026-03-11 34871572+gmackall@users.noreply.github.com Reapply "Make HCPP upgrading work for vd/tlhc (#181024)" (#183310) (flutter/flutter#183360) 2026-03-11 victorsanniay@gmail.com Add awaits to dev/ callsites (flutter/flutter#183479) 2026-03-11 stuartmorgan@google.com Standardize review timeline guidance (flutter/flutter#183465) 2026-03-11 chingjun@google.com Rename ExecutionModelToString to ExecutionModelToStringName. (flutter/flutter#183461) 2026-03-11 34871572+gmackall@users.noreply.github.com Fix input mirroring in platform views when system language is RTL, and support is set in manifest. (flutter/flutter#183472) 2026-03-11 engine-flutter-autoroll@skia.org Roll Packages from ee460d6 to ecace66 (10 revisions) (flutter/flutter#183517) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on the same page we say to ping people:
This makes it hard for new contributors to understand what the actual expectation is, and in practice the step 7 version creates behavior we don't want (immediately pinging people, usually the wrong ones, instead of waiting for the normal triage process).
This standardizes everything on two weeks.