[Impeller] For Android hardware buffers on Vulkan, use an alpha value of 1 if the buffer format always has opaque alpha by jason-simmons · Pull Request #182974 · flutter/flutter

jason-simmons · 2026-02-26T22:44:49Z

The AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM format specifies that the alpha value should be ignored and should always be treated as opaque. For this format, configure the VkComponentMapping to set alpha to VK_COMPONENT_SWIZZLE_ONE.

Fixes #182825

… of 1 if the buffer format always has opaque alpha The AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM format specifies that the alpha value should be ignored and should always be treated as opaque. For this format, configure the VkComponentMapping to set alpha to VK_COMPONENT_SWIZZLE_ONE. Fixes flutter#182825

gemini-code-assist

Code Review

This pull request correctly implements a fix for handling opaque alpha with AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM on Android by setting the alpha component swizzle to VK_COMPONENT_SWIZZLE_ONE. The changes include refactoring several free functions into static members of the AHBTextureSourceVK class, which improves code organization. A new unit test has been added to verify the correctness of the fix. My review includes feedback on a resource leak in the new unit test and a violation of the repository's style guide regarding documentation for new public methods.

gemini-code-assist · 2026-02-26T22:46:07Z

+  EXPECT_EQ(AHardwareBuffer_isSupported(&desc), 1);
+
+  AHardwareBuffer* buffer = nullptr;
+  ASSERT_EQ(AHardwareBuffer_allocate(&desc, &buffer), 0);


The AHardwareBuffer allocated here is not released, which will cause a resource leak in the test. Please ensure it's released before the function exits, for example by calling AHardwareBuffer_release(buffer) before context_vk->Shutdown(). Using an RAII wrapper would be even better to handle cleanup in case of test assertion failures.

gemini-code-assist · 2026-02-26T22:46:07Z

+  static vk::UniqueImage CreateVKImageWrapperForAndroidHarwareBuffer(
+      const vk::Device& device,
+      const AHBProperties& ahb_props,
+      const AHardwareBuffer_Desc& ahb_desc);
+
+  static ImageViewInfo CreateImageViewInfo(
+      const vk::Image& image,
+      const std::shared_ptr<YUVConversionVK>& yuv_conversion_wrapper,
+      const AHBProperties& ahb_props,
+      const AHardwareBuffer_Desc& ahb_desc);


These new public static methods should have documentation as per the repository style guide. Please add /// doc comments explaining what these functions do, their parameters, and what they return.

References

All public members should have documentation. ^(link)

gaaclarke

Looks good for the most part, just some minor notes. Thanks jason.

gaaclarke · 2026-02-26T22:47:55Z

-  }
-
-  return std::move(image.value);
+bool HardwareBufferFormatHasOpaqueAlpha(AHardwareBuffer_Format format) {


Suggested change

bool HardwareBufferFormatHasOpaqueAlpha(AHardwareBuffer_Format format) {

bool IsOpaque(AHardwareBuffer_Format format) {

gaaclarke · 2026-02-26T22:49:19Z

+  return format == AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM;
 }

+using AHBProperties = AHBTextureSourceVK::AHBProperties;


nit: put at the beginning of the scope

gaaclarke · 2026-02-26T22:56:08Z

+    return {};
+  }
+
+  return std::move(image.value);


I don't think you want to move in the return statement, that subverts copy elision.

std::move is necessary because vk::UniqueImage does not have a copy constructor

gaaclarke · 2026-02-26T22:58:15Z

+  static vk::UniqueImage CreateVKImageWrapperForAndroidHarwareBuffer(
+      const vk::Device& device,
+      const AHBProperties& ahb_props,
+      const AHardwareBuffer_Desc& ahb_desc);
+
+  static ImageViewInfo CreateImageViewInfo(
+      const vk::Image& image,
+      const std::shared_ptr<YUVConversionVK>& yuv_conversion_wrapper,
+      const AHBProperties& ahb_props,
+      const AHardwareBuffer_Desc& ahb_desc);


gaaclarke · 2026-02-26T22:58:31Z

+  EXPECT_EQ(AHardwareBuffer_isSupported(&desc), 1);
+
+  AHardwareBuffer* buffer = nullptr;
+  ASSERT_EQ(AHardwareBuffer_allocate(&desc, &buffer), 0);


gaaclarke · 2026-02-26T22:59:40Z

+  auto image_info = AHBTextureSourceVK::CreateImageViewInfo(
+      image.get(), nullptr, ahb_props, desc);
+
+  ASSERT_EQ(image_info.get().components.a, vk::ComponentSwizzle::eOne);


Suggested change

ASSERT_EQ(image_info.get().components.a, vk::ComponentSwizzle::eOne);

EXPECT_EQ(image_info.get().components.a, vk::ComponentSwizzle::eOne);

gaaclarke

thanks jason!

…lpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)

Roll Flutter from 1141b2bdce66 to 46fb7210422d (38 revisions) flutter/flutter@1141b2b...46fb721 2026-03-02 parlough@gmail.com [rules] Fix a few issues in the full-length rules file (flutter/flutter#182725) 2026-03-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 8063f5f5ac60 to e86dbe9aa742 (1 revision) (flutter/flutter#183120) 2026-03-02 mdebbar@google.com [web] Roll Chrome to 145 (flutter/flutter#182860) 2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from 61c0e71760f5 to e180358b7a7a (1 revision) (flutter/flutter#183118) 2026-03-02 engine-flutter-autoroll@skia.org Roll Packages from a27d7c5 to faa4e22 (4 revisions) (flutter/flutter#183117) 2026-03-02 stuartmorgan@google.com Add information to issue triage page (flutter/flutter#182145) 2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from cc8ce92481f2 to 61c0e71760f5 (2 revisions) (flutter/flutter#183103) 2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from 4cf3cd27b620 to cc8ce92481f2 (1 revision) (flutter/flutter#183100) 2026-03-02 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zN2ZV9QD0LD8acUFF... to 0dCDM2oORHwDf_pyb... (flutter/flutter#183101) 2026-03-01 nick.fisher@avinium.com Update fl_texture_gl.h (flutter/flutter#182999) 2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from be1362b5ca4e to 4cf3cd27b620 (1 revision) (flutter/flutter#183096) 2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from b9210eb7005f to be1362b5ca4e (1 revision) (flutter/flutter#183092) 2026-03-01 robert.ancell@canonical.com Timeout when waiting for the correct sized frame from Flutter. (flutter/flutter#182971) 2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from 28172a4e03af to b9210eb7005f (1 revision) (flutter/flutter#183088) 2026-03-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from D7IYacJUCpvc_1iU_... to zN2ZV9QD0LD8acUFF... (flutter/flutter#183076) 2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from cdf45eaf995e to 8063f5f5ac60 (1 revision) (flutter/flutter#183064) 2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 54451fcdbcf9 to cdf45eaf995e (1 revision) (flutter/flutter#183057) 2026-02-28 engine-flutter-autoroll@skia.org Roll Skia from c8bcc27f5319 to 28172a4e03af (3 revisions) (flutter/flutter#183056) 2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 148d91b8a603 to 54451fcdbcf9 (2 revisions) (flutter/flutter#183051) 2026-02-28 jhy03261997@gmail.com [A11y] in calendar date picker, remove SemanticsService.sendAnnouncement usage for android. (flutter/flutter#182918) 2026-02-28 737941+loic-sharma@users.noreply.github.com Add desktop review teams (flutter/flutter#182972) 2026-02-28 zhongliu88889@gmail.com [framework] Fix Text.semanticsIdentifier being absorbed by ancestor nodes (flutter/flutter#181795) 2026-02-28 engine-flutter-autoroll@skia.org Roll Skia from b150186d3e23 to c8bcc27f5319 (5 revisions) (flutter/flutter#183032) 2026-02-28 jason-simmons@users.noreply.github.com [Impeller] For Android hardware buffers on Vulkan, use an alpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974) 2026-02-27 30870216+gaaclarke@users.noreply.github.com Adds float32 output to `Image.toByteData()` in float32 Image (flutter/flutter#182847) 2026-02-27 engine-flutter-autoroll@skia.org Roll Dart SDK from 1cdb7dfd913e to 148d91b8a603 (1 revision) (flutter/flutter#183025) 2026-02-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from G1GwOdVt5bM7GjMSY... to D7IYacJUCpvc_1iU_... (flutter/flutter#183021) 2026-02-27 97480502+b-luk@users.noreply.github.com When impellerc fails with a long shader compilation error, truncate it and output to a file (flutter/flutter#182786) 2026-02-27 15619084+vashworth@users.noreply.github.com Add missing mutation-safe delegate iteration and use idomatic syntax (flutter/flutter#183018) 2026-02-27 15619084+vashworth@users.noreply.github.com Exclude arm64 if any dependencies do and print warning when using Xcode 26 (flutter/flutter#182913) 2026-02-27 victorsanniay@gmail.com Ignore unawaited_futures lint in dev/automated_tests (flutter/flutter#182922) 2026-02-27 30870216+gaaclarke@users.noreply.github.com licenses_cpp: pre-land changes for perfetto update (flutter/flutter#182965) 2026-02-27 15619084+vashworth@users.noreply.github.com Re-add extended attribute removed by SwiftPM (flutter/flutter#183011) 2026-02-27 52160996+FMorschel@users.noreply.github.com Fixes future warning for `await`ing `Future` returns in `async` bodies inside `try` blocks (flutter/flutter#182301) 2026-02-27 engine-flutter-autoroll@skia.org Roll Skia from ed220c490eea to b150186d3e23 (2 revisions) (flutter/flutter#183014) 2026-02-27 51901607+O-Hannonen@users.noreply.github.com Fix issue where web embedder is synthesizing key up events too eagerly (flutter/flutter#180692) 2026-02-27 1961493+harryterkelsen@users.noreply.github.com chore: Don't unconditionally check tools/gn formatting (flutter/flutter#182973) 2026-02-27 engine-flutter-autoroll@skia.org Roll Packages from e1d0169 to a27d7c5 (8 revisions) (flutter/flutter#183009) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

… of 1 if the buffer format always has opaque alpha (flutter#182974) The AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM format specifies that the alpha value should be ignored and should always be treated as opaque. For this format, configure the VkComponentMapping to set alpha to VK_COMPONENT_SWIZZLE_ONE. Fixes flutter#182825

…r#11162) Roll Flutter from 1141b2bdce66 to 46fb7210422d (38 revisions) flutter/flutter@1141b2b...46fb721 2026-03-02 parlough@gmail.com [rules] Fix a few issues in the full-length rules file (flutter/flutter#182725) 2026-03-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 8063f5f5ac60 to e86dbe9aa742 (1 revision) (flutter/flutter#183120) 2026-03-02 mdebbar@google.com [web] Roll Chrome to 145 (flutter/flutter#182860) 2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from 61c0e71760f5 to e180358b7a7a (1 revision) (flutter/flutter#183118) 2026-03-02 engine-flutter-autoroll@skia.org Roll Packages from a27d7c5 to faa4e22 (4 revisions) (flutter/flutter#183117) 2026-03-02 stuartmorgan@google.com Add information to issue triage page (flutter/flutter#182145) 2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from cc8ce92481f2 to 61c0e71760f5 (2 revisions) (flutter/flutter#183103) 2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from 4cf3cd27b620 to cc8ce92481f2 (1 revision) (flutter/flutter#183100) 2026-03-02 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zN2ZV9QD0LD8acUFF... to 0dCDM2oORHwDf_pyb... (flutter/flutter#183101) 2026-03-01 nick.fisher@avinium.com Update fl_texture_gl.h (flutter/flutter#182999) 2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from be1362b5ca4e to 4cf3cd27b620 (1 revision) (flutter/flutter#183096) 2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from b9210eb7005f to be1362b5ca4e (1 revision) (flutter/flutter#183092) 2026-03-01 robert.ancell@canonical.com Timeout when waiting for the correct sized frame from Flutter. (flutter/flutter#182971) 2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from 28172a4e03af to b9210eb7005f (1 revision) (flutter/flutter#183088) 2026-03-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from D7IYacJUCpvc_1iU_... to zN2ZV9QD0LD8acUFF... (flutter/flutter#183076) 2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from cdf45eaf995e to 8063f5f5ac60 (1 revision) (flutter/flutter#183064) 2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 54451fcdbcf9 to cdf45eaf995e (1 revision) (flutter/flutter#183057) 2026-02-28 engine-flutter-autoroll@skia.org Roll Skia from c8bcc27f5319 to 28172a4e03af (3 revisions) (flutter/flutter#183056) 2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 148d91b8a603 to 54451fcdbcf9 (2 revisions) (flutter/flutter#183051) 2026-02-28 jhy03261997@gmail.com [A11y] in calendar date picker, remove SemanticsService.sendAnnouncement usage for android. (flutter/flutter#182918) 2026-02-28 737941+loic-sharma@users.noreply.github.com Add desktop review teams (flutter/flutter#182972) 2026-02-28 zhongliu88889@gmail.com [framework] Fix Text.semanticsIdentifier being absorbed by ancestor nodes (flutter/flutter#181795) 2026-02-28 engine-flutter-autoroll@skia.org Roll Skia from b150186d3e23 to c8bcc27f5319 (5 revisions) (flutter/flutter#183032) 2026-02-28 jason-simmons@users.noreply.github.com [Impeller] For Android hardware buffers on Vulkan, use an alpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974) 2026-02-27 30870216+gaaclarke@users.noreply.github.com Adds float32 output to `Image.toByteData()` in float32 Image (flutter/flutter#182847) 2026-02-27 engine-flutter-autoroll@skia.org Roll Dart SDK from 1cdb7dfd913e to 148d91b8a603 (1 revision) (flutter/flutter#183025) 2026-02-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from G1GwOdVt5bM7GjMSY... to D7IYacJUCpvc_1iU_... (flutter/flutter#183021) 2026-02-27 97480502+b-luk@users.noreply.github.com When impellerc fails with a long shader compilation error, truncate it and output to a file (flutter/flutter#182786) 2026-02-27 15619084+vashworth@users.noreply.github.com Add missing mutation-safe delegate iteration and use idomatic syntax (flutter/flutter#183018) 2026-02-27 15619084+vashworth@users.noreply.github.com Exclude arm64 if any dependencies do and print warning when using Xcode 26 (flutter/flutter#182913) 2026-02-27 victorsanniay@gmail.com Ignore unawaited_futures lint in dev/automated_tests (flutter/flutter#182922) 2026-02-27 30870216+gaaclarke@users.noreply.github.com licenses_cpp: pre-land changes for perfetto update (flutter/flutter#182965) 2026-02-27 15619084+vashworth@users.noreply.github.com Re-add extended attribute removed by SwiftPM (flutter/flutter#183011) 2026-02-27 52160996+FMorschel@users.noreply.github.com Fixes future warning for `await`ing `Future` returns in `async` bodies inside `try` blocks (flutter/flutter#182301) 2026-02-27 engine-flutter-autoroll@skia.org Roll Skia from ed220c490eea to b150186d3e23 (2 revisions) (flutter/flutter#183014) 2026-02-27 51901607+O-Hannonen@users.noreply.github.com Fix issue where web embedder is synthesizing key up events too eagerly (flutter/flutter#180692) 2026-02-27 1961493+harryterkelsen@users.noreply.github.com chore: Don't unconditionally check tools/gn formatting (flutter/flutter#182973) 2026-02-27 engine-flutter-autoroll@skia.org Roll Packages from e1d0169 to a27d7c5 (8 revisions) (flutter/flutter#183009) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

… of 1 if the buffer format always has opaque alpha (flutter#182974) The AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM format specifies that the alpha value should be ignored and should always be treated as opaque. For this format, configure the VkComponentMapping to set alpha to VK_COMPONENT_SWIZZLE_ONE. Fixes flutter#182825

…r#11162) Roll Flutter from 1141b2bdce66 to 46fb7210422d (38 revisions) flutter/flutter@1141b2b...46fb721 2026-03-02 parlough@gmail.com [rules] Fix a few issues in the full-length rules file (flutter/flutter#182725) 2026-03-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 8063f5f5ac60 to e86dbe9aa742 (1 revision) (flutter/flutter#183120) 2026-03-02 mdebbar@google.com [web] Roll Chrome to 145 (flutter/flutter#182860) 2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from 61c0e71760f5 to e180358b7a7a (1 revision) (flutter/flutter#183118) 2026-03-02 engine-flutter-autoroll@skia.org Roll Packages from a27d7c5 to faa4e22 (4 revisions) (flutter/flutter#183117) 2026-03-02 stuartmorgan@google.com Add information to issue triage page (flutter/flutter#182145) 2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from cc8ce92481f2 to 61c0e71760f5 (2 revisions) (flutter/flutter#183103) 2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from 4cf3cd27b620 to cc8ce92481f2 (1 revision) (flutter/flutter#183100) 2026-03-02 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zN2ZV9QD0LD8acUFF... to 0dCDM2oORHwDf_pyb... (flutter/flutter#183101) 2026-03-01 nick.fisher@avinium.com Update fl_texture_gl.h (flutter/flutter#182999) 2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from be1362b5ca4e to 4cf3cd27b620 (1 revision) (flutter/flutter#183096) 2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from b9210eb7005f to be1362b5ca4e (1 revision) (flutter/flutter#183092) 2026-03-01 robert.ancell@canonical.com Timeout when waiting for the correct sized frame from Flutter. (flutter/flutter#182971) 2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from 28172a4e03af to b9210eb7005f (1 revision) (flutter/flutter#183088) 2026-03-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from D7IYacJUCpvc_1iU_... to zN2ZV9QD0LD8acUFF... (flutter/flutter#183076) 2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from cdf45eaf995e to 8063f5f5ac60 (1 revision) (flutter/flutter#183064) 2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 54451fcdbcf9 to cdf45eaf995e (1 revision) (flutter/flutter#183057) 2026-02-28 engine-flutter-autoroll@skia.org Roll Skia from c8bcc27f5319 to 28172a4e03af (3 revisions) (flutter/flutter#183056) 2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 148d91b8a603 to 54451fcdbcf9 (2 revisions) (flutter/flutter#183051) 2026-02-28 jhy03261997@gmail.com [A11y] in calendar date picker, remove SemanticsService.sendAnnouncement usage for android. (flutter/flutter#182918) 2026-02-28 737941+loic-sharma@users.noreply.github.com Add desktop review teams (flutter/flutter#182972) 2026-02-28 zhongliu88889@gmail.com [framework] Fix Text.semanticsIdentifier being absorbed by ancestor nodes (flutter/flutter#181795) 2026-02-28 engine-flutter-autoroll@skia.org Roll Skia from b150186d3e23 to c8bcc27f5319 (5 revisions) (flutter/flutter#183032) 2026-02-28 jason-simmons@users.noreply.github.com [Impeller] For Android hardware buffers on Vulkan, use an alpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974) 2026-02-27 30870216+gaaclarke@users.noreply.github.com Adds float32 output to `Image.toByteData()` in float32 Image (flutter/flutter#182847) 2026-02-27 engine-flutter-autoroll@skia.org Roll Dart SDK from 1cdb7dfd913e to 148d91b8a603 (1 revision) (flutter/flutter#183025) 2026-02-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from G1GwOdVt5bM7GjMSY... to D7IYacJUCpvc_1iU_... (flutter/flutter#183021) 2026-02-27 97480502+b-luk@users.noreply.github.com When impellerc fails with a long shader compilation error, truncate it and output to a file (flutter/flutter#182786) 2026-02-27 15619084+vashworth@users.noreply.github.com Add missing mutation-safe delegate iteration and use idomatic syntax (flutter/flutter#183018) 2026-02-27 15619084+vashworth@users.noreply.github.com Exclude arm64 if any dependencies do and print warning when using Xcode 26 (flutter/flutter#182913) 2026-02-27 victorsanniay@gmail.com Ignore unawaited_futures lint in dev/automated_tests (flutter/flutter#182922) 2026-02-27 30870216+gaaclarke@users.noreply.github.com licenses_cpp: pre-land changes for perfetto update (flutter/flutter#182965) 2026-02-27 15619084+vashworth@users.noreply.github.com Re-add extended attribute removed by SwiftPM (flutter/flutter#183011) 2026-02-27 52160996+FMorschel@users.noreply.github.com Fixes future warning for `await`ing `Future` returns in `async` bodies inside `try` blocks (flutter/flutter#182301) 2026-02-27 engine-flutter-autoroll@skia.org Roll Skia from ed220c490eea to b150186d3e23 (2 revisions) (flutter/flutter#183014) 2026-02-27 51901607+O-Hannonen@users.noreply.github.com Fix issue where web embedder is synthesizing key up events too eagerly (flutter/flutter#180692) 2026-02-27 1961493+harryterkelsen@users.noreply.github.com chore: Don't unconditionally check tools/gn formatting (flutter/flutter#182973) 2026-02-27 engine-flutter-autoroll@skia.org Roll Packages from e1d0169 to a27d7c5 (8 revisions) (flutter/flutter#183009) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

jason-simmons requested a review from gaaclarke February 26, 2026 22:44

github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Feb 26, 2026

gemini-code-assist Bot reviewed Feb 26, 2026

View reviewed changes

gaaclarke reviewed Feb 26, 2026

View reviewed changes

release AHardwareBuffer

5e04034

gaaclarke approved these changes Feb 26, 2026

View reviewed changes

clang-tidy

f9da380

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2026

auto-submit Bot added this pull request to the merge queue Feb 28, 2026

Merged via the queue into flutter:master with commit d1ae8a7 Feb 28, 2026
185 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2026

engine-flutter-autoroll mentioned this pull request Feb 28, 2026

Roll Flutter from 1141b2bdce66 to a225be287e31 (23 revisions) flutter/packages#11141

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2026

d1ae8a712 [Impeller] For Android hardware buffers on Vulkan, use an a…

34251bd

…lpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2026

d1ae8a712 [Impeller] For Android hardware buffers on Vulkan, use an a…

fcc1e2a

…lpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)

engine-flutter-autoroll mentioned this pull request Feb 28, 2026

Roll Flutter from 1141b2bdce66 to a225be287e31 (23 revisions) flutter/packages#11142

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2026

d1ae8a712 [Impeller] For Android hardware buffers on Vulkan, use an a…

13d6d37

…lpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)

This was referenced Mar 1, 2026

Roll Flutter from 1141b2bdce66 to 5515ae85dae3 (24 revisions) flutter/packages#11147

Closed

Roll Flutter from 1141b2bdce66 to abffac30ae6e (25 revisions) flutter/packages#11148

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2026

d1ae8a712 [Impeller] For Android hardware buffers on Vulkan, use an a…

7675400

…lpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)

engine-flutter-autoroll mentioned this pull request Mar 2, 2026

Roll Flutter from 1141b2bdce66 to e78520497800 (33 revisions) flutter/packages#11156

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026

d1ae8a712 [Impeller] For Android hardware buffers on Vulkan, use an a…

f1cabc7

…lpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026

d1ae8a712 [Impeller] For Android hardware buffers on Vulkan, use an a…

135b4f3

…lpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)

engine-flutter-autoroll mentioned this pull request Mar 2, 2026

Roll Flutter from 1141b2bdce66 to 434491ab43cf (34 revisions) flutter/packages#11157

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026

d1ae8a712 [Impeller] For Android hardware buffers on Vulkan, use an a…

540dd8f

…lpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)

engine-flutter-autoroll mentioned this pull request Mar 2, 2026

Roll Flutter from 1141b2bdce66 to ce6e34771ee0 (35 revisions) flutter/packages#11158

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026

d1ae8a712 [Impeller] For Android hardware buffers on Vulkan, use an a…

827b5d3

…lpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)

engine-flutter-autoroll mentioned this pull request Mar 2, 2026

Roll Flutter from 1141b2bdce66 to 63d4a81ce878 (36 revisions) flutter/packages#11159

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026

d1ae8a712 [Impeller] For Android hardware buffers on Vulkan, use an a…

9842802

…lpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)

engine-flutter-autoroll mentioned this pull request Mar 2, 2026

Roll Flutter from 1141b2bdce66 to 1e52e0cf8b20 (37 revisions) flutter/packages#11160

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026

d1ae8a712 [Impeller] For Android hardware buffers on Vulkan, use an a…

995f593

…lpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)

engine-flutter-autoroll mentioned this pull request Mar 2, 2026

Roll Flutter from 1141b2bdce66 to 46fb7210422d (38 revisions) flutter/packages#11162

Merged

codon19 mentioned this pull request Apr 23, 2026

[Android]: Occasional image corruption on Samsung S25 using Vulkan rendering #179872

Open

	bool HardwareBufferFormatHasOpaqueAlpha(AHardwareBuffer_Format format) {
	bool IsOpaque(AHardwareBuffer_Format format) {

	ASSERT_EQ(image_info.get().components.a, vk::ComponentSwizzle::eOne);
	EXPECT_EQ(image_info.get().components.a, vk::ComponentSwizzle::eOne);

Uh oh!

Conversation

jason-simmons commented Feb 26, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants