Skip to content

Add desktop review teams#182972

Merged
auto-submit[bot] merged 5 commits into
flutter:masterfrom
loic-sharma:desktop_review_teams
Feb 28, 2026
Merged

Add desktop review teams#182972
auto-submit[bot] merged 5 commits into
flutter:masterfrom
loic-sharma:desktop_review_teams

Conversation

@loic-sharma

Copy link
Copy Markdown
Member

Updates CODEOWNERS and labeler to use the new desktop review teams. This ensures folks are automatically notified of desktop PRs.

Prior art: #166034

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions Bot added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. d: docs/ flutter/flutter/docs, for contributors labels Feb 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new desktop review teams for Linux, macOS, and Windows by updating .github/labeler.yml and CODEOWNERS. The changes also include documentation updates for these new teams.

My review has identified some potential issues, primarily related to the new macOS team configuration. There are overlaps in file ownership and label definitions between the new macos-reviewers team and the existing ios-reviewers team. This will likely result in both teams being notified for macOS-related changes, which may not be the desired outcome. Additionally, I've spotted a potential typo in a file path within the CODEOWNERS file that could affect review assignments. I've left specific comments with suggestions on how to address these points.

Comment thread CODEOWNERS Outdated
Comment thread .github/labeler.yml

@robert-ancell robert-ancell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loic-sharma loic-sharma requested a review from jmagman February 27, 2026 00:20
@loic-sharma

loic-sharma commented Feb 27, 2026

Copy link
Copy Markdown
Member Author

I'm not sure why GitHub has a This CODEOWNERS file contains errors error. I confirmed the teams exist and are visible:

  1. https://github.com/orgs/flutter/teams/linux-reviewers
  2. https://github.com/orgs/flutter/teams/macos-reviewers
  3. https://github.com/orgs/flutter/teams/windows-reviewers

I asked in Discord for confirmation that these teams have write access: https://discord.com/channels/608014603317936148/610574672865656952/1476738372092301413

@loic-sharma

Copy link
Copy Markdown
Member Author

OK the review teams now have the proper write permissions!

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Feb 28, 2026
Merged via the queue into flutter:master with commit 4849b70 Feb 28, 2026
41 of 42 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Mar 2, 2026
Roll Flutter from 1141b2bdce66 to 46fb7210422d (38 revisions)

flutter/flutter@1141b2b...46fb721

2026-03-02 parlough@gmail.com [rules] Fix a few issues in the full-length rules file (flutter/flutter#182725)
2026-03-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 8063f5f5ac60 to e86dbe9aa742 (1 revision) (flutter/flutter#183120)
2026-03-02 mdebbar@google.com [web] Roll Chrome to 145 (flutter/flutter#182860)
2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from 61c0e71760f5 to e180358b7a7a (1 revision) (flutter/flutter#183118)
2026-03-02 engine-flutter-autoroll@skia.org Roll Packages from a27d7c5 to faa4e22 (4 revisions) (flutter/flutter#183117)
2026-03-02 stuartmorgan@google.com Add information to issue triage page (flutter/flutter#182145)
2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from cc8ce92481f2 to 61c0e71760f5 (2 revisions) (flutter/flutter#183103)
2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from 4cf3cd27b620 to cc8ce92481f2 (1 revision) (flutter/flutter#183100)
2026-03-02 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zN2ZV9QD0LD8acUFF... to 0dCDM2oORHwDf_pyb... (flutter/flutter#183101)
2026-03-01 nick.fisher@avinium.com Update fl_texture_gl.h (flutter/flutter#182999)
2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from be1362b5ca4e to 4cf3cd27b620 (1 revision) (flutter/flutter#183096)
2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from b9210eb7005f to be1362b5ca4e (1 revision) (flutter/flutter#183092)
2026-03-01 robert.ancell@canonical.com Timeout when waiting for the correct sized frame from Flutter. (flutter/flutter#182971)
2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from 28172a4e03af to b9210eb7005f (1 revision) (flutter/flutter#183088)
2026-03-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from D7IYacJUCpvc_1iU_... to zN2ZV9QD0LD8acUFF... (flutter/flutter#183076)
2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from cdf45eaf995e to 8063f5f5ac60 (1 revision) (flutter/flutter#183064)
2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 54451fcdbcf9 to cdf45eaf995e (1 revision) (flutter/flutter#183057)
2026-02-28 engine-flutter-autoroll@skia.org Roll Skia from c8bcc27f5319 to 28172a4e03af (3 revisions) (flutter/flutter#183056)
2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 148d91b8a603 to 54451fcdbcf9 (2 revisions) (flutter/flutter#183051)
2026-02-28 jhy03261997@gmail.com [A11y] in calendar date picker, remove SemanticsService.sendAnnouncement usage for android.  (flutter/flutter#182918)
2026-02-28 737941+loic-sharma@users.noreply.github.com Add desktop review teams (flutter/flutter#182972)
2026-02-28 zhongliu88889@gmail.com [framework] Fix Text.semanticsIdentifier being absorbed by ancestor nodes (flutter/flutter#181795)
2026-02-28 engine-flutter-autoroll@skia.org Roll Skia from b150186d3e23 to c8bcc27f5319 (5 revisions) (flutter/flutter#183032)
2026-02-28 jason-simmons@users.noreply.github.com [Impeller] For Android hardware buffers on Vulkan, use an alpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)
2026-02-27 30870216+gaaclarke@users.noreply.github.com Adds float32 output to `Image.toByteData()` in float32 Image (flutter/flutter#182847)
2026-02-27 engine-flutter-autoroll@skia.org Roll Dart SDK from 1cdb7dfd913e to 148d91b8a603 (1 revision) (flutter/flutter#183025)
2026-02-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from G1GwOdVt5bM7GjMSY... to D7IYacJUCpvc_1iU_... (flutter/flutter#183021)
2026-02-27 97480502+b-luk@users.noreply.github.com When impellerc fails with a long shader compilation error, truncate it and output to a file (flutter/flutter#182786)
2026-02-27 15619084+vashworth@users.noreply.github.com Add missing mutation-safe delegate iteration and use idomatic syntax (flutter/flutter#183018)
2026-02-27 15619084+vashworth@users.noreply.github.com Exclude arm64 if any dependencies do and print warning when using Xcode 26 (flutter/flutter#182913)
2026-02-27 victorsanniay@gmail.com Ignore unawaited_futures lint in dev/automated_tests (flutter/flutter#182922)
2026-02-27 30870216+gaaclarke@users.noreply.github.com licenses_cpp: pre-land changes for perfetto update (flutter/flutter#182965)
2026-02-27 15619084+vashworth@users.noreply.github.com Re-add extended attribute removed by SwiftPM (flutter/flutter#183011)
2026-02-27 52160996+FMorschel@users.noreply.github.com Fixes future warning for `await`ing `Future` returns in `async` bodies inside `try` blocks (flutter/flutter#182301)
2026-02-27 engine-flutter-autoroll@skia.org Roll Skia from ed220c490eea to b150186d3e23 (2 revisions) (flutter/flutter#183014)
2026-02-27 51901607+O-Hannonen@users.noreply.github.com Fix issue where web embedder is synthesizing key up events too eagerly (flutter/flutter#180692)
2026-02-27 1961493+harryterkelsen@users.noreply.github.com chore: Don't unconditionally check tools/gn formatting (flutter/flutter#182973)
2026-02-27 engine-flutter-autoroll@skia.org Roll Packages from e1d0169 to a27d7c5 (8 revisions) (flutter/flutter#183009)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
...
xxxOVALxxx pushed a commit to xxxOVALxxx/flutter that referenced this pull request Mar 10, 2026
Updates CODEOWNERS and labeler to use the new desktop review teams. This
ensures folks are automatically notified of desktop PRs.

Prior art: flutter#166034

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
okorohelijah pushed a commit to okorohelijah/packages that referenced this pull request Mar 26, 2026
…r#11162)

Roll Flutter from 1141b2bdce66 to 46fb7210422d (38 revisions)

flutter/flutter@1141b2b...46fb721

2026-03-02 parlough@gmail.com [rules] Fix a few issues in the full-length rules file (flutter/flutter#182725)
2026-03-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 8063f5f5ac60 to e86dbe9aa742 (1 revision) (flutter/flutter#183120)
2026-03-02 mdebbar@google.com [web] Roll Chrome to 145 (flutter/flutter#182860)
2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from 61c0e71760f5 to e180358b7a7a (1 revision) (flutter/flutter#183118)
2026-03-02 engine-flutter-autoroll@skia.org Roll Packages from a27d7c5 to faa4e22 (4 revisions) (flutter/flutter#183117)
2026-03-02 stuartmorgan@google.com Add information to issue triage page (flutter/flutter#182145)
2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from cc8ce92481f2 to 61c0e71760f5 (2 revisions) (flutter/flutter#183103)
2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from 4cf3cd27b620 to cc8ce92481f2 (1 revision) (flutter/flutter#183100)
2026-03-02 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zN2ZV9QD0LD8acUFF... to 0dCDM2oORHwDf_pyb... (flutter/flutter#183101)
2026-03-01 nick.fisher@avinium.com Update fl_texture_gl.h (flutter/flutter#182999)
2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from be1362b5ca4e to 4cf3cd27b620 (1 revision) (flutter/flutter#183096)
2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from b9210eb7005f to be1362b5ca4e (1 revision) (flutter/flutter#183092)
2026-03-01 robert.ancell@canonical.com Timeout when waiting for the correct sized frame from Flutter. (flutter/flutter#182971)
2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from 28172a4e03af to b9210eb7005f (1 revision) (flutter/flutter#183088)
2026-03-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from D7IYacJUCpvc_1iU_... to zN2ZV9QD0LD8acUFF... (flutter/flutter#183076)
2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from cdf45eaf995e to 8063f5f5ac60 (1 revision) (flutter/flutter#183064)
2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 54451fcdbcf9 to cdf45eaf995e (1 revision) (flutter/flutter#183057)
2026-02-28 engine-flutter-autoroll@skia.org Roll Skia from c8bcc27f5319 to 28172a4e03af (3 revisions) (flutter/flutter#183056)
2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 148d91b8a603 to 54451fcdbcf9 (2 revisions) (flutter/flutter#183051)
2026-02-28 jhy03261997@gmail.com [A11y] in calendar date picker, remove SemanticsService.sendAnnouncement usage for android.  (flutter/flutter#182918)
2026-02-28 737941+loic-sharma@users.noreply.github.com Add desktop review teams (flutter/flutter#182972)
2026-02-28 zhongliu88889@gmail.com [framework] Fix Text.semanticsIdentifier being absorbed by ancestor nodes (flutter/flutter#181795)
2026-02-28 engine-flutter-autoroll@skia.org Roll Skia from b150186d3e23 to c8bcc27f5319 (5 revisions) (flutter/flutter#183032)
2026-02-28 jason-simmons@users.noreply.github.com [Impeller] For Android hardware buffers on Vulkan, use an alpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)
2026-02-27 30870216+gaaclarke@users.noreply.github.com Adds float32 output to `Image.toByteData()` in float32 Image (flutter/flutter#182847)
2026-02-27 engine-flutter-autoroll@skia.org Roll Dart SDK from 1cdb7dfd913e to 148d91b8a603 (1 revision) (flutter/flutter#183025)
2026-02-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from G1GwOdVt5bM7GjMSY... to D7IYacJUCpvc_1iU_... (flutter/flutter#183021)
2026-02-27 97480502+b-luk@users.noreply.github.com When impellerc fails with a long shader compilation error, truncate it and output to a file (flutter/flutter#182786)
2026-02-27 15619084+vashworth@users.noreply.github.com Add missing mutation-safe delegate iteration and use idomatic syntax (flutter/flutter#183018)
2026-02-27 15619084+vashworth@users.noreply.github.com Exclude arm64 if any dependencies do and print warning when using Xcode 26 (flutter/flutter#182913)
2026-02-27 victorsanniay@gmail.com Ignore unawaited_futures lint in dev/automated_tests (flutter/flutter#182922)
2026-02-27 30870216+gaaclarke@users.noreply.github.com licenses_cpp: pre-land changes for perfetto update (flutter/flutter#182965)
2026-02-27 15619084+vashworth@users.noreply.github.com Re-add extended attribute removed by SwiftPM (flutter/flutter#183011)
2026-02-27 52160996+FMorschel@users.noreply.github.com Fixes future warning for `await`ing `Future` returns in `async` bodies inside `try` blocks (flutter/flutter#182301)
2026-02-27 engine-flutter-autoroll@skia.org Roll Skia from ed220c490eea to b150186d3e23 (2 revisions) (flutter/flutter#183014)
2026-02-27 51901607+O-Hannonen@users.noreply.github.com Fix issue where web embedder is synthesizing key up events too eagerly (flutter/flutter#180692)
2026-02-27 1961493+harryterkelsen@users.noreply.github.com chore: Don't unconditionally check tools/gn formatting (flutter/flutter#182973)
2026-02-27 engine-flutter-autoroll@skia.org Roll Packages from e1d0169 to a27d7c5 (8 revisions) (flutter/flutter#183009)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
...
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
Updates CODEOWNERS and labeler to use the new desktop review teams. This
ensures folks are automatically notified of desktop PRs.

Prior art: flutter#166034

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
github-merge-queue Bot pushed a commit that referenced this pull request Mar 26, 2026
#182972 (comment)
attempted to add mac-reviewers to flutter_tool PRs in addition to
ios-reviewers, but it didn't apply both:
#183253

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
ahmedsameha1 pushed a commit to ahmedsameha1/flutter that referenced this pull request Apr 14, 2026
flutter#182972 (comment)
attempted to add mac-reviewers to flutter_tool PRs in addition to
ios-reviewers, but it didn't apply both:
flutter#183253

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…r#11162)

Roll Flutter from 1141b2bdce66 to 46fb7210422d (38 revisions)

flutter/flutter@1141b2b...46fb721

2026-03-02 parlough@gmail.com [rules] Fix a few issues in the full-length rules file (flutter/flutter#182725)
2026-03-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 8063f5f5ac60 to e86dbe9aa742 (1 revision) (flutter/flutter#183120)
2026-03-02 mdebbar@google.com [web] Roll Chrome to 145 (flutter/flutter#182860)
2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from 61c0e71760f5 to e180358b7a7a (1 revision) (flutter/flutter#183118)
2026-03-02 engine-flutter-autoroll@skia.org Roll Packages from a27d7c5 to faa4e22 (4 revisions) (flutter/flutter#183117)
2026-03-02 stuartmorgan@google.com Add information to issue triage page (flutter/flutter#182145)
2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from cc8ce92481f2 to 61c0e71760f5 (2 revisions) (flutter/flutter#183103)
2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from 4cf3cd27b620 to cc8ce92481f2 (1 revision) (flutter/flutter#183100)
2026-03-02 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zN2ZV9QD0LD8acUFF... to 0dCDM2oORHwDf_pyb... (flutter/flutter#183101)
2026-03-01 nick.fisher@avinium.com Update fl_texture_gl.h (flutter/flutter#182999)
2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from be1362b5ca4e to 4cf3cd27b620 (1 revision) (flutter/flutter#183096)
2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from b9210eb7005f to be1362b5ca4e (1 revision) (flutter/flutter#183092)
2026-03-01 robert.ancell@canonical.com Timeout when waiting for the correct sized frame from Flutter. (flutter/flutter#182971)
2026-03-01 engine-flutter-autoroll@skia.org Roll Skia from 28172a4e03af to b9210eb7005f (1 revision) (flutter/flutter#183088)
2026-03-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from D7IYacJUCpvc_1iU_... to zN2ZV9QD0LD8acUFF... (flutter/flutter#183076)
2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from cdf45eaf995e to 8063f5f5ac60 (1 revision) (flutter/flutter#183064)
2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 54451fcdbcf9 to cdf45eaf995e (1 revision) (flutter/flutter#183057)
2026-02-28 engine-flutter-autoroll@skia.org Roll Skia from c8bcc27f5319 to 28172a4e03af (3 revisions) (flutter/flutter#183056)
2026-02-28 engine-flutter-autoroll@skia.org Roll Dart SDK from 148d91b8a603 to 54451fcdbcf9 (2 revisions) (flutter/flutter#183051)
2026-02-28 jhy03261997@gmail.com [A11y] in calendar date picker, remove SemanticsService.sendAnnouncement usage for android.  (flutter/flutter#182918)
2026-02-28 737941+loic-sharma@users.noreply.github.com Add desktop review teams (flutter/flutter#182972)
2026-02-28 zhongliu88889@gmail.com [framework] Fix Text.semanticsIdentifier being absorbed by ancestor nodes (flutter/flutter#181795)
2026-02-28 engine-flutter-autoroll@skia.org Roll Skia from b150186d3e23 to c8bcc27f5319 (5 revisions) (flutter/flutter#183032)
2026-02-28 jason-simmons@users.noreply.github.com [Impeller] For Android hardware buffers on Vulkan, use an alpha value of 1 if the buffer format always has opaque alpha (flutter/flutter#182974)
2026-02-27 30870216+gaaclarke@users.noreply.github.com Adds float32 output to `Image.toByteData()` in float32 Image (flutter/flutter#182847)
2026-02-27 engine-flutter-autoroll@skia.org Roll Dart SDK from 1cdb7dfd913e to 148d91b8a603 (1 revision) (flutter/flutter#183025)
2026-02-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from G1GwOdVt5bM7GjMSY... to D7IYacJUCpvc_1iU_... (flutter/flutter#183021)
2026-02-27 97480502+b-luk@users.noreply.github.com When impellerc fails with a long shader compilation error, truncate it and output to a file (flutter/flutter#182786)
2026-02-27 15619084+vashworth@users.noreply.github.com Add missing mutation-safe delegate iteration and use idomatic syntax (flutter/flutter#183018)
2026-02-27 15619084+vashworth@users.noreply.github.com Exclude arm64 if any dependencies do and print warning when using Xcode 26 (flutter/flutter#182913)
2026-02-27 victorsanniay@gmail.com Ignore unawaited_futures lint in dev/automated_tests (flutter/flutter#182922)
2026-02-27 30870216+gaaclarke@users.noreply.github.com licenses_cpp: pre-land changes for perfetto update (flutter/flutter#182965)
2026-02-27 15619084+vashworth@users.noreply.github.com Re-add extended attribute removed by SwiftPM (flutter/flutter#183011)
2026-02-27 52160996+FMorschel@users.noreply.github.com Fixes future warning for `await`ing `Future` returns in `async` bodies inside `try` blocks (flutter/flutter#182301)
2026-02-27 engine-flutter-autoroll@skia.org Roll Skia from ed220c490eea to b150186d3e23 (2 revisions) (flutter/flutter#183014)
2026-02-27 51901607+O-Hannonen@users.noreply.github.com Fix issue where web embedder is synthesizing key up events too eagerly (flutter/flutter#180692)
2026-02-27 1961493+harryterkelsen@users.noreply.github.com chore: Don't unconditionally check tools/gn formatting (flutter/flutter#182973)
2026-02-27 engine-flutter-autoroll@skia.org Roll Packages from e1d0169 to a27d7c5 (8 revisions) (flutter/flutter#183009)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: docs/ flutter/flutter/docs, for contributors framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants