Skip to content

refactor: remove material in pop_scope_test, route_notification_message_test, two_dimensional_utils, two_dimensional_viewport_test#182699

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
rkishan516:simple-cross-imports-3
Mar 4, 2026
Merged

refactor: remove material in pop_scope_test, route_notification_message_test, two_dimensional_utils, two_dimensional_viewport_test#182699
auto-submit[bot] merged 2 commits into
flutter:masterfrom
rkishan516:simple-cross-imports-3

Conversation

@rkishan516

@rkishan516 rkishan516 commented Feb 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR removes Material imports from pop_scope_test, route_notification_message_test, two_dimensional_utils, two_dimensional_viewport_test.

part of: #177415
depends on: #182805

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. f: routes Navigator, Router, and related APIs. labels Feb 21, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 21, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully refactors several test files and utilities to remove dependencies on the Material library, replacing them with equivalent components from the base widgets library or custom test implementations. This is a positive change for test modularity and isolation. The grouping of platforms in two_dimensional_viewport_test.dart correctly reflects the default ScrollBehavior of WidgetsApp, which includes GlowingOverscrollIndicator on Android and Fuchsia. I have provided a few suggestions to improve the documentation of magic numbers in tests and a minor optimization in a test utility.

Comment thread packages/flutter/test/widgets/two_dimensional_viewport_test.dart
Comment on lines 500 to 501
// ModalRoute - builds 2
// GlowingOverscrollIndicator - builds 2
// TwoDimensionalChildListDelegate - builds 1 unless addRepaintBoundaries is false

@gemini-code-assist gemini-code-assist Bot Feb 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment explaining the RepaintBoundary count was partially removed, making the magic number 7 for Android and Fuchsia difficult to understand. Since WidgetsApp uses the default ScrollBehavior, which still adds GlowingOverscrollIndicator on these platforms, it would be better to keep and update the comment to accurately reflect the count (which is 4 extra boundaries in a 2D scroll view, 2 per axis).

Suggested change
// ModalRoute - builds 2
// GlowingOverscrollIndicator - builds 2
// TwoDimensionalChildListDelegate - builds 1 unless addRepaintBoundaries is false
// ModalRoute - builds 2
// GlowingOverscrollIndicator - builds 4 (2 per axis)
// TwoDimensionalChildListDelegate - builds 1 unless addRepaintBoundaries is false

@rkishan516 rkishan516 mentioned this pull request Feb 21, 2026
Open
@rkishan516 rkishan516 mentioned this pull request Feb 21, 2026
Merged
9 tasks
@rkishan516 rkishan516 force-pushed the simple-cross-imports-3 branch from 0ce3352 to 9e434d7 Compare February 21, 2026 05:00
victorsanni
victorsanni reviewed Feb 23, 2026
View reviewed changes
Comment thread packages/flutter/test/widgets/two_dimensional_viewport_test.dart
isA<PageRoute<void>>(),
);
switch (defaultTargetPlatform) {
case TargetPlatform.android:

@victorsanni victorsanni Feb 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like logic is changing here, why is changing the implementation of expectModalRoute insufficient?

@rkishan516 rkishan516 Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually changing to TestWidgetsApp changes more than just the route type — it also changes the
scroll behavior, which affects the widget tree structure.

Material app has MaterialScrollBehavior while TestWidgetsApp uses base ScrollBehavior.

Comment thread packages/flutter/test/widgets/widgets_app_tester.dart Outdated
const TestWidgetsApp({
super.key,
this.navigatorKey,
this.initialRoute,

@victorsanni victorsanni Feb 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have tests for all these, should they be added in a separate PR with tests?

@rkishan516 rkishan516 Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, can do that.

@rkishan516 rkishan516 force-pushed the simple-cross-imports-3 branch 4 times, most recently from 352f311 to 8bdd5f8 Compare February 24, 2026 15:34
@rkishan516 rkishan516 moved this from Todo to In Progress in Test cross-imports Review Queue Feb 24, 2026
@rkishan516 rkishan516 force-pushed the simple-cross-imports-3 branch 2 times, most recently from 9607392 to 553161a Compare February 26, 2026 03:13
victorsanni
victorsanni approved these changes Mar 3, 2026
View reviewed changes
Comment thread packages/flutter/test/widgets/two_dimensional_utils.dart

class KeepAliveCheckBoxState extends State<KeepAliveCheckBox> with AutomaticKeepAliveClientMixin {
class KeepAliveCheckBoxState extends State<KeepAliveCheckBox>
with TickerProviderStateMixin, ToggleableStateMixin, AutomaticKeepAliveClientMixin {

@victorsanni victorsanni Mar 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need TickerProviderStateMixin?

@rkishan516 rkishan516 Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaa, ToggleableStateMixin depends on it.

Comment thread packages/flutter/test/widgets/two_dimensional_viewport_test.dart
}
}

class _NoOpToggleablePainter extends ToggleablePainter {

@victorsanni victorsanni Mar 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird we have to reimplement this. But I'm ok with leaving as-is.

@rkishan516 rkishan516 Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because didn't wanted to paint anything.

victorsanni
victorsanni reviewed Mar 3, 2026
View reviewed changes
Comment thread packages/flutter/test/widgets/two_dimensional_utils.dart
}
}

class _NoOpToggleablePainter extends ToggleablePainter {

@victorsanni victorsanni Mar 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToggleablePainter is a ChangeNotifier, so subclasses will have to be disposed.

@rkishan516 rkishan516 Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, updating.

@rkishan516 rkishan516 force-pushed the simple-cross-imports-3 branch from 553161a to 6ac5567 Compare March 3, 2026 03:22
@rkishan516 rkishan516 added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Mar 4, 2026
Merged via the queue into flutter:master with commit b9b5048 Mar 4, 2026
152 of 153 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Test cross-imports Review Queue Mar 4, 2026
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2026
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2026
@engine-flutter-autoroll
b9b504840 refactor: remove material in pop_scope_test, route_notifica…
9a3c7d3 
…tion_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2026
@engine-flutter-autoroll
b9b504840 refactor: remove material in pop_scope_test, route_notifica…
2501bab 
…tion_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2026
@engine-flutter-autoroll
b9b504840 refactor: remove material in pop_scope_test, route_notifica…
035918a 
…tion_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2026
@engine-flutter-autoroll
b9b504840 refactor: remove material in pop_scope_test, route_notifica…
a7b3056 
…tion_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2026
@engine-flutter-autoroll
b9b504840 refactor: remove material in pop_scope_test, route_notifica…
aacd3d2 
…tion_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699)
This was referenced Mar 4, 2026
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2026
@engine-flutter-autoroll
b9b504840 refactor: remove material in pop_scope_test, route_notifica…
de9c90c 
…tion_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2026
@engine-flutter-autoroll
b9b504840 refactor: remove material in pop_scope_test, route_notifica…
c588dbf 
…tion_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2026
@engine-flutter-autoroll
b9b504840 refactor: remove material in pop_scope_test, route_notifica…
e3f0f8e 
…tion_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2026
@engine-flutter-autoroll
b9b504840 refactor: remove material in pop_scope_test, route_notifica…
e3504bb 
…tion_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2026
@engine-flutter-autoroll
b9b504840 refactor: remove material in pop_scope_test, route_notifica…
2b2fa6b 
…tion_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Mar 5, 2026
@engine-flutter-autoroll
Roll Flutter from 46fb7210422d to d3dd7744e81f (33 revisions) (#11182)
fe3de64 
Roll Flutter from 46fb7210422d to d3dd7744e81f (33 revisions)

flutter/flutter@46fb721...d3dd774

2026-03-04 15619084+vashworth@users.noreply.github.com Show warning when plugins do not support SwiftPM (flutter/flutter#182506)
2026-03-04 15619084+vashworth@users.noreply.github.com Give guided message when project is not compatible with SwiftPM (flutter/flutter#182394)
2026-03-04 danny@tuppeny.com Pass --web-define through to web runner when using --machine mode (flutter/flutter#183228)
2026-03-04 104147021+MohammedTarigg@users.noreply.github.com Improve SwiftPM minimum platform mismatch diagnostics (flutter/flutter#182375)
2026-03-04 vegorov@google.com Use dart::bin::SetupDartIo to setup dart:io (flutter/flutter#176714)
2026-03-04 engine-flutter-autoroll@skia.org Roll Skia from 3197848b14ad to ada0b7628c79 (5 revisions) (flutter/flutter#183221)
2026-03-04 engine-flutter-autoroll@skia.org Roll Skia from fe9e9f22c531 to 3197848b14ad (15 revisions) (flutter/flutter#183198)
2026-03-04 34465683+rkishan516@users.noreply.github.com refactor: remove material in reorderable_list_test, scroll_notification_test, scroll_physics_test, shortcuts_test, sliver_floating_header_test, snapshot_widget_test (flutter/flutter#182698)
2026-03-04 34465683+rkishan516@users.noreply.github.com refactor: remove material in pop_scope_test, route_notification_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699)
2026-03-04 737941+loic-sharma@users.noreply.github.com Add dev/benchmarks/README.md (flutter/flutter#182976)
2026-03-03 jason-simmons@users.noreply.github.com Roll RapidJSON to a branch based on the current upstream head (flutter/flutter#183048)
2026-03-03 flar@google.com [Impeller] Update comments to reflect new info about 2-pass rendering (flutter/flutter#183050)
2026-03-03 47866232+chunhtai@users.noreply.github.com Add vmservices for accessibilityEvaluation (flutter/flutter#182791)
2026-03-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0dCDM2oORHwDf_pyb... to JJw5EJ87vLGqFVl4h... (flutter/flutter#183177)
2026-03-03 lukas.klingsbo@gmail.com Support mixed color spaces in `Color.lerp` (flutter/flutter#182934)
2026-03-03 36861262+QuncCccccc@users.noreply.github.com Add warning when there is a widget with color between `Material` and `ListTile` (flutter/flutter#181402)
2026-03-03 41930132+hellohuanlin@users.noreply.github.com [ios]uitest for admob banner in scrollable list gesture issue (flutter/flutter#183128)
2026-03-03 engine-flutter-autoroll@skia.org Roll Packages from faa4e22 to 9083bc9 (4 revisions) (flutter/flutter#183164)
2026-03-03 15619084+vashworth@users.noreply.github.com Build App and native asset frameworks for Add to App FlutterPluginRegistrant (flutter/flutter#183136)
2026-03-03 engine-flutter-autoroll@skia.org Roll Skia from f886711f180d to fe9e9f22c531 (4 revisions) (flutter/flutter#183155)
2026-03-03 engine-flutter-autoroll@skia.org Roll Dart SDK from e86dbe9aa742 to c597ef90d2dc (2 revisions) (flutter/flutter#183147)
2026-03-03 codefu@google.com fix: bump matcher (flutter/flutter#183167)
2026-03-02 58529443+srujzs@users.noreply.github.com Use isA to test for exceptions (flutter/flutter#183129)
2026-03-02 dpxhfxywang@163.com [two_dimensional_scrollables] Fix tableview janks when first row/column pinned (flutter/flutter#180563)
2026-03-02 victorsanniay@gmail.com Add await to callsites of BasicMessageChannel.send (flutter/flutter#182868)
2026-03-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183133)
2026-03-02 robert.ancell@canonical.com Improve FFI code for windowing (flutter/flutter#183098)
2026-03-02 kevinjchisholm@google.com [workflow] Update the changelog merge action to fetch the stable branch (flutter/flutter#183132)
2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from e180358b7a7a to f886711f180d (2 revisions) (flutter/flutter#183130)
2026-03-02 jacksongardner@google.com Merge changelog from 3.41.3. (flutter/flutter#183131)
2026-03-02 50985133+SpiralMomentum@users.noreply.github.com Make TextDecoration final and unify maskValue across platforms (flutter/flutter#183070)
2026-03-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#182640)
2026-03-02 15619084+vashworth@users.noreply.github.com Enable SwiftPM by default on master and beta (flutter/flutter#182923)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
@rkishan516 rkishan516 deleted the simple-cross-imports-3 branch March 8, 2026 01:46
xxxOVALxxx pushed a commit to xxxOVALxxx/flutter that referenced this pull request Mar 10, 2026
@rkishan516 @xxxOVALxxx
refactor: remove material in pop_scope_test, route_notification_messa…
9d60b42 
…ge_test, two_dimensional_utils, two_dimensional_viewport_test (flutter#182699)

This PR removes Material imports from pop_scope_test,
route_notification_message_test, two_dimensional_utils,
two_dimensional_viewport_test.

part of: flutter#177415
depends on: flutter#182805

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
okorohelijah pushed a commit to okorohelijah/packages that referenced this pull request Mar 26, 2026
@engine-flutter-autoroll @okorohelijah
Roll Flutter from 46fb7210422d to d3dd7744e81f (33 revisions) (flutte…
a5d8bcf 
…r#11182)

Roll Flutter from 46fb7210422d to d3dd7744e81f (33 revisions)

flutter/flutter@46fb721...d3dd774

2026-03-04 15619084+vashworth@users.noreply.github.com Show warning when plugins do not support SwiftPM (flutter/flutter#182506)
2026-03-04 15619084+vashworth@users.noreply.github.com Give guided message when project is not compatible with SwiftPM (flutter/flutter#182394)
2026-03-04 danny@tuppeny.com Pass --web-define through to web runner when using --machine mode (flutter/flutter#183228)
2026-03-04 104147021+MohammedTarigg@users.noreply.github.com Improve SwiftPM minimum platform mismatch diagnostics (flutter/flutter#182375)
2026-03-04 vegorov@google.com Use dart::bin::SetupDartIo to setup dart:io (flutter/flutter#176714)
2026-03-04 engine-flutter-autoroll@skia.org Roll Skia from 3197848b14ad to ada0b7628c79 (5 revisions) (flutter/flutter#183221)
2026-03-04 engine-flutter-autoroll@skia.org Roll Skia from fe9e9f22c531 to 3197848b14ad (15 revisions) (flutter/flutter#183198)
2026-03-04 34465683+rkishan516@users.noreply.github.com refactor: remove material in reorderable_list_test, scroll_notification_test, scroll_physics_test, shortcuts_test, sliver_floating_header_test, snapshot_widget_test (flutter/flutter#182698)
2026-03-04 34465683+rkishan516@users.noreply.github.com refactor: remove material in pop_scope_test, route_notification_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699)
2026-03-04 737941+loic-sharma@users.noreply.github.com Add dev/benchmarks/README.md (flutter/flutter#182976)
2026-03-03 jason-simmons@users.noreply.github.com Roll RapidJSON to a branch based on the current upstream head (flutter/flutter#183048)
2026-03-03 flar@google.com [Impeller] Update comments to reflect new info about 2-pass rendering (flutter/flutter#183050)
2026-03-03 47866232+chunhtai@users.noreply.github.com Add vmservices for accessibilityEvaluation (flutter/flutter#182791)
2026-03-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0dCDM2oORHwDf_pyb... to JJw5EJ87vLGqFVl4h... (flutter/flutter#183177)
2026-03-03 lukas.klingsbo@gmail.com Support mixed color spaces in `Color.lerp` (flutter/flutter#182934)
2026-03-03 36861262+QuncCccccc@users.noreply.github.com Add warning when there is a widget with color between `Material` and `ListTile` (flutter/flutter#181402)
2026-03-03 41930132+hellohuanlin@users.noreply.github.com [ios]uitest for admob banner in scrollable list gesture issue (flutter/flutter#183128)
2026-03-03 engine-flutter-autoroll@skia.org Roll Packages from faa4e22 to 9083bc9 (4 revisions) (flutter/flutter#183164)
2026-03-03 15619084+vashworth@users.noreply.github.com Build App and native asset frameworks for Add to App FlutterPluginRegistrant (flutter/flutter#183136)
2026-03-03 engine-flutter-autoroll@skia.org Roll Skia from f886711f180d to fe9e9f22c531 (4 revisions) (flutter/flutter#183155)
2026-03-03 engine-flutter-autoroll@skia.org Roll Dart SDK from e86dbe9aa742 to c597ef90d2dc (2 revisions) (flutter/flutter#183147)
2026-03-03 codefu@google.com fix: bump matcher (flutter/flutter#183167)
2026-03-02 58529443+srujzs@users.noreply.github.com Use isA to test for exceptions (flutter/flutter#183129)
2026-03-02 dpxhfxywang@163.com [two_dimensional_scrollables] Fix tableview janks when first row/column pinned (flutter/flutter#180563)
2026-03-02 victorsanniay@gmail.com Add await to callsites of BasicMessageChannel.send (flutter/flutter#182868)
2026-03-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183133)
2026-03-02 robert.ancell@canonical.com Improve FFI code for windowing (flutter/flutter#183098)
2026-03-02 kevinjchisholm@google.com [workflow] Update the changelog merge action to fetch the stable branch (flutter/flutter#183132)
2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from e180358b7a7a to f886711f180d (2 revisions) (flutter/flutter#183130)
2026-03-02 jacksongardner@google.com Merge changelog from 3.41.3. (flutter/flutter#183131)
2026-03-02 50985133+SpiralMomentum@users.noreply.github.com Make TextDecoration final and unify maskValue across platforms (flutter/flutter#183070)
2026-03-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#182640)
2026-03-02 15619084+vashworth@users.noreply.github.com Enable SwiftPM by default on master and beta (flutter/flutter#182923)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
mboetger pushed a commit to mboetger/flutter that referenced this pull request Mar 26, 2026
@rkishan516 @mboetger
refactor: remove material in pop_scope_test, route_notification_messa…
0fd3ef6 
…ge_test, two_dimensional_utils, two_dimensional_viewport_test (flutter#182699)

This PR removes Material imports from pop_scope_test,
route_notification_message_test, two_dimensional_utils,
two_dimensional_viewport_test.

part of: flutter#177415
depends on: flutter#182805

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from 46fb7210422d to d3dd7744e81f (33 revisions) (flutte…
0433719 
…r#11182)

Roll Flutter from 46fb7210422d to d3dd7744e81f (33 revisions)

flutter/flutter@46fb721...d3dd774

2026-03-04 15619084+vashworth@users.noreply.github.com Show warning when plugins do not support SwiftPM (flutter/flutter#182506)
2026-03-04 15619084+vashworth@users.noreply.github.com Give guided message when project is not compatible with SwiftPM (flutter/flutter#182394)
2026-03-04 danny@tuppeny.com Pass --web-define through to web runner when using --machine mode (flutter/flutter#183228)
2026-03-04 104147021+MohammedTarigg@users.noreply.github.com Improve SwiftPM minimum platform mismatch diagnostics (flutter/flutter#182375)
2026-03-04 vegorov@google.com Use dart::bin::SetupDartIo to setup dart:io (flutter/flutter#176714)
2026-03-04 engine-flutter-autoroll@skia.org Roll Skia from 3197848b14ad to ada0b7628c79 (5 revisions) (flutter/flutter#183221)
2026-03-04 engine-flutter-autoroll@skia.org Roll Skia from fe9e9f22c531 to 3197848b14ad (15 revisions) (flutter/flutter#183198)
2026-03-04 34465683+rkishan516@users.noreply.github.com refactor: remove material in reorderable_list_test, scroll_notification_test, scroll_physics_test, shortcuts_test, sliver_floating_header_test, snapshot_widget_test (flutter/flutter#182698)
2026-03-04 34465683+rkishan516@users.noreply.github.com refactor: remove material in pop_scope_test, route_notification_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699)
2026-03-04 737941+loic-sharma@users.noreply.github.com Add dev/benchmarks/README.md (flutter/flutter#182976)
2026-03-03 jason-simmons@users.noreply.github.com Roll RapidJSON to a branch based on the current upstream head (flutter/flutter#183048)
2026-03-03 flar@google.com [Impeller] Update comments to reflect new info about 2-pass rendering (flutter/flutter#183050)
2026-03-03 47866232+chunhtai@users.noreply.github.com Add vmservices for accessibilityEvaluation (flutter/flutter#182791)
2026-03-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0dCDM2oORHwDf_pyb... to JJw5EJ87vLGqFVl4h... (flutter/flutter#183177)
2026-03-03 lukas.klingsbo@gmail.com Support mixed color spaces in `Color.lerp` (flutter/flutter#182934)
2026-03-03 36861262+QuncCccccc@users.noreply.github.com Add warning when there is a widget with color between `Material` and `ListTile` (flutter/flutter#181402)
2026-03-03 41930132+hellohuanlin@users.noreply.github.com [ios]uitest for admob banner in scrollable list gesture issue (flutter/flutter#183128)
2026-03-03 engine-flutter-autoroll@skia.org Roll Packages from faa4e22 to 9083bc9 (4 revisions) (flutter/flutter#183164)
2026-03-03 15619084+vashworth@users.noreply.github.com Build App and native asset frameworks for Add to App FlutterPluginRegistrant (flutter/flutter#183136)
2026-03-03 engine-flutter-autoroll@skia.org Roll Skia from f886711f180d to fe9e9f22c531 (4 revisions) (flutter/flutter#183155)
2026-03-03 engine-flutter-autoroll@skia.org Roll Dart SDK from e86dbe9aa742 to c597ef90d2dc (2 revisions) (flutter/flutter#183147)
2026-03-03 codefu@google.com fix: bump matcher (flutter/flutter#183167)
2026-03-02 58529443+srujzs@users.noreply.github.com Use isA to test for exceptions (flutter/flutter#183129)
2026-03-02 dpxhfxywang@163.com [two_dimensional_scrollables] Fix tableview janks when first row/column pinned (flutter/flutter#180563)
2026-03-02 victorsanniay@gmail.com Add await to callsites of BasicMessageChannel.send (flutter/flutter#182868)
2026-03-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183133)
2026-03-02 robert.ancell@canonical.com Improve FFI code for windowing (flutter/flutter#183098)
2026-03-02 kevinjchisholm@google.com [workflow] Update the changelog merge action to fetch the stable branch (flutter/flutter#183132)
2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from e180358b7a7a to f886711f180d (2 revisions) (flutter/flutter#183130)
2026-03-02 jacksongardner@google.com Merge changelog from 3.41.3. (flutter/flutter#183131)
2026-03-02 50985133+SpiralMomentum@users.noreply.github.com Make TextDecoration final and unify maskValue across platforms (flutter/flutter#183070)
2026-03-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#182640)
2026-03-02 15619084+vashworth@users.noreply.github.com Enable SwiftPM by default on master and beta (flutter/flutter#182923)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
@Renzo-Olivares Renzo-Olivares mentioned this pull request Jun 24, 2026
Open
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victorsanni victorsanni victorsanni approved these changes
@justinmc justinmc Awaiting requested review from justinmc
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

Test cross-imports Review Queue
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rkishan516 @victorsanni